From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 0F2CEE009B8; Wed, 12 Sep 2018 06:27:43 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [198.47.19.142 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4D5D6E0097D for ; Wed, 12 Sep 2018 06:27:42 -0700 (PDT) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id w8CDRgdH103367 for ; Wed, 12 Sep 2018 08:27:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1536758862; bh=LjarzKy6SNCsER4d2h6bkV1s/nj1mXGYHjy+y1gJmP4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=HjHLuVMHab2Th2MHJiRQzNkxuP/z8kx8y4m4mYhhxd6H55gAOVfETnE5hO6NBad3K c2mY/n34rXY3JyCZAREkIAEDr8NUn94ue7uR0yoTDifAycr93vzHkQCfIBBgCK1V3A 43Oh1MnV8cT/uPJcpPFt1u144eyI0QQ5CiTzl7/E= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8CDRfxV004697 for ; Wed, 12 Sep 2018 08:27:41 -0500 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 12 Sep 2018 08:27:41 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 12 Sep 2018 08:27:41 -0500 Received: from [158.218.113.191] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w8CDRfK1005175; Wed, 12 Sep 2018 08:27:41 -0500 To: Denys Dmytriyenko , Sam Nelson References: <1536613853-20701-1-git-send-email-sam.nelson@ti.com> <20180911011527.GB32486@beryl> From: Jacob Stiffler Message-ID: Date: Wed, 12 Sep 2018 09:27:41 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180911011527.GB32486@beryl> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-ti@yoctoproject.org Subject: Re: [EXTERNAL] Re: [rocko-next][PATCH v2] ti-ipc: Add systemd startup script X-BeenThere: meta-ti@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-ti layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 13:27:43 -0000 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Denys, Can you please backport this to ti2018.03? Thank you, Jake On 9/10/2018 9:15 PM, Denys Dmytriyenko wrote: > Thanks. > > BTW, rocko-next is not a correct destination release/LTS for a patch. > > > On Mon, Sep 10, 2018 at 05:10:53PM -0400, Sam Nelson wrote: >> With systemd enabled, it is better to add the proper systemd >> script instead of legacy init.d script. >> >> Signed-off-by: Sam Nelson >> >> --- >> Changes from previous version of patch >> Remove PIDFile entries >> --- >> --- >> recipes-ti/ipc/ti-ipc/tiipclad-daemon.service | 9 +++++++++ >> recipes-ti/ipc/ti-ipc_git.bb | 21 +++++++++++++++++---- >> 2 files changed, 26 insertions(+), 4 deletions(-) >> create mode 100644 recipes-ti/ipc/ti-ipc/tiipclad-daemon.service >> >> diff --git a/recipes-ti/ipc/ti-ipc/tiipclad-daemon.service b/recipes-ti/ipc/ti-ipc/tiipclad-daemon.service >> new file mode 100644 >> index 0000000..ea26845 >> --- /dev/null >> +++ b/recipes-ti/ipc/ti-ipc/tiipclad-daemon.service >> @@ -0,0 +1,9 @@ >> +[Unit] >> +Description=TI IPC Daemon >> + >> +[Service] >> +Type=forking >> +ExecStart=/usr/bin/__LAD_DAEMON__ -g -l lad.txt >> + >> +[Install] >> +WantedBy=basic.target >> diff --git a/recipes-ti/ipc/ti-ipc_git.bb b/recipes-ti/ipc/ti-ipc_git.bb >> index 23b8d94..8b3ac91 100644 >> --- a/recipes-ti/ipc/ti-ipc_git.bb >> +++ b/recipes-ti/ipc/ti-ipc_git.bb >> @@ -4,12 +4,13 @@ HOMEPAGE="http://processors.wiki.ti.com/index.php/Category:IPC" >> require ti-ipc.inc >> require ti-ipc-common.inc >> >> -PR = "${INC_PR}.1" >> +PR = "${INC_PR}.2" >> >> DEPENDS += "virtual/kernel" >> >> SRC_URI += "file://tiipclad-daemon.sh \ >> file://omap_remoteproc.conf \ >> + file://tiipclad-daemon.service \ >> file://0001-Add-kernel-build-dir.patch \ >> " >> >> @@ -23,11 +24,13 @@ DAEMON_k2g = "lad_66ak2g" >> DAEMON_omapl138 = "lad_omapl138" >> DAEMON_k3 = "lad_am65xx" >> >> -inherit autotools-brokensep pkgconfig update-rc.d >> +inherit autotools-brokensep pkgconfig update-rc.d systemd >> >> INITSCRIPT_NAME = "tiipclad-daemon.sh" >> INITSCRIPT_PARAMS = "defaults 10" >> >> +SYSTEMD_SERVICE_${PN} = "tiipclad-daemon.service" >> + >> EXTRA_OECONF += "PLATFORM=${PLATFORM} KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} KERNEL_BUILD_DIR=${STAGING_KERNEL_BUILDDIR}" >> >> do_compile[depends] += "virtual/kernel:do_shared_workdir" >> @@ -40,10 +43,20 @@ do_configure() { >> do_install_append() { >> install -d ${D}${sysconfdir}/init.d/ >> >> - # Modify the tiipclad-daemon.sh script to point to the right >> + # Modify the startup scripts to point to the right >> # lad daemon executable. >> sed -i -e "s/__LAD_DAEMON__/${DAEMON}/" ${WORKDIR}/tiipclad-daemon.sh >> - install -c -m 755 ${WORKDIR}/tiipclad-daemon.sh ${D}${sysconfdir}/init.d/${INITSCRIPT_NAME} >> + sed -i -e "s/__LAD_DAEMON__/${DAEMON}/" ${WORKDIR}/tiipclad-daemon.service >> + >> + systemd_enabled=${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '1', '0', d)} >> + if [ ${systemd_enabled} -eq 1 ] >> + then >> + install -d ${D}${systemd_system_unitdir} >> + install -m 0644 ${WORKDIR}/tiipclad-daemon.service ${D}${systemd_system_unitdir} >> + else >> + install -d ${D}${sysconfdir}/init.d/ >> + install -c -m 755 ${S}/scripts/tiipclad-daemon.sh ${D}${sysconfdir}/init.d/${INITSCRIPT_NAME} >> + fi >> } >> >> do_install_append_dra7xx() { >> -- >> 1.9.1 >> >> -- >> _______________________________________________ >> meta-ti mailing list >> meta-ti@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/meta-ti