From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A3532F33 for ; Thu, 22 Sep 2022 11:26:29 +0000 (UTC) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1obKLY-0005Or-C2; Thu, 22 Sep 2022 13:26:24 +0200 Message-ID: Date: Thu, 22 Sep 2022 13:26:23 +0200 Precedence: bulk X-Mailing-List: regressions@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US, de-DE To: August Wikerfors , Harry Wentland , Leo Li , Rodrigo Siqueira Cc: Alex Deucher , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev References: From: Thorsten Leemhuis Subject: Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected) In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1663845989;90d27fb4; X-HE-SMSGID: 1obKLY-0005Or-C2 Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. @amdgpu developers, what up here? August afaics didn't even get a single reply for his report that even identifies the change that's causing the problem. We're already late in the development cycle, so it would be good if someone could take a closer look into this before it's too late for 6.0. Ciao, Thorsten #regzbot poke On 17.09.22 18:57, August Wikerfors wrote: > Hi, > with every kernel version since v6.0-rc1, including the latest git > master, there are constant graphical issues on this laptop, such as > heavy stuttering (this is especially noticeable while typing on the > keyboard), parts of the screen showing random noise, and the entire > desktop environment freezing. > > I bisected the issue which showed that this is the first bad commit: > >> commit 7cc191ee7621b7145c6cc9c18a4e1929bb5f136e >> Author: Leo Li >> Date:   Wed Mar 30 12:45:09 2022 -0400 >> >>     drm/amd/display: Implement MPO PSR SU >>         [WHY] >>         For additional power savings, PSR SU (also referred to as >> PSR2) can be >>     enabled on eDP panels with PSR SU support. >>         PSR2 saves more power compared to PSR1 by allowing more >> opportunities >>     for the display hardware to be shut down. In comparison to PSR1, Shut >>     down can now occur in-between frames, as well as in display regions >>     where there is no visible update. In otherwords, it allows for some >>     display hw components to be enabled only for a **selectively >> updated** >>     region of the visible display. Hence PSR SU. >>         [HOW] >>         To define the SU region, support from the OS is required. OS >> needs to >>     inform driver of damaged regions that need to be flushed to the eDP >>     panel. Today, such support is lacking in most compositors. >>         Therefore, an in-between solution is to implement PSR SU for >> MPO and >>     cursor scenarios. The plane bounds can be used to define the damaged >>     region to be flushed to panel. This is achieved by: >>         * Leveraging dm_crtc_state->mpo_requested flag to identify >> when MPO is >>       enabled. >>     * If MPO is enabled, only add updated plane bounds to dirty region. >>       Determine plane update by either: >>         * Existence of drm damaged clips attached to the plane (added >> by a >>           damage-aware compositor) >>         * Change in fb id (flip) >>         * Change in plane bounds (position and dimensions) >>     * If cursor is enabled, the old_pos and new_pos of cursor plus cursor >>       size is used as damaged regions(*). >>         (*) Cursor updates follow a different code path through DC. >> PSR SU for >>     cursor is already implemented in DC, and the only thing required to >>     enable is to set DC_PSR_VERSION_SU_1 on the eDP link. See >>     dcn10_dmub_update_cursor_data(). >>         Signed-off-by: Leo Li >>     Acked-by: Leo Li >>     Reviewed-by: Harry Wentland >>     Signed-off-by: Alex Deucher > > #regzbot introduced: 7cc191ee7621b7145c6cc9c18a4e1929bb5f136e > > Note that while bisecting I also needed to apply commit > 9946e39fe8d0a5da9eb947d8e40a7ef204ba016e as the keyboard doesn't work > without it. > > Laptop model: Lenovo Yoga 7 14ARB7 > CPU: AMD Ryzen 5 6600U > Kernel config: > https://raw.githubusercontent.com/archlinux/svntogit-packages/aa564cf7088b1d834ef4cda9cb48ff0283fde5c5/trunk/config > Distribution: Arch Linux > Desktop environment: KDE Plasma 5.25.5 > > lspci: >> $ lspci -nn >> 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b5] (rev 01) >> 00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b6] >> 00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:02.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:02.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14ba] >> 00:02.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14ba] >> 00:02.5 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14ba] >> 00:03.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:03.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14cd] >> 00:04.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b9] (rev 10) >> 00:08.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b9] (rev 10) >> 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus >> Controller [1022:790b] (rev 71) >> 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC >> Bridge [1022:790e] (rev 51) >> 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:1679] >> 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167a] >> 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167b] >> 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167c] >> 00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167d] >> 00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167e] >> 00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167f] >> 00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:1680] >> 01:00.0 Network controller [0280]: MEDIATEK Corp. MT7922 802.11ax PCI >> Express Wireless Network Adapter [14c3:0616] >> 02:00.0 Non-Volatile memory controller [0108]: Samsung Electronics Co >> Ltd Device [144d:a80b] (rev 02) >> 03:00.0 SD Host controller [0805]: O2 Micro, Inc. SD/MMC Card Reader >> Controller [1217:8621] (rev 01) >> 33:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. >> [AMD/ATI] Rembrandt [Radeon 680M] [1002:1681] (rev c2) >> 33:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] >> Rembrandt Radeon High Definition Audio Controller [1002:1640] >> 33:00.2 Encryption controller [1080]: Advanced Micro Devices, Inc. >> [AMD] VanGogh PSP/CCP [1022:1649] >> 33:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:161d] >> 33:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:161e] >> 33:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. >> [AMD] ACP/ACP3X/ACP6x Audio Coprocessor [1022:15e2] (rev 60) >> 33:00.6 Audio device [0403]: Advanced Micro Devices, Inc. [AMD] Family >> 17h/19h HD Audio Controller [1022:15e3] >> 34:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:161f] >> 34:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:15d6] >> 34:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:15d7] >> 34:00.5 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:162e] > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42122C6FA82 for ; Thu, 22 Sep 2022 12:54:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4FAD10EB04; Thu, 22 Sep 2022 12:54:21 +0000 (UTC) Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:8234::]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81C4710EAC7 for ; Thu, 22 Sep 2022 11:26:27 +0000 (UTC) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1obKLY-0005Or-C2; Thu, 22 Sep 2022 13:26:24 +0200 Message-ID: Date: Thu, 22 Sep 2022 13:26:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US, de-DE To: August Wikerfors , Harry Wentland , Leo Li , Rodrigo Siqueira References: From: Thorsten Leemhuis Subject: Re: [REGRESSION] Graphical issues on Lenovo Yoga 7 14ARB7 laptop since v6.0-rc1 (bisected) In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de; regressions@leemhuis.info; 1663845987; 8c6bb610; X-HE-SMSGID: 1obKLY-0005Or-C2 X-Mailman-Approved-At: Thu, 22 Sep 2022 12:54:13 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, regressions@lists.linux.dev Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi, this is your Linux kernel regression tracker. Top-posting for once, to make this easily accessible to everyone. @amdgpu developers, what up here? August afaics didn't even get a single reply for his report that even identifies the change that's causing the problem. We're already late in the development cycle, so it would be good if someone could take a closer look into this before it's too late for 6.0. Ciao, Thorsten #regzbot poke On 17.09.22 18:57, August Wikerfors wrote: > Hi, > with every kernel version since v6.0-rc1, including the latest git > master, there are constant graphical issues on this laptop, such as > heavy stuttering (this is especially noticeable while typing on the > keyboard), parts of the screen showing random noise, and the entire > desktop environment freezing. > > I bisected the issue which showed that this is the first bad commit: > >> commit 7cc191ee7621b7145c6cc9c18a4e1929bb5f136e >> Author: Leo Li >> Date:   Wed Mar 30 12:45:09 2022 -0400 >> >>     drm/amd/display: Implement MPO PSR SU >>         [WHY] >>         For additional power savings, PSR SU (also referred to as >> PSR2) can be >>     enabled on eDP panels with PSR SU support. >>         PSR2 saves more power compared to PSR1 by allowing more >> opportunities >>     for the display hardware to be shut down. In comparison to PSR1, Shut >>     down can now occur in-between frames, as well as in display regions >>     where there is no visible update. In otherwords, it allows for some >>     display hw components to be enabled only for a **selectively >> updated** >>     region of the visible display. Hence PSR SU. >>         [HOW] >>         To define the SU region, support from the OS is required. OS >> needs to >>     inform driver of damaged regions that need to be flushed to the eDP >>     panel. Today, such support is lacking in most compositors. >>         Therefore, an in-between solution is to implement PSR SU for >> MPO and >>     cursor scenarios. The plane bounds can be used to define the damaged >>     region to be flushed to panel. This is achieved by: >>         * Leveraging dm_crtc_state->mpo_requested flag to identify >> when MPO is >>       enabled. >>     * If MPO is enabled, only add updated plane bounds to dirty region. >>       Determine plane update by either: >>         * Existence of drm damaged clips attached to the plane (added >> by a >>           damage-aware compositor) >>         * Change in fb id (flip) >>         * Change in plane bounds (position and dimensions) >>     * If cursor is enabled, the old_pos and new_pos of cursor plus cursor >>       size is used as damaged regions(*). >>         (*) Cursor updates follow a different code path through DC. >> PSR SU for >>     cursor is already implemented in DC, and the only thing required to >>     enable is to set DC_PSR_VERSION_SU_1 on the eDP link. See >>     dcn10_dmub_update_cursor_data(). >>         Signed-off-by: Leo Li >>     Acked-by: Leo Li >>     Reviewed-by: Harry Wentland >>     Signed-off-by: Alex Deucher > > #regzbot introduced: 7cc191ee7621b7145c6cc9c18a4e1929bb5f136e > > Note that while bisecting I also needed to apply commit > 9946e39fe8d0a5da9eb947d8e40a7ef204ba016e as the keyboard doesn't work > without it. > > Laptop model: Lenovo Yoga 7 14ARB7 > CPU: AMD Ryzen 5 6600U > Kernel config: > https://raw.githubusercontent.com/archlinux/svntogit-packages/aa564cf7088b1d834ef4cda9cb48ff0283fde5c5/trunk/config > Distribution: Arch Linux > Desktop environment: KDE Plasma 5.25.5 > > lspci: >> $ lspci -nn >> 00:00.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b5] (rev 01) >> 00:00.2 IOMMU [0806]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b6] >> 00:01.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:02.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:02.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14ba] >> 00:02.4 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14ba] >> 00:02.5 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14ba] >> 00:03.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:03.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14cd] >> 00:04.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:08.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b7] (rev 01) >> 00:08.1 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b9] (rev 10) >> 00:08.3 PCI bridge [0604]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:14b9] (rev 10) >> 00:14.0 SMBus [0c05]: Advanced Micro Devices, Inc. [AMD] FCH SMBus >> Controller [1022:790b] (rev 71) >> 00:14.3 ISA bridge [0601]: Advanced Micro Devices, Inc. [AMD] FCH LPC >> Bridge [1022:790e] (rev 51) >> 00:18.0 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:1679] >> 00:18.1 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167a] >> 00:18.2 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167b] >> 00:18.3 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167c] >> 00:18.4 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167d] >> 00:18.5 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167e] >> 00:18.6 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:167f] >> 00:18.7 Host bridge [0600]: Advanced Micro Devices, Inc. [AMD] Device >> [1022:1680] >> 01:00.0 Network controller [0280]: MEDIATEK Corp. MT7922 802.11ax PCI >> Express Wireless Network Adapter [14c3:0616] >> 02:00.0 Non-Volatile memory controller [0108]: Samsung Electronics Co >> Ltd Device [144d:a80b] (rev 02) >> 03:00.0 SD Host controller [0805]: O2 Micro, Inc. SD/MMC Card Reader >> Controller [1217:8621] (rev 01) >> 33:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. >> [AMD/ATI] Rembrandt [Radeon 680M] [1002:1681] (rev c2) >> 33:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] >> Rembrandt Radeon High Definition Audio Controller [1002:1640] >> 33:00.2 Encryption controller [1080]: Advanced Micro Devices, Inc. >> [AMD] VanGogh PSP/CCP [1022:1649] >> 33:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:161d] >> 33:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:161e] >> 33:00.5 Multimedia controller [0480]: Advanced Micro Devices, Inc. >> [AMD] ACP/ACP3X/ACP6x Audio Coprocessor [1022:15e2] (rev 60) >> 33:00.6 Audio device [0403]: Advanced Micro Devices, Inc. [AMD] Family >> 17h/19h HD Audio Controller [1022:15e3] >> 34:00.0 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:161f] >> 34:00.3 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:15d6] >> 34:00.4 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:15d7] >> 34:00.5 USB controller [0c03]: Advanced Micro Devices, Inc. [AMD] >> Device [1022:162e] > >