All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Hedde <damien.hedde@greensocs.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Mark Burton" <mark.burton@greensocs.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v9 5/9] docs/clocks: add device's clock documentation
Date: Fri, 17 Apr 2020 18:52:28 +0200	[thread overview]
Message-ID: <eee8cb35-c7bc-f60c-fd10-073320a41ed7@greensocs.com> (raw)
In-Reply-To: <CAFEAcA_NVJg9KS-yrYDKe0GbAC7xah6mH1SmkjLmyr-BNPF8WQ@mail.gmail.com>



On 4/17/20 5:52 PM, Peter Maydell wrote:
> On Mon, 6 Apr 2020 at 14:53, Damien Hedde <damien.hedde@greensocs.com> wrote:
>>
>> Add the documentation about the clock inputs and outputs in devices.
>>
>> This is based on the original work of Frederic Konrad.
>>
>> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> 
> I did an edit pass on this to address minor grammar/style
> issues and some Sphinx syntax stuff (notably, using
> "code-block:: c" renders nicer than a plain literal block).
> Diff against this patch is below; it looks bigger than
> you might expect because one of the changes was that I
> rewrapped some of the paragraphs that were close to or
> over 80 chars per line. Changes include the tweak Markus
> asked for.
> 

Thanks a lot,

I thought that the maximum column size was 80, should we use a
bit less in practice ?

I'll apply this and do a respin along with your other patch 1 catcha
bout the integer type in traces.

Damien



  reply	other threads:[~2020-04-17 16:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 13:52 [PATCH v9 0/9] Clock framework API Damien Hedde
2020-04-06 13:52 ` [PATCH v9 1/9] hw/core/clock: introduce clock object Damien Hedde
2020-04-17 14:39   ` Peter Maydell
2020-04-06 13:52 ` [PATCH v9 2/9] hw/core/clock-vmstate: define a vmstate entry for clock state Damien Hedde
2020-04-06 13:52 ` [PATCH v9 3/9] qdev: add clock input&output support to devices Damien Hedde
2020-04-06 13:52 ` [PATCH v9 4/9] qdev-clock: introduce an init array to ease the device construction Damien Hedde
2020-04-06 13:52 ` [PATCH v9 5/9] docs/clocks: add device's clock documentation Damien Hedde
2020-04-07  5:07   ` Markus Armbruster
2020-04-08 10:06     ` Damien Hedde
2020-04-14  7:15       ` Markus Armbruster
2020-04-17 15:52   ` Peter Maydell
2020-04-17 16:52     ` Damien Hedde [this message]
2020-04-06 13:52 ` [PATCH v9 6/9] hw/misc/zynq_slcr: add clock generation for uarts Damien Hedde
2020-04-06 13:52 ` [PATCH v9 7/9] hw/char/cadence_uart: add clock support Damien Hedde
2020-04-06 13:52 ` [PATCH v9 8/9] hw/arm/xilinx_zynq: connect uart clocks to slcr Damien Hedde
2020-04-06 13:52 ` [PATCH v9 9/9] qdev-monitor: print the device's clock with info qtree Damien Hedde
2020-04-17 17:45 ` [PATCH v9 0/9] Clock framework API Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eee8cb35-c7bc-f60c-fd10-073320a41ed7@greensocs.com \
    --to=damien.hedde@greensocs.com \
    --cc=alistair.francis@wdc.com \
    --cc=alistair@alistair23.me \
    --cc=berrange@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=edgar.iglesias@xilinx.com \
    --cc=ehabkost@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mark.burton@greensocs.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.