From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eelco Chaudron <echaudro@redhat.com>
Subject: Re: [PATCH] app/testpmd: adds mlockall() to fix pages
Date: Fri, 29 Sep 2017 09:59:38 +0200
Message-ID: <eeec1767-b0f6-0aad-92be-85b136181113@redhat.com>
References: <22990026376b08418cb0eb6f028840c03e89f47f.1505221429.git.echaudro@redhat.com>
 <4147502.SWF1kaKTU5@xps> <2ff0680b-b73f-fd1f-9f41-caa38a13bcde@redhat.com>
 <20170919072818.zbhjsfhpbqf4fqxz@neon>
 <cb7d4d53-eb83-2a06-ad36-52626ad893fe@redhat.com>
 <20170925075319.agzytjfgai7usngs@platinum>
Reply-To: echaudro@redhat.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, jingjing.wu@intel.com
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 23D931AF03
 for <dev@dpdk.org>; Fri, 29 Sep 2017 09:59:18 +0200 (CEST)
In-Reply-To: <20170925075319.agzytjfgai7usngs@platinum>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 25/09/17 09:53, Olivier MATZ wrote:
>> [SNIP]
>> I did not at add a log, as the rte log subsystem is not yet initialized.
>> However we could add a printf("WARNING: mlockall() failed with error %s")
>> like message. What do you think?
> Since it's not critical, maybe NOTICE is better than WARNING.
>
> One more question: what would be the drawback of calling
> mlockall() after eal_init()? (rte_log would be initialized)
>
Calling mlockall() after eal_init() does seem to have the same effect.
I'll send out a v2 patch later today with a rte_log(NOTICE).