From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754649AbdKAMnG (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Nov 2017 08:43:06 -0400
Received: from vps-vb.mhejs.net ([37.28.154.113]:35564 "EHLO vps-vb.mhejs.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754496AbdKAMnF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Nov 2017 08:43:05 -0400
Subject: Re: [PATCH v2] net: phy: leds: Add support for "link" trigger
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <52ce25a6-8d6b-039d-ca08-90595eb9ee72@maciej.szmigiero.name>
 <20171101121611.GD12680@lunn.ch>
 <b789b023-2e7b-1f5b-59a6-9676db74e850@maciej.szmigiero.name>
 <20171101123705.GG12680@lunn.ch>
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Message-ID: <eeffcfd4-0d3c-79cb-7d26-ac84acaec1e8@maciej.szmigiero.name>
Date: Wed, 1 Nov 2017 13:43:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171101123705.GG12680@lunn.ch>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On 01.11.2017 13:37, Andrew Lunn wrote:
> Hi Maciej
> 
> I don't particularly like the
> 
>        if (!phy->link)
>                 goto out_change_speed;
> 
> part of the existing code. Makes me thing of BASIC. goto is good for
> error handling, but this is not an error.
> 
> If you feel like it, maybe you can refactor this code? Add a function like:
> 
> phy_led_trigger_no_link(struct phy_device *phy)
> {
>         if (phy->last_triggered) {
>                 led_trigger_event(&phy->last_triggered->trigger,
>                                   LED_OFF);
>                 phy->last_triggered = NULL;
>         }
> }
> 
> and call it, rather than using goto? It then becomes a lot more
> obvious what your change is doing, turning the LED off when there is
> no link.

All right, will do this, too.

> Thanks
>    Andrew
> 

Maciej