From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N Date: Thu, 17 May 2018 19:02:16 +0300 Message-ID: References: <20180517154330.10678-1-dsahern@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: alexandre.belloni@bootlin.com To: David Ahern , netdev@vger.kernel.org Return-path: Received: from mail-lf0-f65.google.com ([209.85.215.65]:43201 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbeEQQCT (ORCPT ); Thu, 17 May 2018 12:02:19 -0400 Received: by mail-lf0-f65.google.com with SMTP id n18-v6so9526187lfh.10 for ; Thu, 17 May 2018 09:02:18 -0700 (PDT) In-Reply-To: <20180517154330.10678-1-dsahern@gmail.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 05/17/2018 06:43 PM, David Ahern wrote: > Other ethernet drivers default to N. There is no reason for Microsemi > to default to y. I believe Linus has set the bar at a feature that cures > cancer can be enabled by default. [1] > > [1] https://lkml.org/lkml/2010/3/2/366 > > Signed-off-by: David Ahern > --- > drivers/net/ethernet/mscc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mscc/Kconfig b/drivers/net/ethernet/mscc/Kconfig > index 36c84625d54e..0ef40b05c8af 100644 > --- a/drivers/net/ethernet/mscc/Kconfig > +++ b/drivers/net/ethernet/mscc/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: (GPL-2.0 OR MIT) > config NET_VENDOR_MICROSEMI > bool "Microsemi devices" > - default y > + default n You know that N is the default default? :-) [...] MBR, Sergei