From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32CC5C433ED for ; Thu, 8 Apr 2021 16:14:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B31CA61132 for ; Thu, 8 Apr 2021 16:14:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B31CA61132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUXJ2-000362-Ks for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 12:14:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUXB3-0002EU-28 for qemu-devel@nongnu.org; Thu, 08 Apr 2021 12:06:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUXAz-0002Op-9q for qemu-devel@nongnu.org; Thu, 08 Apr 2021 12:06:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617897996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o7M4S7YeFOurpr72/U8vQJOq1S1eK4haEBXv7PkHfAg=; b=SuTPNQcC1CBUM9Ttq4KK6szBZGYZBL72WSwY0EqSBtN1NBPi4XHr7fNKbq+8sBUwSZED7X eVoVsizHRWPZ8YrRHW60z4OwcZCSz4O8Dy6hdkGUyh7zxXfrdeWrywXiZccbA8B2r4eA6L If/yKrOJy/+KzeuYI0xcN7e0/c4UbLw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-gkkz658POXGpmTnS4mcqEw-1; Thu, 08 Apr 2021 12:06:34 -0400 X-MC-Unique: gkkz658POXGpmTnS4mcqEw-1 Received: by mail-wm1-f70.google.com with SMTP id n2so595909wmi.2 for ; Thu, 08 Apr 2021 09:06:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o7M4S7YeFOurpr72/U8vQJOq1S1eK4haEBXv7PkHfAg=; b=MWliYKD2d+Sr0f1PmW2GA8j+QQ0Vb6QLMI+DjZ0p2rekeV1XA2/heUBOzjm9ilPCQf UYCVGPy09Z9QyHzVzX0ZwiLGcabo7DUwwzozhA6jPN9hY3/QabfeFGSxUxnQWK2eiuSD dFYX414Qr2qtNnbQIXXSwUzYNqMkX33jVyELJg+mmw3JQXzTLofZ+NyypDPtjsGto95L 5FgdKT0P8wgaUbbs8ZokDa8dwuYm7Yb2j2A5rCr8iQ12PPLFSJQkOptQ0cx9X9S2Jltn hlZaVm5wUquJaxbrnuErs5nHy7IZt2+4fLA4DDkPecBZIgFDn08a0OKsyaTSwGPG2x6H Acqg== X-Gm-Message-State: AOAM532ih3Z3eJ+yIQ94YxVFtKULmOCi6dH3ImSAOO1MUBwBWPjN0BgM yZOBdbOauLx25hIoifgODpLTdv24cy3nSZJFpGXmcjFBS+lK6ZITgZ0tHjiG4Hvp6RjU2c5TV7I QotU47LWg8lbY/pg= X-Received: by 2002:adf:db52:: with SMTP id f18mr6448868wrj.225.1617897992878; Thu, 08 Apr 2021 09:06:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyJhd3IKm+julBedZ3yb7fLMkJbw91ADrNg/lCI2rOtj4QWJHwePGhaatjjgprlCARMOvoBg== X-Received: by 2002:adf:db52:: with SMTP id f18mr6448808wrj.225.1617897992512; Thu, 08 Apr 2021 09:06:32 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.120]) by smtp.gmail.com with ESMTPSA id m14sm3724532wrh.28.2021.04.08.09.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 09:06:32 -0700 (PDT) Subject: Re: [RFC PATCH v2 04/11] qemu-iotests: delay QMP socket timers To: Paolo Bonzini , qemu-block@nongnu.org References: <20210407135021.48330-1-eesposit@redhat.com> <20210407135021.48330-5-eesposit@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: Date: Thu, 8 Apr 2021 18:06:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-devel@nongnu.org, Max Reitz , Cleber Rosa , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 08/04/2021 17:40, Paolo Bonzini wrote: > On 07/04/21 15:50, Emanuele Giuseppe Esposito wrote: >>       def get_qmp_events_filtered(self, wait=60.0): >>           result = [] >> -        for ev in self.get_qmp_events(wait=wait): >> +        qmp_wait = wait >> +        if qemu_gdb: >> +            qmp_wait = 0.0 >> +        for ev in self.get_qmp_events(wait=qmp_wait): >>               result.append(filter_qmp_event(ev)) >>           return result > > Should this be handled in get_qmp_events instead, since you're basically > changing all the callers? get_qmp_events is in python/machine.py, which as I understand might be used also by some other scripts, so I want to keep the changes there to the minimum. Also, machine.py has no access to qemu_gdb or qemu_valgrind, so passing a boolean or something to delay the timer would still require to add a similar check in all sections. Or do you have a cleaner way to do this? Emanuele