From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C05623FC3 for ; Fri, 17 Sep 2021 17:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631899868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEhlSynRz4N3FlqjKloHS3Kh6FbRHHHviXrUI8c+7hU=; b=La/oUu1y450HncR6ZrR0YLrD8Lo0qf67NyXPqf9RC2+kgzZe+k4W9/L+2DtUXLxTEn2aNt 1BmE3BFkx+cTUrY/070W6OQG089Z13ESuSiieowYx/NWPTWZB2WNuViizdjnrnIcfPkfsf h/GVHC/Oc0BZkdCzFEht7reSvfos5zY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-UTCX1VJlMQ-4f0VUtPs-Vg-1; Fri, 17 Sep 2021 13:31:07 -0400 X-MC-Unique: UTCX1VJlMQ-4f0VUtPs-Vg-1 Received: by mail-wm1-f71.google.com with SMTP id l27-20020a05600c1d1b00b00308ef9d8a98so3312455wms.9 for ; Fri, 17 Sep 2021 10:31:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=aEhlSynRz4N3FlqjKloHS3Kh6FbRHHHviXrUI8c+7hU=; b=LqYafL3qR1MXELat8XPnsq8DWuuX/uZiZyMqJLouELWy/nAjW6Y2OEyTgwqsOiliSY DpOWcBa8Vdtdd1MXXLN/nbl5rHzshT9BK3ldJ/mXipN8u0uw3Ttp8RhBKiMCGdaFHWMk h9CKFzIsonT8K/GvVUxx+pT1AmgvgXHgUnPfz8x7Pq3FSyjxiGc7qg1zqcfH1XRZ3GiW ij6yykcDwGX6AlvoJJ+AshuEhJyYPHJyJZsDOXZQweBDvveSyDsmPYhDU8nf3yAx71Qo bc/qvSMDXXr/D+dhuZy2W8RUtBlAwork8umXCUl/dA8Jp2zx6n1f0GCv5Wx2FVb3Kf8z fBkA== X-Gm-Message-State: AOAM531EXfQp/UGp5zCF2jVC5K37gd8jCyAuQSZMzJq88AmQauUfe+5T vbg+NcRi5aVZUk7T7J8g+1SPe0ZVFpPITKR/VYKpe2mftOpfZGsQLDbML/chMHannlIp0ruD2n7 7kYyXv/mtAID+S6Q= X-Received: by 2002:a1c:f60c:: with SMTP id w12mr16611807wmc.3.1631899866388; Fri, 17 Sep 2021 10:31:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzVIUlMhzaUcH8l76E4hgTLORUq4B9hZOc19zV/fBmI/JkObBLUeLEOY5d8c74bW5TKIB7kQ== X-Received: by 2002:a1c:f60c:: with SMTP id w12mr16611785wmc.3.1631899866185; Fri, 17 Sep 2021 10:31:06 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-244-134.dyn.eolo.it. [146.241.244.134]) by smtp.gmail.com with ESMTPSA id a72sm11730585wme.5.2021.09.17.10.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 10:31:05 -0700 (PDT) Message-ID: Subject: Re: [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" From: Paolo Abeni To: Eric Dumazet Cc: netdev , "David S. Miller" , Jakub Kicinski , Mat Martineau , Ayush Sawal , MPTCP Upstream Date: Fri, 17 Sep 2021 19:31:04 +0200 In-Reply-To: References: User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pabeni@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2021-09-17 at 09:41 -0700, Eric Dumazet wrote: > On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni wrote: > > This is a partial revert for commit b796d04bd014 ("tcp: > > factor out tcp_build_frag()"). > > > > MPTCP was the only user of the tcp_build_frag helper, and after > > the previous patch MPTCP does not use the mentioned helper anymore. > > Let's avoid exposing TCP internals. > > > > The revert is partial, as tcp_remove_empty_skb(), exposed > > by the same commit is still required. > > > > I would simply remove the extern in include, and make this nice helper static ? > > This would avoid code churn, and keep a clean code. I thought you would have preferred otherwise. I'll make the helper static in the next iteration. Thanks! Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183AAC433F5 for ; Fri, 17 Sep 2021 17:31:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECD6960F21 for ; Fri, 17 Sep 2021 17:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233331AbhIQRcf (ORCPT ); Fri, 17 Sep 2021 13:32:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21418 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231855AbhIQRcd (ORCPT ); Fri, 17 Sep 2021 13:32:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631899870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEhlSynRz4N3FlqjKloHS3Kh6FbRHHHviXrUI8c+7hU=; b=efrrvyKp1zgzZm/y6FIufpIdLg9Uwap++8HwOaWXm58ORNFcL3vxlvRSAG10izvxWbF7RU CPagKpikeYdrUPE1ae2Qb3e28CaSRvLqnkZg8ePDvkn0WKwpple4qMH1LyDPoh8V7JXVoh tR5BZv0eWT/V5hETH3Pu/CiJgvVRDJA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-BAXfB_1zNsScRGDqnN35_A-1; Fri, 17 Sep 2021 13:31:07 -0400 X-MC-Unique: BAXfB_1zNsScRGDqnN35_A-1 Received: by mail-wr1-f72.google.com with SMTP id m1-20020a056000180100b0015e1ec30ac3so3966584wrh.8 for ; Fri, 17 Sep 2021 10:31:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=aEhlSynRz4N3FlqjKloHS3Kh6FbRHHHviXrUI8c+7hU=; b=AXp7H5IwiPHOjjXIsaYaRPE2bpFm4UEr6wEgazHBeSKHGClbHA9DJoftQPIQjJiw7g RraGKSYZ4PVTcrYk0xj+rLcerH2EpRJhsrRdU27UYoE60bswsVydCBS/uOy6zjIGehfD WVCpjibHPBOy1goz8Wji6TIGtylfZPZGXuKZc0KAYwV2pfAixNloo/mSRd/piqjYLy3o dOOMB0t7UTmr+dJFAxHdIFbGYJThNi2DtTVrHhksu/EPtkbpk4kX+hd0NCXoxUkuwqiE 1zBCFVPPWHpfDbotIlnq/oDILDZTPkzgzXS6EBIXPrwBSLx3m7v4ULR1D4SxsNdf0M6m cPEg== X-Gm-Message-State: AOAM531BKpM/ZTTPl56qZs/nVfUmZOPa4l34GnN4Q3qTyeYoKxYKWlPb HhDrZQS44vl0zKLlyvQBHCEWFwOiXi+91teQ/N1pho5kVzfkL1EitQuldtVM5YYgvnh6PJuLkGp j6oPz+ltldvctXNnB X-Received: by 2002:a1c:f60c:: with SMTP id w12mr16611802wmc.3.1631899866381; Fri, 17 Sep 2021 10:31:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzVIUlMhzaUcH8l76E4hgTLORUq4B9hZOc19zV/fBmI/JkObBLUeLEOY5d8c74bW5TKIB7kQ== X-Received: by 2002:a1c:f60c:: with SMTP id w12mr16611785wmc.3.1631899866185; Fri, 17 Sep 2021 10:31:06 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-244-134.dyn.eolo.it. [146.241.244.134]) by smtp.gmail.com with ESMTPSA id a72sm11730585wme.5.2021.09.17.10.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 10:31:05 -0700 (PDT) Message-ID: Subject: Re: [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" From: Paolo Abeni To: Eric Dumazet Cc: netdev , "David S. Miller" , Jakub Kicinski , Mat Martineau , Ayush Sawal , MPTCP Upstream Date: Fri, 17 Sep 2021 19:31:04 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2021-09-17 at 09:41 -0700, Eric Dumazet wrote: > On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni wrote: > > This is a partial revert for commit b796d04bd014 ("tcp: > > factor out tcp_build_frag()"). > > > > MPTCP was the only user of the tcp_build_frag helper, and after > > the previous patch MPTCP does not use the mentioned helper anymore. > > Let's avoid exposing TCP internals. > > > > The revert is partial, as tcp_remove_empty_skb(), exposed > > by the same commit is still required. > > > > I would simply remove the extern in include, and make this nice helper static ? > > This would avoid code churn, and keep a clean code. I thought you would have preferred otherwise. I'll make the helper static in the next iteration. Thanks! Paolo