From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Torgue Subject: Re: [PATCH 2/2] ARM: pinctrl: stm32: Optimizes and enhances stm32gpio irqchip Date: Wed, 21 Feb 2018 16:12:28 +0100 Message-ID: References: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Radoslaw Pietrzyk , Thomas Gleixner , Jason Cooper , Marc Zyngier , Maxime Coquelin , Linus Walleij , Benjamin Gaignard , Philipp Zabel , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org List-Id: linux-gpio@vger.kernel.org Maybe you could remove ARM from commit header. On 02/21/2018 02:50 PM, Radoslaw Pietrzyk wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index 617df16..5b1740d 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) > > static struct irq_chip stm32_gpio_irq_chip = { > .name = "stm32gpio", > - .irq_eoi = irq_chip_eoi_parent, > .irq_mask = irq_chip_mask_parent, > .irq_unmask = irq_chip_unmask_parent, > .irq_set_type = irq_chip_set_type_parent, > + .irq_set_wake = irq_chip_set_wake_parent, > .irq_request_resources = stm32_gpio_irq_request_resources, > .irq_release_resources = stm32_gpio_irq_release_resources, > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965995AbeBUPM5 (ORCPT ); Wed, 21 Feb 2018 10:12:57 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:39267 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933330AbeBUPMz (ORCPT ); Wed, 21 Feb 2018 10:12:55 -0500 Subject: Re: [PATCH 2/2] ARM: pinctrl: stm32: Optimizes and enhances stm32gpio irqchip To: Radoslaw Pietrzyk , Thomas Gleixner , Jason Cooper , Marc Zyngier , Maxime Coquelin , Linus Walleij , Benjamin Gaignard , Philipp Zabel , , , References: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> From: Alexandre Torgue Message-ID: Date: Wed, 21 Feb 2018 16:12:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG3NODE3.st.com (10.75.127.9) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-21_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe you could remove ARM from commit header. On 02/21/2018 02:50 PM, Radoslaw Pietrzyk wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index 617df16..5b1740d 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) > > static struct irq_chip stm32_gpio_irq_chip = { > .name = "stm32gpio", > - .irq_eoi = irq_chip_eoi_parent, > .irq_mask = irq_chip_mask_parent, > .irq_unmask = irq_chip_unmask_parent, > .irq_set_type = irq_chip_set_type_parent, > + .irq_set_wake = irq_chip_set_wake_parent, > .irq_request_resources = stm32_gpio_irq_request_resources, > .irq_release_resources = stm32_gpio_irq_release_resources, > }; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.torgue@st.com (Alexandre Torgue) Date: Wed, 21 Feb 2018 16:12:28 +0100 Subject: [PATCH 2/2] ARM: pinctrl: stm32: Optimizes and enhances stm32gpio irqchip In-Reply-To: <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> References: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Maybe you could remove ARM from commit header. On 02/21/2018 02:50 PM, Radoslaw Pietrzyk wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index 617df16..5b1740d 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) > > static struct irq_chip stm32_gpio_irq_chip = { > .name = "stm32gpio", > - .irq_eoi = irq_chip_eoi_parent, > .irq_mask = irq_chip_mask_parent, > .irq_unmask = irq_chip_unmask_parent, > .irq_set_type = irq_chip_set_type_parent, > + .irq_set_wake = irq_chip_set_wake_parent, > .irq_request_resources = stm32_gpio_irq_request_resources, > .irq_release_resources = stm32_gpio_irq_release_resources, > }; >