From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5334DC433F5 for ; Wed, 23 Mar 2022 10:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239753AbiCWKM7 (ORCPT ); Wed, 23 Mar 2022 06:12:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbiCWKM6 (ORCPT ); Wed, 23 Mar 2022 06:12:58 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A57BA76673 for ; Wed, 23 Mar 2022 03:11:28 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id q5so1124057ljb.11 for ; Wed, 23 Mar 2022 03:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jwgWA/X0RRXgl0WnFOwsjqRBGwN8mzbJny7zhdufmd0=; b=MCGBOFs+rKcllQq9+jpxTmw+Mrwt3rLzBEHOXYTOMpEInm/iW6w9gtrBCzXZTRHsmR 5JTSDsm0tSD8QyYINAWMwRGfq4pPbH9P9hGyzeGtxPyBnFGmqltotUK1NfHexgCZeTUg kfBv6ila4lDc9DlwXzBep5qIxkUh32iFChC3fdoyhJ3+9bYK+JLyowwWtScMAa8ugjlm SqFhlOZnVHKaEcTwijlDLYb9C2g8Qc0zKkkrh/gBlu5Q3kAwhu+lisUggcZZuhjPVB7m bXol6KaGDYVR0LVOtjevajppvklgynnZ6L3mj+ibzbnRDxQ+rmLrLVG7+Fev1t0nSHTS g8Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jwgWA/X0RRXgl0WnFOwsjqRBGwN8mzbJny7zhdufmd0=; b=4xnlQS8qKjnkL1DsiWz7RCMxGLV78UxXdWhV/+K1cSj9nlzyywRiD7uIO4cutzjHW5 a0pzYg3ojajLB8i7e4FZ/i2zSV3RcoiDrX5X87VpnHho2JAJ77ve/S1+kLeph8tiVeLd PKtWJfu8J1Z2vnWL/ew4SmaPNZqfQaapqNJyqLTakQGpmSIStw5tqsH8jpij8K8KMmF0 fGI/DWalQ0q81mwFQr4uLNCGleHdFTZQMrD432PyN4idcF4S7Op6q10xnCjRSwTPC3se 5zvRKn58zIERcmzb3UF+R0DfKWvTcguIHGtQwr3hEgcTOAuiqQD+ULSCr3z28DBL3aQz AKYA== X-Gm-Message-State: AOAM533Ik2NofXnP0kUhJ6YANgX6fJVKsAapXMq2f0jjtPkZlb3kX1jJ qs9iM8d/lK59H9KQeeLrUykAOdJhCA2llg== X-Google-Smtp-Source: ABdhPJw3/4BmsBQX6KSLouGF3oSZXX6Gpptahf03S0Ln5K4DaU6o4La74k5NDOpjqtmM3ZLH64m+sQ== X-Received: by 2002:a2e:914b:0:b0:249:24e7:cee8 with SMTP id q11-20020a2e914b000000b0024924e7cee8mr22015154ljg.143.1648030287023; Wed, 23 Mar 2022 03:11:27 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id m24-20020a194358000000b0044a3851f193sm641374lfj.83.2022.03.23.03.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:11:26 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:11:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes Content-Language: en-GB To: Ville Syrjala , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Rob Clark , Sean Paul , Abhinav Kumar , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-12-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: <20220218100403.7028-12-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 18/02/2022 13:03, Ville Syrjala wrote: > From: Ville Syrjälä > > Initialize on-stack modes with drm_mode_init() to guarantee > no stack garbage in the list head, or that we aren't copying > over another mode's list head. > > Based on the following cocci script, with manual fixups: > @decl@ > identifier M; > expression E; > @@ > - struct drm_display_mode M = E; > + struct drm_display_mode M; > > @@ > identifier decl.M; > expression decl.E; > statement S, S1; > @@ > struct drm_display_mode M; > ... when != S > + drm_mode_init(&M, &E); > + > S1 > > @@ > expression decl.E; > @@ > - &*E > + E > > Cc: Rob Clark > Cc: Sean Paul > Cc: Abhinav Kumar > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Ville Syrjälä Reviewed-by: Dmitry Baryshkov > --- -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 674CBC433F5 for ; Wed, 23 Mar 2022 10:11:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA7CD10E658; Wed, 23 Mar 2022 10:11:29 +0000 (UTC) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id D192910E663 for ; Wed, 23 Mar 2022 10:11:28 +0000 (UTC) Received: by mail-lj1-x235.google.com with SMTP id 17so1157580lji.1 for ; Wed, 23 Mar 2022 03:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jwgWA/X0RRXgl0WnFOwsjqRBGwN8mzbJny7zhdufmd0=; b=MCGBOFs+rKcllQq9+jpxTmw+Mrwt3rLzBEHOXYTOMpEInm/iW6w9gtrBCzXZTRHsmR 5JTSDsm0tSD8QyYINAWMwRGfq4pPbH9P9hGyzeGtxPyBnFGmqltotUK1NfHexgCZeTUg kfBv6ila4lDc9DlwXzBep5qIxkUh32iFChC3fdoyhJ3+9bYK+JLyowwWtScMAa8ugjlm SqFhlOZnVHKaEcTwijlDLYb9C2g8Qc0zKkkrh/gBlu5Q3kAwhu+lisUggcZZuhjPVB7m bXol6KaGDYVR0LVOtjevajppvklgynnZ6L3mj+ibzbnRDxQ+rmLrLVG7+Fev1t0nSHTS g8Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jwgWA/X0RRXgl0WnFOwsjqRBGwN8mzbJny7zhdufmd0=; b=NvUNZzXCkX8OW2KoaZ979uMBLb8DBTGn5mwuFifUh1kJAoUUTaMKBTx3LAWOqXZej3 9wr9PlsbldON2HK31rj5orh8GFoXni6NTXLYRJ4PX5TMXXWwr8sPJojx0zkhvBnvc1ho Z+Lv44isXVfXYjp7TQKAvBF6LwLC4o2Gq5TpsjiU00whO37msLBVM7HDbxc1h0NiEEgy z3m9yL0fWJUF/5XXSOFLKI8HcYQ+EX2BdzTQ0k5QxkvNTfEJYyyHJKJmvk+pTkgQEJO/ jJ7S1hnk7cw7qMaAYM8NdXm4oVNTK18DxpKN9o5b2QBi7/Z4v2QXQq9pcXFXiDtzuQr2 BW8Q== X-Gm-Message-State: AOAM533e/7/wv9km5y3FXqw5GvKgVJIF/uYFhhVqpOakQCt5zW5/zgt8 2BK4YlBJsI84hp3NafwmirNv2Q== X-Google-Smtp-Source: ABdhPJw3/4BmsBQX6KSLouGF3oSZXX6Gpptahf03S0Ln5K4DaU6o4La74k5NDOpjqtmM3ZLH64m+sQ== X-Received: by 2002:a2e:914b:0:b0:249:24e7:cee8 with SMTP id q11-20020a2e914b000000b0024924e7cee8mr22015154ljg.143.1648030287023; Wed, 23 Mar 2022 03:11:27 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id m24-20020a194358000000b0044a3851f193sm641374lfj.83.2022.03.23.03.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:11:26 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:11:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes Content-Language: en-GB To: Ville Syrjala , dri-devel@lists.freedesktop.org References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-12-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: <20220218100403.7028-12-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Abhinav Kumar , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 18/02/2022 13:03, Ville Syrjala wrote: > From: Ville Syrjälä > > Initialize on-stack modes with drm_mode_init() to guarantee > no stack garbage in the list head, or that we aren't copying > over another mode's list head. > > Based on the following cocci script, with manual fixups: > @decl@ > identifier M; > expression E; > @@ > - struct drm_display_mode M = E; > + struct drm_display_mode M; > > @@ > identifier decl.M; > expression decl.E; > statement S, S1; > @@ > struct drm_display_mode M; > ... when != S > + drm_mode_init(&M, &E); > + > S1 > > @@ > expression decl.E; > @@ > - &*E > + E > > Cc: Rob Clark > Cc: Sean Paul > Cc: Abhinav Kumar > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Ville Syrjälä Reviewed-by: Dmitry Baryshkov > --- -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1A5EC433FE for ; Wed, 23 Mar 2022 15:40:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B8DD10E73B; Wed, 23 Mar 2022 15:40:22 +0000 (UTC) Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0D7410E65C for ; Wed, 23 Mar 2022 10:11:28 +0000 (UTC) Received: by mail-lj1-x22e.google.com with SMTP id bn33so1144634ljb.6 for ; Wed, 23 Mar 2022 03:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=jwgWA/X0RRXgl0WnFOwsjqRBGwN8mzbJny7zhdufmd0=; b=MCGBOFs+rKcllQq9+jpxTmw+Mrwt3rLzBEHOXYTOMpEInm/iW6w9gtrBCzXZTRHsmR 5JTSDsm0tSD8QyYINAWMwRGfq4pPbH9P9hGyzeGtxPyBnFGmqltotUK1NfHexgCZeTUg kfBv6ila4lDc9DlwXzBep5qIxkUh32iFChC3fdoyhJ3+9bYK+JLyowwWtScMAa8ugjlm SqFhlOZnVHKaEcTwijlDLYb9C2g8Qc0zKkkrh/gBlu5Q3kAwhu+lisUggcZZuhjPVB7m bXol6KaGDYVR0LVOtjevajppvklgynnZ6L3mj+ibzbnRDxQ+rmLrLVG7+Fev1t0nSHTS g8Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=jwgWA/X0RRXgl0WnFOwsjqRBGwN8mzbJny7zhdufmd0=; b=7tybfvfw9SVgv/vkVtgZtUYt8K2OA6zdXLDgO5pESsCXD6hmRX2aF0bxCZdy3U70Kh VcQ2R3aZvZl2/8nXS6M8iAk8Ukc0DOh5wx6dYtHnKN5+Mt2vIQlDW1Q2hxSWVE2zBv9e /zo55cz4kFpN1RRwFhDrdheSEdGPiO2kHVfQyrsDjATSeIY0kvwoh7Zzd94+JIVjzUg9 kbBOaFGNxw+iAZOQ8zOn+NyyMg5oQklz4jkHA7ljgzzD9cZ35ou81Msjn9s5OwZpqy1v ZbzdGv5KSfxtCFCP/G0ttDDaq/ybJuNkqLO3bUriXI8tThbPwMbytO9bcAmxxtVk4Fa6 dBJw== X-Gm-Message-State: AOAM532Y+dDzn2PDGq9OFB8DRBhhD6S7/z8edf+JWbEB2F1+ZkNx+b2m MD4jJvkafva6CCOKkR25VdCLxQ== X-Google-Smtp-Source: ABdhPJw3/4BmsBQX6KSLouGF3oSZXX6Gpptahf03S0Ln5K4DaU6o4La74k5NDOpjqtmM3ZLH64m+sQ== X-Received: by 2002:a2e:914b:0:b0:249:24e7:cee8 with SMTP id q11-20020a2e914b000000b0024924e7cee8mr22015154ljg.143.1648030287023; Wed, 23 Mar 2022 03:11:27 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id m24-20020a194358000000b0044a3851f193sm641374lfj.83.2022.03.23.03.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Mar 2022 03:11:26 -0700 (PDT) Message-ID: Date: Wed, 23 Mar 2022 13:11:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-GB To: Ville Syrjala , dri-devel@lists.freedesktop.org References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-12-ville.syrjala@linux.intel.com> From: Dmitry Baryshkov In-Reply-To: <20220218100403.7028-12-ville.syrjala@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 23 Mar 2022 15:40:20 +0000 Subject: Re: [Intel-gfx] [PATCH 11/22] drm/msm: Use drm_mode_init() for on-stack modes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Abhinav Kumar , freedreno@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 18/02/2022 13:03, Ville Syrjala wrote: > From: Ville Syrjälä > > Initialize on-stack modes with drm_mode_init() to guarantee > no stack garbage in the list head, or that we aren't copying > over another mode's list head. > > Based on the following cocci script, with manual fixups: > @decl@ > identifier M; > expression E; > @@ > - struct drm_display_mode M = E; > + struct drm_display_mode M; > > @@ > identifier decl.M; > expression decl.E; > statement S, S1; > @@ > struct drm_display_mode M; > ... when != S > + drm_mode_init(&M, &E); > + > S1 > > @@ > expression decl.E; > @@ > - &*E > + E > > Cc: Rob Clark > Cc: Sean Paul > Cc: Abhinav Kumar > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Ville Syrjälä Reviewed-by: Dmitry Baryshkov > --- -- With best wishes Dmitry