From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44419)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bhSo9-00017L-7i
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:41:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bhSo5-0005zW-2q
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:41:48 -0400
Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:35296)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bhSo4-0005yj-RB
	for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:41:45 -0400
Received: by mail-pf0-x243.google.com with SMTP id n24so147766pfb.2
	for <qemu-devel@nongnu.org>; Tue, 06 Sep 2016 19:41:44 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1470929064-4092-1-git-send-email-alex.bennee@linaro.org>
	<1470929064-4092-9-git-send-email-alex.bennee@linaro.org>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <ef386cec-28cd-b136-6853-109ec256e87b@twiddle.net>
Date: Tue, 6 Sep 2016 19:41:42 -0700
MIME-Version: 1.0
In-Reply-To: <1470929064-4092-9-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC v4 08/28] translate-all: Add
 assert_(memory|tb)_lock annotations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com
Cc: peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>, jan.kiszka@siemens.com, mark.burton@greensocs.com, serge.fdrv@gmail.com, pbonzini@redhat.com

On 08/11/2016 08:24 AM, Alex Bennée wrote:
> This adds calls to the assert_(memory|tb)_lock for all public APIs which
> are documented as needing them held for linux-user mode. The asserts are
> NOPs for system-mode although these will be converted when MTTCG is
> enabled.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Richard Henderson <rth@twiddle.net>

> @@ -1111,7 +1121,7 @@ static void build_page_bitmap(PageDesc *p)
>              tb_end = tb_start + tb->size;
>              if (tb_end > TARGET_PAGE_SIZE) {
>                  tb_end = TARGET_PAGE_SIZE;
> -            }
> +             }
>          } else {

Introducing a whitespace error?


r~