From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D42C49ED9 for ; Thu, 12 Sep 2019 07:47:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90DBF208C2 for ; Thu, 12 Sep 2019 07:47:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727329AbfILHrr (ORCPT ); Thu, 12 Sep 2019 03:47:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31931 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725765AbfILHrr (ORCPT ); Thu, 12 Sep 2019 03:47:47 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13227A37192; Thu, 12 Sep 2019 07:47:46 +0000 (UTC) Received: from [10.36.117.168] (ovpn-117-168.ams2.redhat.com [10.36.117.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id B34755D704; Thu, 12 Sep 2019 07:47:31 +0000 (UTC) Subject: Re: [PATCH v9 0/8] stg mail -e --version=v9 \ To: Michal Hocko Cc: "Michael S. Tsirkin" , Alexander Duyck , Alexander Duyck , virtio-dev@lists.oasis-open.org, kvm list , Catalin Marinas , Dave Hansen , LKML , Matthew Wilcox , linux-mm , Andrew Morton , will@kernel.org, linux-arm-kernel@lists.infradead.org, Oscar Salvador , Yang Zhang , Pankaj Gupta , Konrad Rzeszutek Wilk , Nitesh Narayan Lal , Rik van Riel , lcapitulino@redhat.com, "Wang, Wei W" , Andrea Arcangeli , ying.huang@intel.com, Paolo Bonzini , Dan Williams , Fengguang Wu , "Kirill A. Shutemov" References: <20190911113619.GP4023@dhcp22.suse.cz> <20190911080804-mutt-send-email-mst@kernel.org> <20190911121941.GU4023@dhcp22.suse.cz> <20190911122526.GV4023@dhcp22.suse.cz> <4748a572-57b3-31da-0dde-30138e550c3a@redhat.com> <20190911125413.GY4023@dhcp22.suse.cz> <736594d6-b9ae-ddb9-2b96-85648728ef33@redhat.com> <20190911132002.GA4023@dhcp22.suse.cz> <20190911135100.GC4023@dhcp22.suse.cz> <20190912071633.GL4023@dhcp22.suse.cz> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Thu, 12 Sep 2019 09:47:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190912071633.GL4023@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 12 Sep 2019 07:47:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.09.19 09:16, Michal Hocko wrote: > On Wed 11-09-19 18:09:18, David Hildenbrand wrote: >> On 11.09.19 15:51, Michal Hocko wrote: >>> On Wed 11-09-19 15:20:02, Michal Hocko wrote: >>> [...] >>>>> 4. Continuously report, not the "one time report everything" approach. >>>> >>>> So you mean the allocator reporting this rather than an external code to >>>> poll right? I do not know, how much this is nice to have than must have? >>> >>> Another idea that I haven't really thought through so it might turned >>> out to be completely bogus but let's try anyway. Your "report everything" >>> just made me look and realize that free_pages_prepare already performs >>> stuff that actually does something similar yet unrelated. >>> >>> We do report to special page poisoning, zeroying or >>> CONFIG_DEBUG_PAGEALLOC to unmap the address from the kernel address >>> space. This sounds like something fitting your model no? >>> >> >> AFAIKS, the poisoning/unmapping is done whenever a page is freed. I >> don't quite see yet how that would help to remember if a page was >> already reported. > > Do you still have to differ that state when each page is reported? Ah, very good point. I can see that the reason for this was not discussed in this thread so far. (Alexander, Nitesh, please correct me if I am wrong). It's buried in the long history of free page hinting/reporting. Some early patch sets tried to report during every free synchronously. Free a page, report them to the hypervisor. This resulted in some issues (especially, locking-related and the virtio + the hypervisor being involved, resulting in unpredictable delays, quite some overhead ...). It was no good. One design decision then was to not report single pages, but a bunch of pages at once. This made it necessary to "remember" the pages to be reported and to temporarily block them from getting allocated while reporting. Nitesh implemented (at least) two "capture PFNs of free pages in an array when freeing" approaches. One being synchronous from the freeing CPU once the list was full (having similar issues as plain synchronous reporting) and one being asynchronous by a separate thread (which solved many locking issues). Turned out the a simple array can quickly lead to us having to drop "reports" to the hypervisor because the array is full and the reporting thread was not able to keep up. Not good as well. Especially, if some process frees a lot of memory this can happen quickly and Nitesh wa sable to trigger this scenario frequently. Finally, Nitesh decided to use the bitmap instead to keep track of pages to report. I'd like to note that this approach could still be combined with an "array of potentially free PFNs". Only when the array/circular buffer runs out of entries ("reporting thread cannot keep up"), we would have to go back to scanning the bitmap. That was also the point where Alexander decided to look into integrating tracking/handling reported/unreported pages directly in the buddy. > >> After reporting the page we would have to switch some >> state (Nitesh: bitmap bit, Alexander: page flag) to identify that. > > Yes, you can either store the state somewhere. > >> Of course, we could map the page and treat that as "the state" when we >> reported it, but I am not sure that's such a good idea :) >> >> As always, I might be very wrong ... > > I still do not fully understand the usecase so I might be equally wrong. > My thinking is along these lines. Why should you scan free pages when > you can effectively capture each freed page? If you go one step further > then post_alloc_hook would be the counterpart to know that your page has > been allocated. I'd like to note that Nitesh's patch set contains the following hunk, which is roughly what you were thinking :) -static inline void __free_one_page(struct page *page, +inline void __free_one_page(struct page *page, unsigned long pfn, struct zone *zone, unsigned int order, - int migratetype) + int migratetype, bool hint) { unsigned long combined_pfn; unsigned long uninitialized_var(buddy_pfn); @@ -980,7 +981,8 @@ static inline void __free_one_page(struct page *page, migratetype); else add_to_free_area(page, &zone->free_area[order], migratetype); - + if (hint) + page_hinting_enqueue(page, order); } (ignore the hint parameter, when he would switch to a isolate vs. alloc/free, that can go away and all we left is the enqueue part) Inside that callback we can remember the pages any way we want. Right now in a bitmap. Maybe later in a array + bitmap (as discussed above). Another idea I had was to simply go over all pages and report them when running into this "array full" condition. But I am not yet sure about the performance implications on rather large machines. So the bitmap idea might have some other limitations but seems to do its job. Hoe that makes things clearer and am not missing something. -- Thanks, David / dhildenb From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2691C49ED9 for ; Thu, 12 Sep 2019 07:47:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E8E8208C2 for ; Thu, 12 Sep 2019 07:47:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C+gD2sWE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E8E8208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KaqsCqUWNsUbKysVvJ14phRLgoALEWuwBDl/j2f2UFg=; b=C+gD2sWE47R7i6 c732gI7GQ7OjdGI0SQz+wKvnoIXPmAQPiklS6mTABxoyLC/YSYr0yQA7PRJBhuA6kJ49rqgs7ku0o B96+CeNLGptmwZfvEO0BBuXnr/oS8SRAPhSUyq/+dYSqGfOHQ8LFKC9gk8cBdCWyeDOBu8b02GFGc 5rbiadofBZP0iuLjcc+/uOQwqyaODa2Y772BnxY8lxCfU3wGf+kn66qu1RVvWnsDWBiaz56oiw5uP oGrTnsYLt/bqZU3qd0DONngUClxFZlrkFBMosn/Tp8KzFTDZ31gQ1wXy778eDooKYabsJEfk0GDCL 32Dt1Sbg/H9xON2V2Sqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8JpX-000501-2G; Thu, 12 Sep 2019 07:47:51 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i8JpT-0004zB-D5 for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2019 07:47:49 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13227A37192; Thu, 12 Sep 2019 07:47:46 +0000 (UTC) Received: from [10.36.117.168] (ovpn-117-168.ams2.redhat.com [10.36.117.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id B34755D704; Thu, 12 Sep 2019 07:47:31 +0000 (UTC) Subject: Re: [PATCH v9 0/8] stg mail -e --version=v9 \ To: Michal Hocko References: <20190911113619.GP4023@dhcp22.suse.cz> <20190911080804-mutt-send-email-mst@kernel.org> <20190911121941.GU4023@dhcp22.suse.cz> <20190911122526.GV4023@dhcp22.suse.cz> <4748a572-57b3-31da-0dde-30138e550c3a@redhat.com> <20190911125413.GY4023@dhcp22.suse.cz> <736594d6-b9ae-ddb9-2b96-85648728ef33@redhat.com> <20190911132002.GA4023@dhcp22.suse.cz> <20190911135100.GC4023@dhcp22.suse.cz> <20190912071633.GL4023@dhcp22.suse.cz> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: Date: Thu, 12 Sep 2019 09:47:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190912071633.GL4023@dhcp22.suse.cz> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 12 Sep 2019 07:47:46 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190912_004747_474138_EC58B8D4 X-CRM114-Status: GOOD ( 28.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yang Zhang , Pankaj Gupta , kvm list , "Michael S. Tsirkin" , Catalin Marinas , Alexander Duyck , lcapitulino@redhat.com, linux-mm , Alexander Duyck , will@kernel.org, Andrea Arcangeli , virtio-dev@lists.oasis-open.org, Rik van Riel , Matthew Wilcox , "Wang, Wei W" , ying.huang@intel.com, Konrad Rzeszutek Wilk , Dan Williams , linux-arm-kernel@lists.infradead.org, Oscar Salvador , Nitesh Narayan Lal , Dave Hansen , LKML , Paolo Bonzini , Andrew Morton , Fengguang Wu , "Kirill A. Shutemov" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12.09.19 09:16, Michal Hocko wrote: > On Wed 11-09-19 18:09:18, David Hildenbrand wrote: >> On 11.09.19 15:51, Michal Hocko wrote: >>> On Wed 11-09-19 15:20:02, Michal Hocko wrote: >>> [...] >>>>> 4. Continuously report, not the "one time report everything" approach. >>>> >>>> So you mean the allocator reporting this rather than an external code to >>>> poll right? I do not know, how much this is nice to have than must have? >>> >>> Another idea that I haven't really thought through so it might turned >>> out to be completely bogus but let's try anyway. Your "report everything" >>> just made me look and realize that free_pages_prepare already performs >>> stuff that actually does something similar yet unrelated. >>> >>> We do report to special page poisoning, zeroying or >>> CONFIG_DEBUG_PAGEALLOC to unmap the address from the kernel address >>> space. This sounds like something fitting your model no? >>> >> >> AFAIKS, the poisoning/unmapping is done whenever a page is freed. I >> don't quite see yet how that would help to remember if a page was >> already reported. > > Do you still have to differ that state when each page is reported? Ah, very good point. I can see that the reason for this was not discussed in this thread so far. (Alexander, Nitesh, please correct me if I am wrong). It's buried in the long history of free page hinting/reporting. Some early patch sets tried to report during every free synchronously. Free a page, report them to the hypervisor. This resulted in some issues (especially, locking-related and the virtio + the hypervisor being involved, resulting in unpredictable delays, quite some overhead ...). It was no good. One design decision then was to not report single pages, but a bunch of pages at once. This made it necessary to "remember" the pages to be reported and to temporarily block them from getting allocated while reporting. Nitesh implemented (at least) two "capture PFNs of free pages in an array when freeing" approaches. One being synchronous from the freeing CPU once the list was full (having similar issues as plain synchronous reporting) and one being asynchronous by a separate thread (which solved many locking issues). Turned out the a simple array can quickly lead to us having to drop "reports" to the hypervisor because the array is full and the reporting thread was not able to keep up. Not good as well. Especially, if some process frees a lot of memory this can happen quickly and Nitesh wa sable to trigger this scenario frequently. Finally, Nitesh decided to use the bitmap instead to keep track of pages to report. I'd like to note that this approach could still be combined with an "array of potentially free PFNs". Only when the array/circular buffer runs out of entries ("reporting thread cannot keep up"), we would have to go back to scanning the bitmap. That was also the point where Alexander decided to look into integrating tracking/handling reported/unreported pages directly in the buddy. > >> After reporting the page we would have to switch some >> state (Nitesh: bitmap bit, Alexander: page flag) to identify that. > > Yes, you can either store the state somewhere. > >> Of course, we could map the page and treat that as "the state" when we >> reported it, but I am not sure that's such a good idea :) >> >> As always, I might be very wrong ... > > I still do not fully understand the usecase so I might be equally wrong. > My thinking is along these lines. Why should you scan free pages when > you can effectively capture each freed page? If you go one step further > then post_alloc_hook would be the counterpart to know that your page has > been allocated. I'd like to note that Nitesh's patch set contains the following hunk, which is roughly what you were thinking :) -static inline void __free_one_page(struct page *page, +inline void __free_one_page(struct page *page, unsigned long pfn, struct zone *zone, unsigned int order, - int migratetype) + int migratetype, bool hint) { unsigned long combined_pfn; unsigned long uninitialized_var(buddy_pfn); @@ -980,7 +981,8 @@ static inline void __free_one_page(struct page *page, migratetype); else add_to_free_area(page, &zone->free_area[order], migratetype); - + if (hint) + page_hinting_enqueue(page, order); } (ignore the hint parameter, when he would switch to a isolate vs. alloc/free, that can go away and all we left is the enqueue part) Inside that callback we can remember the pages any way we want. Right now in a bitmap. Maybe later in a array + bitmap (as discussed above). Another idea I had was to simply go over all pages and report them when running into this "array full" condition. But I am not yet sure about the performance implications on rather large machines. So the bitmap idea might have some other limitations but seems to do its job. Hoe that makes things clearer and am not missing something. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-6124-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 82980985D2F for ; Thu, 12 Sep 2019 07:47:47 +0000 (UTC) References: <20190911113619.GP4023@dhcp22.suse.cz> <20190911080804-mutt-send-email-mst@kernel.org> <20190911121941.GU4023@dhcp22.suse.cz> <20190911122526.GV4023@dhcp22.suse.cz> <4748a572-57b3-31da-0dde-30138e550c3a@redhat.com> <20190911125413.GY4023@dhcp22.suse.cz> <736594d6-b9ae-ddb9-2b96-85648728ef33@redhat.com> <20190911132002.GA4023@dhcp22.suse.cz> <20190911135100.GC4023@dhcp22.suse.cz> <20190912071633.GL4023@dhcp22.suse.cz> From: David Hildenbrand Message-ID: Date: Thu, 12 Sep 2019 09:47:30 +0200 MIME-Version: 1.0 In-Reply-To: <20190912071633.GL4023@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: [virtio-dev] Re: [PATCH v9 0/8] stg mail -e --version=v9 \ To: Michal Hocko Cc: "Michael S. Tsirkin" , Alexander Duyck , Alexander Duyck , virtio-dev@lists.oasis-open.org, kvm list , Catalin Marinas , Dave Hansen , LKML , Matthew Wilcox , linux-mm , Andrew Morton , will@kernel.org, linux-arm-kernel@lists.infradead.org, Oscar Salvador , Yang Zhang , Pankaj Gupta , Konrad Rzeszutek Wilk , Nitesh Narayan Lal , Rik van Riel , lcapitulino@redhat.com, "Wang, Wei W" , Andrea Arcangeli , ying.huang@intel.com, Paolo Bonzini , Dan Williams , Fengguang Wu , "Kirill A. Shutemov" List-ID: On 12.09.19 09:16, Michal Hocko wrote: > On Wed 11-09-19 18:09:18, David Hildenbrand wrote: >> On 11.09.19 15:51, Michal Hocko wrote: >>> On Wed 11-09-19 15:20:02, Michal Hocko wrote: >>> [...] >>>>> 4. Continuously report, not the "one time report everything" approach. >>>> >>>> So you mean the allocator reporting this rather than an external code to >>>> poll right? I do not know, how much this is nice to have than must have? >>> >>> Another idea that I haven't really thought through so it might turned >>> out to be completely bogus but let's try anyway. Your "report everything" >>> just made me look and realize that free_pages_prepare already performs >>> stuff that actually does something similar yet unrelated. >>> >>> We do report to special page poisoning, zeroying or >>> CONFIG_DEBUG_PAGEALLOC to unmap the address from the kernel address >>> space. This sounds like something fitting your model no? >>> >> >> AFAIKS, the poisoning/unmapping is done whenever a page is freed. I >> don't quite see yet how that would help to remember if a page was >> already reported. > > Do you still have to differ that state when each page is reported? Ah, very good point. I can see that the reason for this was not discussed in this thread so far. (Alexander, Nitesh, please correct me if I am wrong). It's buried in the long history of free page hinting/reporting. Some early patch sets tried to report during every free synchronously. Free a page, report them to the hypervisor. This resulted in some issues (especially, locking-related and the virtio + the hypervisor being involved, resulting in unpredictable delays, quite some overhead ...). It was no good. One design decision then was to not report single pages, but a bunch of pages at once. This made it necessary to "remember" the pages to be reported and to temporarily block them from getting allocated while reporting. Nitesh implemented (at least) two "capture PFNs of free pages in an array when freeing" approaches. One being synchronous from the freeing CPU once the list was full (having similar issues as plain synchronous reporting) and one being asynchronous by a separate thread (which solved many locking issues). Turned out the a simple array can quickly lead to us having to drop "reports" to the hypervisor because the array is full and the reporting thread was not able to keep up. Not good as well. Especially, if some process frees a lot of memory this can happen quickly and Nitesh wa sable to trigger this scenario frequently. Finally, Nitesh decided to use the bitmap instead to keep track of pages to report. I'd like to note that this approach could still be combined with an "array of potentially free PFNs". Only when the array/circular buffer runs out of entries ("reporting thread cannot keep up"), we would have to go back to scanning the bitmap. That was also the point where Alexander decided to look into integrating tracking/handling reported/unreported pages directly in the buddy. > >> After reporting the page we would have to switch some >> state (Nitesh: bitmap bit, Alexander: page flag) to identify that. > > Yes, you can either store the state somewhere. > >> Of course, we could map the page and treat that as "the state" when we >> reported it, but I am not sure that's such a good idea :) >> >> As always, I might be very wrong ... > > I still do not fully understand the usecase so I might be equally wrong. > My thinking is along these lines. Why should you scan free pages when > you can effectively capture each freed page? If you go one step further > then post_alloc_hook would be the counterpart to know that your page has > been allocated. I'd like to note that Nitesh's patch set contains the following hunk, which is roughly what you were thinking :) -static inline void __free_one_page(struct page *page, +inline void __free_one_page(struct page *page, unsigned long pfn, struct zone *zone, unsigned int order, - int migratetype) + int migratetype, bool hint) { unsigned long combined_pfn; unsigned long uninitialized_var(buddy_pfn); @@ -980,7 +981,8 @@ static inline void __free_one_page(struct page *page, migratetype); else add_to_free_area(page, &zone->free_area[order], migratetype); - + if (hint) + page_hinting_enqueue(page, order); } (ignore the hint parameter, when he would switch to a isolate vs. alloc/free, that can go away and all we left is the enqueue part) Inside that callback we can remember the pages any way we want. Right now in a bitmap. Maybe later in a array + bitmap (as discussed above). Another idea I had was to simply go over all pages and report them when running into this "array full" condition. But I am not yet sure about the performance implications on rather large machines. So the bitmap idea might have some other limitations but seems to do its job. Hoe that makes things clearer and am not missing something. -- Thanks, David / dhildenb --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org