Re: [Resend][PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes

From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
	Praveen Kumar <kpraveen.lkml@gmail.com>,
	xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
	tim@xen.org, jbeulich@suse.com
Subject: Re: [Resend][PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes
Date: Wed, 31 May 2017 23:56:42 +0100	[thread overview]
Message-ID: <ef47b8d3-021e-8105-2dae-0fbd4d53aae6@citrix.com> (raw)
In-Reply-To: <1496270454.6267.5.camel@citrix.com>

On 31/05/2017 23:40, Dario Faggioli wrote:
> On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote:
>> First, move some code around in order to make the next change more
>> obvious.
>>
>> commit 16c047add3ceaf0ab882e3e094d1ec904d02312d from linux tree
>>
>> Signed-off-by: Praveen Kumar <kpraveen.lkml@gmail.com>
>>
> Mmm... actually, I am not absolutely sure of what's the formal process
> that we follow in this case is, but I think that:
> *) it is legally required (or at least preferable) that, at least the 
>    Signed-off-by, of the original authors of the patches are reported 
>    here;
> *) legally required or not, I think it's very useful to have them, and 
>    not only the S-o-b, but also the Acks, and all the other tags (like 
>    you had in the first posting of this series). You probably should 
>    add your own Signed-off-by, at the bottom of the list (this, you 
>    didn't do it in first posting of the series)
>
> I appreciate that you probably removed the tags to prevent git-send-
> email to use the enclosed email address and spam everyone, but I'm sure
> there is a way of telling git-send-email itself, to avoid doing that,
> even if you leave the tags and the emails in the patches' changelogs
> (something like a command line options, or similar.. I don't use it, so
> I can't tell).

As an example, see

http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=b01c2fb5834aea0328db55c310caa34173021d3d

The way I prepare series like this for email is to use `git format-patch
staging --cover-letter` to render the entire series as patch files in
the local directory,  edit each patch to put suitable Cc: lines beside
the From: header, then `git send-email --dry-run *.patch
--suppress-cc=all` to check what it will actually send.  The Cc's in the
header section are included, but no automatic Cc's are generated from
content in the body.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel