From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH 4/5] scsi: bnx2fc: annoate unlock + release for sparse Date: Fri, 5 May 2017 12:34:30 +0200 Message-ID: References: <20170410171254.30367-1-bigeasy@linutronix.de> <20170410171254.30367-5-bigeasy@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:35786 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbdEEKed (ORCPT ); Fri, 5 May 2017 06:34:33 -0400 Received: by mail-wm0-f66.google.com with SMTP id b10so480819wmh.2 for ; Fri, 05 May 2017 03:34:32 -0700 (PDT) In-Reply-To: <20170410171254.30367-5-bigeasy@linutronix.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Sebastian Andrzej Siewior , "Martin K . Petersen" , "James E.J. Bottomley" , linux-scsi@vger.kernel.org Cc: rt@linutronix.de, Lee Duncan , Chris Leech , Chad Dupuis , QLogic-Storage-Upstream@qlogic.com, Christoph Hellwig , Andrew Morton On 04/10/2017 07:12 PM, Sebastian Andrzej Siewior wrote: > The caller of bnx2fc_abts_cleanup() holds the tgt->tgt_lock lock and it > is expected to release the lock during wait_for_completion() and acquire > the lock afterwards. > > This patch was only compile-tested due to -ENODEV. > > Cc: QLogic-Storage-Upstream@qlogic.com > Cc: Christoph Hellwig > Signed-off-by: Sebastian Andrzej Siewior > --- Reviewed-by: Johannes Thumshirn