From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1754C433EF for ; Mon, 7 Feb 2022 17:42:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.267325.461055 (Exim 4.92) (envelope-from ) id 1nH81R-0006Z1-Ol; Mon, 07 Feb 2022 17:41:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 267325.461055; Mon, 07 Feb 2022 17:41:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nH81R-0006Yu-Li; Mon, 07 Feb 2022 17:41:53 +0000 Received: by outflank-mailman (input) for mailman id 267325; Mon, 07 Feb 2022 17:41:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nH81R-0006Yo-87 for xen-devel@lists.xenproject.org; Mon, 07 Feb 2022 17:41:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nH81L-0000h4-TF; Mon, 07 Feb 2022 17:41:47 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.85.34.134]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nH81L-0006Nh-M9; Mon, 07 Feb 2022 17:41:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=7ut4eDQhFUpXJ39YNWdkNKE95R/eFzuGjwWnxKStmNA=; b=OxP7Y2zDmXz2GjWXhHxDI7tooF +STC7ivxfPa92cjRcQCJmScygEyR1fNZ7HeOXR5qeFSM38OvxOep9oOkYCcfl/Zr0By6Yk6aC3t+V ahuELoLhzlr12ftx1RwW9dM6UiRYG0xfwKHA0REptXdyjUMwNo9mRpgjmYNarlf/op+I=; Message-ID: Date: Mon, 7 Feb 2022 17:41:44 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH V5] xen/gnttab: Store frame GFN in struct page_info on Arm To: Oleksandr , Jan Beulich Cc: Oleksandr Tyshchenko , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bob Eshleman , Alistair Francis , Connor Davis , xen-devel@lists.xenproject.org References: <1641424268-12968-1-git-send-email-olekstysh@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sorry for the late reply. On 06/01/2022 16:30, Oleksandr wrote: So I agree with Jan that the name should be adjusted if it stays where it is. That said, I would actually prefer the adjustment in alloc_heap_pages(). It is one less assignment per page and I don't expect any issue with setting the bits to INVALID_GFN everywhere in the future on Arm. Note that you would also need to update acquire_staticmem_pages(). Cheers, -- Julien Grall