All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li GuiFu via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Gao Xiang <hsiangkao@aol.com>,
	linux-erofs@lists.ozlabs.org, Li Guifu <bluce.liguifu@huawei.com>
Subject: Re: [PATCH] erofs-utils: avoid using old compatibility type uint
Date: Fri, 27 Mar 2020 00:19:18 +0800	[thread overview]
Message-ID: <ef5f4cde-f26c-e399-5371-ab87a4d55111@aliyun.com> (raw)
In-Reply-To: <20200324081949.26355-1-hsiangkao@aol.com>



On 2020/3/24 16:19, Gao Xiang wrote:
> This should fix the following buildroot autobuild issues
> with some configration on ARM platform [1]:
> 
> compress.c: In function 'vle_compress_one':
> compress.c:209:10: error: unknown type name 'uint'
>     const uint qh_aligned = round_down(ctx->head, EROFS_BLKSIZ);
>           ^~~~
> compress.c:210:10: error: unknown type name 'uint'
>     const uint qh_after = ctx->head - qh_aligned;
>           ^~~~
> compress.c: In function 'z_erofs_convert_to_compacted_format':
> compress.c:313:8: error: unknown type name 'uint'
>   const uint headerpos = Z_EROFS_VLE_EXTENT_ALIGN(inode->inode_isize +
>         ^~~~
> compress.c:316:8: error: unknown type name 'uint'
>   const uint totalidx = (legacymetasize -
>         ^~~~
> 
> [1] http://autobuild.buildroot.net/results/842a3c6416416d7badf4db9f38e3b231093a786a
> Signed-off-by: Gao Xiang <hsiangkao@aol.com>

It looks good
Reviewed-by: Li Guifu <bluce.lee@aliyun.com>
Thanks

  reply	other threads:[~2020-03-26 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200324081949.26355-1-hsiangkao.ref@aol.com>
2020-03-24  8:19 ` [PATCH] erofs-utils: avoid using old compatibility type uint Gao Xiang via Linux-erofs
2020-03-26 16:19   ` Li GuiFu via Linux-erofs [this message]
2020-03-27  7:41   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef5f4cde-f26c-e399-5371-ab87a4d55111@aliyun.com \
    --to=linux-erofs@lists.ozlabs.org \
    --cc=bluce.lee@aliyun.com \
    --cc=bluce.liguifu@huawei.com \
    --cc=hsiangkao@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.