From: Jacob Keller <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 6/9] ice: enable initial devlink support
Date: Wed, 11 Mar 2020 18:34:38 -0700 [thread overview]
Message-ID: <ef5f5cb1-fecf-52ec-4814-79bb0ca09ce0@intel.com> (raw)
In-Reply-To: <20200312012726.973301-7-jacob.e.keller@intel.com>
Ugh sorry for the thrash, Jeff, please do not apply this to IWL yet,
looks like I need a v3.
On 3/11/2020 6:27 PM, Jacob Keller wrote:
> +/**
> + * ice_devlink_create_port - Create a devlink port for this PF
> + * @pf: the PF to create a port for
> + *
> + * Create and register a devlink_port for this PF. Note that although each
> + * physical function is connected to a separate devlink instance, the port
> + * will still be numbered according to the physical function id.
> + *
> + * Return: zero on success or an error code on failure.
> + */
> +int ice_devlink_create_port(struct ice_pf *pf)
> +{
> + struct devlink *devlink = priv_to_devlink(pf);
> + struct ice_vsi *vsi = ice_get_main_vsi(pf);
> + struct device *dev = ice_pf_to_dev(pf);
> + int err;
> +
> + if (!vsi) {
> + dev_err(dev, "%s: unable to find main VSI\n", __func__);
> + return -EIO;
> + }
> +
> + devlink_port_attrs_set(&pf->devlink_port, DEVLINK_PORT_FLAVOUR_PHYSICAL,
> + pf->hw.pf_id, false, 0, NULL, 0);
> + err = devlink_port_register(devlink, &pf->devlink_port, pf->hw.pf_id);
> + if (err) {
> + dev_err(dev, "devlink_port_register failed: %d\n", err);
> + return err;
> + }
> +
> + return 0;
> +}
<snip>
> #define DRV_VERSION_MAJOR 0
> #define DRV_VERSION_MINOR 8
> @@ -2426,6 +2427,8 @@ static int ice_cfg_netdev(struct ice_vsi *vsi)
> if (err)
> return err;
>
> + devlink_port_type_eth_set(&pf->devlink_port, vsi->netdev);
> +
Ugh. I just noticed this when I went to reboot my test system,
apparently this is called before ice_devlink_create_port and generates a
warning:
> [ 186.682927] ------------[ cut here ]------------
> [ 186.682934] WARNING: CPU: 28 PID: 731 at net/core/devlink.c:6936 __devlink_port_type_set+0x60/0x70
> [ 186.682934] Modules linked in: ice(+) ip6t_REJECT nf_reject_ipv6 ip6t_rpfilter ipt_REJECT nf_reject_ipv4 xt_conntrack ebtable_nat ebtable_broute ip6table_nat ip6table_mangle ip6table_raw ip6table_security iptable_nat nf_nat iptable_ma
> ngle iptable_raw iptable_security nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nfnetlink ebtable_filter ebtables ip6table_filter ip6_tables iptable_filter sunrpc vfat fat intel_rapl_msr intel_rapl_common isst_if_common skx_edac nfit
> libnvdimm x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel iTCO_wdt iTCO_vendor_support intel_cstate qat_c62x ipmi_ssif intel_qat intel_uncore mei_me mei intel_rapl
> _perf ioatdma joydev authenc pcspkr i2c_i801 lpc_ich ipmi_si dca ipmi_devintf ipmi_msghandler acpi_power_meter acpi_pad ip_tables xfs libcrc32c ast i2c_algo_bit drm_vram_helper drm_ttm_helper ttm drm_kms_helper cec drm i40e crc32c_intel
> virtual_bus wmi pkcs8_key_parser [last unloaded: ice]
> [ 186.682962] CPU: 28 PID: 731 Comm: kworker/28:1 Tainted: G W 5.6.0-rc3+ #3
> [ 186.682963] Hardware name: Intel Corporation S2600STQ/S2600STQ, BIOS SE5C620.86B.02.01.0010.010620200716 01/06/2020
> [ 186.682969] Workqueue: events work_for_cpu_fn
> [ 186.682971] RIP: 0010:__devlink_port_type_set+0x60/0x70
> [ 186.682972] Code: 89 e7 e8 33 52 16 00 44 89 6d 34 4c 89 e7 48 89 5d 40 e8 93 52 16 00 48 89 ef 5b be 07 00 00 00 5d 41 5c 41 5d e9 90 fc ff ff <0f> 0b c3 66 66 2e 0f 1f 84 00 00 00 00 00 66 90 0f 1f 44 00 00 41
> [ 186.682973] RSP: 0018:ffffa14c60567d70 EFLAGS: 00010246
> [ 186.682974] RAX: 0000000000000000 RBX: ffffffffc05b86c0 RCX: 0000000000000000
> [ 186.682974] RDX: ffff8bdffb72b000 RSI: 0000000000000002 RDI: ffff8bdff7568128
> [ 186.682975] RBP: ffff8bdff7568128 R08: ffffffffb77f9820 R09: ffffa14c60567c68
> [ 186.682975] R10: ffff8bdfa9d22a18 R11: ffff8bdfff16af38 R12: ffff8bdffb72b000
> [ 186.682975] R13: ffff8bdff7568120 R14: ffff8bdff7568280 R15: 0000000000000000
> [ 186.682976] FS: 0000000000000000(0000) GS:ffff8bdfff000000(0000) knlGS:0000000000000000
> [ 186.682977] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 186.682977] CR2: 0000556b79c52c58 CR3: 0000000e5760a004 CR4: 00000000007606e0
> [ 186.682978] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> [ 186.682978] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> [ 186.682979] PKRU: 55555554
> [ 186.682979] Call Trace:
> [ 186.682983] devlink_port_type_eth_set+0x7b/0xb0
> [ 186.682993] ice_probe+0x7dc/0xda0 [ice]
> [ 186.682998] local_pci_probe+0x42/0x80
> [ 186.683002] ? __schedule+0x2cf/0x740
> [ 186.683003] work_for_cpu_fn+0x16/0x20
> [ 186.683006] process_one_work+0x1b5/0x360
> [ 186.683007] worker_thread+0x1e2/0x3c0
> [ 186.683010] kthread+0xf9/0x130
> [ 186.683012] ? process_one_work+0x360/0x360
> [ 186.683013] ? kthread_park+0x90/0x90
> [ 186.683014] ret_from_fork+0x35/0x40
> [ 186.683016] ---[ end trace 5fff949e65047c29 ]---
I'm fairly sure this is because we do not call ice_devlink_create_port
early enough, but I need to figure out the best place to put this :(
Regards,
Jake
next prev parent reply other threads:[~2020-03-12 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 1:27 [Intel-wired-lan] [PATCH v2 0/9] ice devlink support Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 1/9] ice: use __le16 types for explicitly Little Endian values Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 2/9] ice: create function to read a section of the NVM and Shadow RAM Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 3/9] ice: store NVM version info in extracted format Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 4/9] ice: discover and store size of available flash Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 5/9] ice: implement full NVM read from ETHTOOL_GEEPROM Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 6/9] ice: enable initial devlink support Jacob Keller
2020-03-12 1:34 ` Jacob Keller [this message]
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 7/9] devlink: promote "fw.bundle_id" to a generic info version Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 8/9] ice: add basic handler for devlink .info_get Jacob Keller
2020-03-12 1:27 ` [Intel-wired-lan] [PATCH v2 9/9] ice: add board identifier info to " Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef5f5cb1-fecf-52ec-4814-79bb0ca09ce0@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.