From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tan, Jianfeng" Subject: Re: [PATCH v2 2/5] net/virtio: add interrupt configure for vdev Date: Wed, 29 Mar 2017 15:03:16 +0800 Message-ID: References: <1488563803-87754-1-git-send-email-jianfeng.tan@intel.com> <1490689316-131625-1-git-send-email-jianfeng.tan@intel.com> <1490689316-131625-3-git-send-email-jianfeng.tan@intel.com> <20170329062706.GD18844@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, david.marchand@6wind.com, maxime.coquelin@redhat.com To: Yuanhan Liu Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 371F31396 for ; Wed, 29 Mar 2017 09:03:32 +0200 (CEST) In-Reply-To: <20170329062706.GD18844@yliu-dev.sh.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/29/2017 2:27 PM, Yuanhan Liu wrote: > On Tue, Mar 28, 2017 at 08:21:53AM +0000, Jianfeng Tan wrote: >> For virtio PCI devices, interrupt should be configured before setting >> VIRTIO_CONFIG_STATUS_DRIVER_OK so that QEMU can properly set eventfds >> in the host. >> >> For virtio virtual devices, VIRTIO_CONFIG_STATUS_DRIVER_OK should be >> set firstly, so that intr_handle is initialized in >> virtio_user_start_device(). > I'm wondering why can't you let virtio-user follow virtio-pci? It's because that virtio-user not only counts on virtio_user_start_device() to allocate intr_handle, it also needs the information in this function to initialize this struct. For virtio-pci, similar information is from rte_intr_enable/rte_intr_efd_enable. Or do you mean we can move calling virtio_user_start_device() ahead? I can hardly find other place instead of DRIVER_OK. Thanks, Jianfeng