All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: hs@denx.de, u-boot@lists.denx.de
Cc: Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list
Date: Mon, 5 Jul 2021 09:25:21 +0200	[thread overview]
Message-ID: <ef779b03-7313-9c33-0ea3-ac738616fcf7@denx.de> (raw)
In-Reply-To: <91e1119f-1f43-dbf6-2563-4ece8fae3bae@denx.de>

On 7/5/21 6:17 AM, Heiko Schocher wrote:
> Hello Marek,
> 
> On 04.07.21 21:31, Marek Vasut wrote:
>> Linux kernel binding is using atmel,24c01 compatible string. On the
>> other hand there is atmel,24c01a which is not listed in the kernel.
>> Add compatible string without "a" suffix to be compatible with Linux
>> kernel binding.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Heiko Schocher <hs@denx.de>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> ---
>>   drivers/misc/i2c_eeprom.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>
> 
> Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel,
> may we should remove it in U-Boot completly?

Sadly they are both used by the DTs, so we cannot. That's why we also 
have 24c08 and 24c08a in the compatibles, it's exactly the same change.

  reply	other threads:[~2021-07-05  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-04 19:31 Marek Vasut
2021-07-05  4:17 ` Heiko Schocher
2021-07-05  7:25   ` Marek Vasut [this message]
2021-07-14 20:52 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef779b03-7313-9c33-0ea3-ac738616fcf7@denx.de \
    --to=marex@denx.de \
    --cc=hs@denx.de \
    --cc=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    --subject='Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.