Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine - Philippe Mathieu-Daudé

From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Alistair Francis <alistair.francis@xilinx.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine
Date: Wed, 8 Nov 2017 00:29:47 -0300	[thread overview]
Message-ID: <ef7c6cb8-1fad-29fa-558c-c801b777ca9e@amsat.org> (raw)
In-Reply-To: <20171108022828.7242-7-f4bug@amsat.org>

On 11/07/2017 11:28 PM, Philippe Mathieu-Daudé wrote:
> Deprecated since 2.9.0, guests should be able to use "pc" instead.

I forgot to add Paolo's comment:

"but firmware code paths would be different, do we care?"

> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/i386/pc_piix.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index c462b702ff..df4669c6d3 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -1114,6 +1114,7 @@ static void isapc_machine_options(MachineClass *m)
>      pcmc->smbios_legacy_mode = true;
>      pcmc->has_reserved_memory = false;
>      m->default_cpu_type = X86_CPU_TYPE_NAME("486");
> +    m->deprecated_reason = "Use the \"pc\" machine instead";
>  }
>  
>  DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa,
> 