From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Raspl <raspl@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 08/11] tools/kvm_stat: suppress usage information on
 command line errors
Date: Tue, 12 Dec 2017 19:09:12 +0100
Message-ID: <ef927be3-976b-8bd2-e4b2-49be301e4f16@linux.vnet.ibm.com>
References: <20171211112529.33706-1-raspl@linux.vnet.ibm.com>
 <20171211112529.33706-9-raspl@linux.vnet.ibm.com>
 <e8fa0911-10fc-6050-69d1-fb23fc59b3fe@redhat.com>
Reply-To: raspl@linux.vnet.ibm.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60918 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752307AbdLLSJT (ORCPT
        <rfc822;kvm@vger.kernel.org>); Tue, 12 Dec 2017 13:09:19 -0500
Received: from pps.filterd (m0098417.ppops.net [127.0.0.1])
        by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vBCI6YaK132233
        for <kvm@vger.kernel.org>; Tue, 12 Dec 2017 13:09:18 -0500
Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])
        by mx0a-001b2d01.pphosted.com with ESMTP id 2etjs13ska-1
        (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
        for <kvm@vger.kernel.org>; Tue, 12 Dec 2017 13:09:18 -0500
Received: from localhost
        by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
        for <kvm@vger.kernel.org> from <raspl@linux.vnet.ibm.com>;
        Tue, 12 Dec 2017 18:09:16 -0000
In-Reply-To: <e8fa0911-10fc-6050-69d1-fb23fc59b3fe@redhat.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 12.12.2017 16:53, Paolo Bonzini wrote:
> On 11/12/2017 12:25, Stefan Raspl wrote:
>>          except:
>> -            raise optparse.OptionValueError('Error while searching for guest '
>> -                                            '"{}", use "-p" to specify a pid '
>> -                                            'instead'.format(val))
>> +            sys.exit('Error while searching for guest "{}", use "-p" to '
>> +                     'specify a pid instead'.format(val))
> 
> Maybe:
> 
> Error while searching for guest "{}". Use "-p" to specify a pid instead?

Yeah - 2 short sentences instead of a single longer one...why not?

Ciao,
Stefan