From: Chintan Vankar <c-vankar@ti.com>
To: Jacob Keller <jacob.e.keller@intel.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Roger Quadros <rogerq@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets
Date: Fri, 1 Mar 2024 16:18:32 +0530 [thread overview]
Message-ID: <ef948e8e-b1ae-476f-b07f-4bda6d33c51b@ti.com> (raw)
In-Reply-To: <3e81297c-2821-4af4-b13d-dc33ae8f85cc@intel.com>
On 17/02/24 03:51, Jacob Keller wrote:
>
>
> On 2/15/2024 3:09 AM, Chintan Vankar wrote:
>> The CPSW peripherals on J7AHP, J7VCL, J7AEP, J7ES, AM64 SoCs have
>> an errata i2401 "CPSW: Host Timestamps Cause CPSW Port to Lock up".
>>
>
> What's different about timestamping only PTP packets that prevents this
> port lock up?
The difference is the way we are timestamping the packets. Instead of
getting the timestamp from CPTS module, we are getting the timestamp
from CPTS Event FIFO.
In the current mechanism of timestamping, am65-cpsw-nuss driver
timestamps all received packets by setting the TSTAMP_EN bit in
CPTS_CONTROL register, which directs the CPTS module to timestamp all
received packets, followed by passing timestamp via DMA descriptors.
This mechanism was responsible for the CPSW port to lock up in certain
condition. We are preventing port lock up by disabling TSTAMP_EN bit in
CPTS_CONTROL register.
The mechanism we are following in this patch, utilizes the CPTS Event
FIFO that records timestamps corresponding to certain events, with one
such event being the reception of an Ethernet packet with EtherType
field set to PTP.
next prev parent reply other threads:[~2024-03-01 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 11:09 [PATCH net-next 1/2] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Chintan Vankar
2024-02-15 11:09 ` [PATCH net-next 2/2] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets Chintan Vankar
2024-02-16 22:21 ` Jacob Keller
2024-03-01 10:48 ` Chintan Vankar [this message]
2024-03-01 21:32 ` Keller, Jacob E
2024-02-19 10:59 ` Roger Quadros
2024-02-24 8:59 ` Siddharth Vadapalli
2024-02-26 12:18 ` Roger Quadros
2024-02-27 6:15 ` Chintan Vankar
2024-02-16 22:20 ` [PATCH net-next 1/2] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Jacob Keller
2024-02-19 10:25 ` Roger Quadros
2024-02-19 11:24 ` Roger Quadros
2024-02-26 9:08 ` Chintan Vankar
2024-02-26 12:49 ` Roger Quadros
2024-03-01 11:06 ` Chintan Vankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef948e8e-b1ae-476f-b07f-4bda6d33c51b@ti.com \
--to=c-vankar@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.