* [PATCH] ASoC: sgtl5000: add avc enable control
@ 2017-05-30 11:00 ` Richard Leitner
0 siblings, 0 replies; 5+ messages in thread
From: Richard Leitner @ 2017-05-30 11:00 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai
Cc: alsa-devel, linux-kernel, dev, Richard Leitner
This control enables the automatic volume control (AVC) of SGTL5000
using its DAP_AVC_CTRL register.
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
sound/soc/codecs/sgtl5000.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 5a2702e..ad8c9a8 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -434,6 +434,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
0x1f, 1,
lineout_volume),
SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
+
+ SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
};
/* mute the codec used by alsa core */
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ASoC: sgtl5000: add avc enable control
@ 2017-05-30 11:00 ` Richard Leitner
0 siblings, 0 replies; 5+ messages in thread
From: Richard Leitner @ 2017-05-30 11:00 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai
Cc: alsa-devel, linux-kernel, dev, Richard Leitner
This control enables the automatic volume control (AVC) of SGTL5000
using its DAP_AVC_CTRL register.
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
sound/soc/codecs/sgtl5000.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 5a2702e..ad8c9a8 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -434,6 +434,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
0x1f, 1,
lineout_volume),
SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
+
+ SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
};
/* mute the codec used by alsa core */
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: add avc enable control
2017-05-30 11:00 ` Richard Leitner
(?)
@ 2017-05-30 11:33 ` Mark Brown
2017-05-30 11:46 ` Richard Leitner
-1 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2017-05-30 11:33 UTC (permalink / raw)
To: Richard Leitner; +Cc: lgirdwood, perex, tiwai, alsa-devel, linux-kernel, dev
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote:
> +
> + SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
All on/off switches should end in Switch as covered in ControlNames.txt.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: add avc enable control
2017-05-30 11:33 ` Mark Brown
@ 2017-05-30 11:46 ` Richard Leitner
0 siblings, 0 replies; 5+ messages in thread
From: Richard Leitner @ 2017-05-30 11:46 UTC (permalink / raw)
To: Mark Brown; +Cc: lgirdwood, perex, tiwai, alsa-devel, linux-kernel, dev
On 05/30/2017 01:33 PM, Mark Brown wrote:
> On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote:
>
>> +
>> + SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
>
> All on/off switches should end in Switch as covered in ControlNames.txt.
Ok. Sorry & Thanks. I'll send a V2.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: sgtl5000: add avc enable control
@ 2017-05-30 11:46 ` Richard Leitner
0 siblings, 0 replies; 5+ messages in thread
From: Richard Leitner @ 2017-05-30 11:46 UTC (permalink / raw)
To: Mark Brown; +Cc: lgirdwood, perex, tiwai, alsa-devel, linux-kernel, dev
On 05/30/2017 01:33 PM, Mark Brown wrote:
> On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote:
>
>> +
>> + SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0),
>
> All on/off switches should end in Switch as covered in ControlNames.txt.
Ok. Sorry & Thanks. I'll send a V2.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-30 11:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-30 11:00 [PATCH] ASoC: sgtl5000: add avc enable control Richard Leitner
2017-05-30 11:00 ` Richard Leitner
2017-05-30 11:33 ` Mark Brown
2017-05-30 11:46 ` Richard Leitner
2017-05-30 11:46 ` Richard Leitner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.