From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C05C433DB for ; Mon, 22 Mar 2021 16:04:09 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D825D619AA for ; Mon, 22 Mar 2021 16:04:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D825D619AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mayadata.io Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0D0B40040; Mon, 22 Mar 2021 17:04:07 +0100 (CET) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mails.dpdk.org (Postfix) with ESMTP id A2ED74003D for ; Mon, 22 Mar 2021 17:04:06 +0100 (CET) Received: by mail-ed1-f46.google.com with SMTP id h10so19970381edt.13 for ; Mon, 22 Mar 2021 09:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=uaQLFttm0YfgpmAV9O0OnZx9dpvnBeVst11gxiDQnFA=; b=eyNtCN+8HJZj7bl9mrTgpNWZpOyJknya5KrG1nmm/bqiu0AVhqT0rnFL9alNIK46Ko zd9QAnsL/vdkpR6s+2B0OuWV/BCAvkOVEbkM0aqvb/WdDPw38wShGM69+xmK6jJmCSzC rPlxgkBvlx1QQve3vkhewB4We5B/7WXj/eEk0e6l5SLtkkuRl17VNqsPD34WGOla50gg Yh3eGQ/FHSFk4A3ZGd41J1YzFZAXHDmFl9rVUANUZWIhXis95Vn/qPb9NbBukUGxG4fr 6p/MT4Q46NhyO4SF8lBGFfaghSAu8LzYMcOzMoXnapZRWtQR5Y6q/xMNavqEwBsJJQZP 23rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=uaQLFttm0YfgpmAV9O0OnZx9dpvnBeVst11gxiDQnFA=; b=dCpYK++jWIhRpt41yhg7CiUuS9H3ozLtskHzaMoB8vl7KT4HtjwmeTwqDEg0vN/BGv UrueOibBX9Zc23k/EZvc1ez9pCwVWwGFA4F88rXnjUN36lAwH8DLLLZ+NTgXuZx+L/9N CUY085lT/YGPl90J+II6xQYIceVFrvownxmuVblIzvp9wgRTFPhIXh+83It3ajbqfwzi 9X+jYTdhFQGlMO5Fs3utFtsOn0yNdOwYpbtKIxeiQgXxcs5RNc1Rxt0pKz4FzVGjbZ+L F/PxZecGmEh0v4L+58XI1dHBO0ahUaNIh/qQqe49P1riGTJaUl8q4pD8S1fMwgfjSOFD kFTQ== X-Gm-Message-State: AOAM530bKnxqgnNUya3dJSqiysFJENE5CkzjojzxkIGLZ/dl0PM37ZoD r5ay11nwTaKFblsy4YciH9hGkw== X-Google-Smtp-Source: ABdhPJzJXEMZna4FCBUudoyByeePFx52MOhNXxVUgiXyJcf2AUUjZil6TILAHaGLGKOyVZ1x2UAD8w== X-Received: by 2002:a05:6402:30a5:: with SMTP id df5mr318601edb.24.1616429046357; Mon, 22 Mar 2021 09:04:06 -0700 (PDT) Received: from [192.168.0.33] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id y20sm9748545ejj.43.2021.03.22.09.04.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 09:04:05 -0700 (PDT) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Gabriel Ganne , Bruce Richardson , Kevin Laatz Cc: dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com, Dmitry Kozlyuk , "Dmitry Malloy (MESHCHANINOV)" , tal Shnaiderman , "Menon, Ranjit" , Thomas Monjalon , Tyler Retzlaff References: <20210322140757.7888-1-gabriel.ganne@6wind.com> Message-ID: Date: Mon, 22 Mar 2021 16:04:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322140757.7888-1-gabriel.ganne@6wind.com> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > meson guarantees this is portable, so this also allows us to remove a > is_windows switch. Hi Gabriel, On Windows, there are at least three different compilation options: * MinGW-w64 with posix threads * MinGW-w64 with win32 threads (different download) * Clang without threads support The Windows EAL library doesn't use a threads package and instead uses it's own wrappers around the native Windows system calls. Given that, I believe the existing behaviour of not specifying the pthreads package for a Windows build is correct and shouldn't be changed. Regards, Nick