From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jacky Bai <ping.bai@nxp.com> Subject: Re: [PATCH v8 06/13] arm64: dts: freescale: Add i.MX8DXL evk board support Date: Tue, 19 Apr 2022 13:40:21 +0200 [thread overview] Message-ID: <efb859ec-4ca4-ca2e-bc6c-c3e50e779dc6@linaro.org> (raw) In-Reply-To: <20220419113516.1827863-7-abel.vesa@nxp.com> On 19/04/2022 13:35, Abel Vesa wrote: > From: Jacky Bai <ping.bai@nxp.com> > > Add i.MX8DXL EVK board support. > Thank you for your patch. There is something to discuss/improve. (...) > + /* global autoconfigured region for contiguous allocations */ > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + size = <0 0x14000000>; > + alloc-ranges = <0 0x98000000 0 0x14000000>; > + linux,cma-default; > + }; > + }; > + > + reg_usdhc2_vmmc: usdhc2-vmmc { usdhc2-vmmc-regulator or regulator-0 (...) > +&thermal_zones { > + pmic-thermal0 { Are you sure this passes the dtbs_check? > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tsens IMX_SC_R_PMIC_0>; > + (...) > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK 0x06000041 > + IMX8DXL_EMMC0_CMD_CONN_EMMC0_CMD 0x00000021 > + IMX8DXL_EMMC0_DATA0_CONN_EMMC0_DATA0 0x00000021 > + IMX8DXL_EMMC0_DATA1_CONN_EMMC0_DATA1 0x00000021 > + IMX8DXL_EMMC0_DATA2_CONN_EMMC0_DATA2 0x00000021 > + IMX8DXL_EMMC0_DATA3_CONN_EMMC0_DATA3 0x00000021 > + IMX8DXL_EMMC0_DATA4_CONN_EMMC0_DATA4 0x00000021 > + IMX8DXL_EMMC0_DATA5_CONN_EMMC0_DATA5 0x00000021 > + IMX8DXL_EMMC0_DATA6_CONN_EMMC0_DATA6 0x00000021 > + IMX8DXL_EMMC0_DATA7_CONN_EMMC0_DATA7 0x00000021 > + IMX8DXL_EMMC0_STROBE_CONN_EMMC0_STROBE 0x00000041 > + >; > + }; > + > + pinctrl_usdhc1_100mhz: usdhc1grp100mhz { and this as well... I don't remember if we have schema for this but even without it, it breaks the convention. See other files. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jacky Bai <ping.bai@nxp.com> Subject: Re: [PATCH v8 06/13] arm64: dts: freescale: Add i.MX8DXL evk board support Date: Tue, 19 Apr 2022 13:40:21 +0200 [thread overview] Message-ID: <efb859ec-4ca4-ca2e-bc6c-c3e50e779dc6@linaro.org> (raw) In-Reply-To: <20220419113516.1827863-7-abel.vesa@nxp.com> On 19/04/2022 13:35, Abel Vesa wrote: > From: Jacky Bai <ping.bai@nxp.com> > > Add i.MX8DXL EVK board support. > Thank you for your patch. There is something to discuss/improve. (...) > + /* global autoconfigured region for contiguous allocations */ > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + size = <0 0x14000000>; > + alloc-ranges = <0 0x98000000 0 0x14000000>; > + linux,cma-default; > + }; > + }; > + > + reg_usdhc2_vmmc: usdhc2-vmmc { usdhc2-vmmc-regulator or regulator-0 (...) > +&thermal_zones { > + pmic-thermal0 { Are you sure this passes the dtbs_check? > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tsens IMX_SC_R_PMIC_0>; > + (...) > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK 0x06000041 > + IMX8DXL_EMMC0_CMD_CONN_EMMC0_CMD 0x00000021 > + IMX8DXL_EMMC0_DATA0_CONN_EMMC0_DATA0 0x00000021 > + IMX8DXL_EMMC0_DATA1_CONN_EMMC0_DATA1 0x00000021 > + IMX8DXL_EMMC0_DATA2_CONN_EMMC0_DATA2 0x00000021 > + IMX8DXL_EMMC0_DATA3_CONN_EMMC0_DATA3 0x00000021 > + IMX8DXL_EMMC0_DATA4_CONN_EMMC0_DATA4 0x00000021 > + IMX8DXL_EMMC0_DATA5_CONN_EMMC0_DATA5 0x00000021 > + IMX8DXL_EMMC0_DATA6_CONN_EMMC0_DATA6 0x00000021 > + IMX8DXL_EMMC0_DATA7_CONN_EMMC0_DATA7 0x00000021 > + IMX8DXL_EMMC0_STROBE_CONN_EMMC0_STROBE 0x00000041 > + >; > + }; > + > + pinctrl_usdhc1_100mhz: usdhc1grp100mhz { and this as well... I don't remember if we have schema for this but even without it, it breaks the convention. See other files. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-19 11:41 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-19 11:35 [PATCH v8 00/13] arm64: dts: Add i.MX8DXL initial support Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 01/13] arm64: dts: freescale: Add the top level dtsi support for imx8dxl Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:41 ` Krzysztof Kozlowski 2022-04-19 11:41 ` Krzysztof Kozlowski 2022-04-19 11:35 ` [PATCH v8 02/13] arm64: dts: freescale: Add adma subsystem dtsi " Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 03/13] arm64: dts: freescale: Add the imx8dxl connectivity subsys dtsi Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:43 ` Krzysztof Kozlowski 2022-04-19 11:43 ` Krzysztof Kozlowski 2022-04-19 11:35 ` [PATCH v8 04/13] arm64: dts: freescale: Add ddr subsys dtsi for imx8dxl Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 05/13] arm64: dts: freescale: Add lsio " Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 06/13] arm64: dts: freescale: Add i.MX8DXL evk board support Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:40 ` Krzysztof Kozlowski [this message] 2022-04-19 11:40 ` Krzysztof Kozlowski 2022-04-19 11:35 ` [PATCH v8 07/13] dt-bindings: fsl: scu: Add i.MX8DXL ocotp and scu-pd binding Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 08/13] dt-bindings: arm: Document i.MX8DXL EVK board binding Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-20 16:24 ` Rob Herring 2022-04-20 16:24 ` Rob Herring 2022-04-19 11:35 ` [PATCH v8 09/13] dt-bindings: mmc: imx-esdhc: Add i.MX8DXL compatible string Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-21 13:54 ` Ulf Hansson 2022-04-21 13:54 ` Ulf Hansson 2022-04-19 11:35 ` [PATCH v8 10/13] dt-bindings: net: fec: " Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 11/13] dt-bindings: phy: mxs-usb-phy: " Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 12/13] dt-bindings: usb: ci-hdrc-usb2: " Abel Vesa 2022-04-19 11:35 ` Abel Vesa 2022-04-19 11:35 ` [PATCH v8 13/13] dt-bindings: usb: usbmisc-imx: " Abel Vesa 2022-04-19 11:35 ` Abel Vesa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=efb859ec-4ca4-ca2e-bc6c-c3e50e779dc6@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=abel.vesa@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=ping.bai@nxp.com \ --cc=robh@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.