From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B32C433F5 for ; Tue, 19 Apr 2022 11:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239568AbiDSLnr (ORCPT ); Tue, 19 Apr 2022 07:43:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352325AbiDSLnM (ORCPT ); Tue, 19 Apr 2022 07:43:12 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 149271EEE5 for ; Tue, 19 Apr 2022 04:40:24 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id t11so32246580eju.13 for ; Tue, 19 Apr 2022 04:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hcwhzmzfL26TAKtQRPD1wNariBwcxaFreylxMdtXb80=; b=MwJ/XiGAyyPrcSbgJo3k5Qt6BHxqWTh4LApUB/2udnABbiFsrTItmlOpmxNseH09Cl XEIoaRZ3y49NNb+TWkoxlJ7GuV+20JT+pL+P3yU/c0i/cnROK+4P4zhm7n1cg8negyHp Ecc7487RWUynXX95NupT0Plw9izrrFIhFv0YES89lwEyaabL8OFlMMDCvgySp5pQNJx6 7MryYQIFMfSIo+XJ8rz/qDB8GNb+E1a0SISdkKqPte9xKldZyy9XMDN05AIq14B+OuCN s+obkZssE2zV+x7mrnmnEnEgzJDz9O/KfDs1/3RYl4YrlPd3tt7I0W8C3QIN3aDAyDby GCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hcwhzmzfL26TAKtQRPD1wNariBwcxaFreylxMdtXb80=; b=tMsNOdHWyunqvPk9rR7oPk/aod0PDzgykKe38YR2X9D+BtFdgrruB5zdgMMC8QR+Ib tHfLLovGe8jmxw0Oepd0mN6Ys92mcwDepJpgLeIkDdU5oIXqZBYDnUwaNwg/tpeEPl7G FxZRQqCh5+SjLKQN/1Im2sZLNdAsoMEcpapaUS5435kmUqEW6/f3jhqp45g6Bi8qLqxh w3wbkE9WmdFcHPX9cmAtLE7bK+5/2+V+nWuE3rBXcYNooslvS97XZXf8GALoL+mC1+rC V8V2HRQ9/JlNW3W7/TPOuCuHVjGzMxjP7TZ8C8LDW6zdhu013tg1axuRbqc9qmz+9Lq5 KJMg== X-Gm-Message-State: AOAM533nuRk/nJ/vcnaie8PEXeKiN/zoaDo3ag+SK6z3AQKhh+5XK7Jv 6ZLJ/PB2+mwx02HAAbY+XGrRXw== X-Google-Smtp-Source: ABdhPJz1P9B0z3QsIUrpZk+2ju/oxQxuz+zzvYNFL0xJnzmXCwLmLp18B+zu9L//zCVqfBZ1agRh0g== X-Received: by 2002:a17:907:a425:b0:6ef:8e2f:4215 with SMTP id sg37-20020a170907a42500b006ef8e2f4215mr10377380ejc.283.1650368422694; Tue, 19 Apr 2022 04:40:22 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id b20-20020a1709063f9400b006e12836e07fsm5600637ejj.154.2022.04.19.04.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 04:40:22 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 13:40:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v8 06/13] arm64: dts: freescale: Add i.MX8DXL evk board support Content-Language: en-US To: Abel Vesa , Rob Herring , Ulf Hansson , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jacky Bai References: <20220419113516.1827863-1-abel.vesa@nxp.com> <20220419113516.1827863-7-abel.vesa@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220419113516.1827863-7-abel.vesa@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2022 13:35, Abel Vesa wrote: > From: Jacky Bai > > Add i.MX8DXL EVK board support. > Thank you for your patch. There is something to discuss/improve. (...) > + /* global autoconfigured region for contiguous allocations */ > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + size = <0 0x14000000>; > + alloc-ranges = <0 0x98000000 0 0x14000000>; > + linux,cma-default; > + }; > + }; > + > + reg_usdhc2_vmmc: usdhc2-vmmc { usdhc2-vmmc-regulator or regulator-0 (...) > +&thermal_zones { > + pmic-thermal0 { Are you sure this passes the dtbs_check? > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tsens IMX_SC_R_PMIC_0>; > + (...) > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK 0x06000041 > + IMX8DXL_EMMC0_CMD_CONN_EMMC0_CMD 0x00000021 > + IMX8DXL_EMMC0_DATA0_CONN_EMMC0_DATA0 0x00000021 > + IMX8DXL_EMMC0_DATA1_CONN_EMMC0_DATA1 0x00000021 > + IMX8DXL_EMMC0_DATA2_CONN_EMMC0_DATA2 0x00000021 > + IMX8DXL_EMMC0_DATA3_CONN_EMMC0_DATA3 0x00000021 > + IMX8DXL_EMMC0_DATA4_CONN_EMMC0_DATA4 0x00000021 > + IMX8DXL_EMMC0_DATA5_CONN_EMMC0_DATA5 0x00000021 > + IMX8DXL_EMMC0_DATA6_CONN_EMMC0_DATA6 0x00000021 > + IMX8DXL_EMMC0_DATA7_CONN_EMMC0_DATA7 0x00000021 > + IMX8DXL_EMMC0_STROBE_CONN_EMMC0_STROBE 0x00000041 > + >; > + }; > + > + pinctrl_usdhc1_100mhz: usdhc1grp100mhz { and this as well... I don't remember if we have schema for this but even without it, it breaks the convention. See other files. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EB8FC433EF for ; Tue, 19 Apr 2022 12:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9v2evoUmubBG1CieFB33eXdfdG6LSg9wprgQS7r/LE=; b=mKvWPSwbU4dspf bYNaskr7nG0aRIVTMQTZoNRZcNYAAaxmomVB+jBPdTr14yGOPC+KolHnGlh3eeBBUTlutqTYctSyY U5WxbAXY4mEQ+8IxM0OMowHOwOoUBJnnMtDC4BxcUIVEigy4s65eTcYLgKFDVEpYgpzVwhf6Ftf6Z 9avuQ178GSq3GFf7qISB6wO9QTi8I+yGLxOkIcEJYZjr6INtrQQFealKuKyDTnoH4eBjHKiO0BTdm qnnZrse1ePtMdM7H2+wthkcXFHNAtOSm1KfDCSglgc5MRsTTLsFcclHLfeX7r/HbxRACrV0PBMKNy jUSCtED93g/FbX2/LanQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngnKW-003ckE-Pc; Tue, 19 Apr 2022 12:51:42 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngmDY-003CRU-8n for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 11:40:25 +0000 Received: by mail-ej1-x629.google.com with SMTP id lc2so32240283ejb.12 for ; Tue, 19 Apr 2022 04:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hcwhzmzfL26TAKtQRPD1wNariBwcxaFreylxMdtXb80=; b=MwJ/XiGAyyPrcSbgJo3k5Qt6BHxqWTh4LApUB/2udnABbiFsrTItmlOpmxNseH09Cl XEIoaRZ3y49NNb+TWkoxlJ7GuV+20JT+pL+P3yU/c0i/cnROK+4P4zhm7n1cg8negyHp Ecc7487RWUynXX95NupT0Plw9izrrFIhFv0YES89lwEyaabL8OFlMMDCvgySp5pQNJx6 7MryYQIFMfSIo+XJ8rz/qDB8GNb+E1a0SISdkKqPte9xKldZyy9XMDN05AIq14B+OuCN s+obkZssE2zV+x7mrnmnEnEgzJDz9O/KfDs1/3RYl4YrlPd3tt7I0W8C3QIN3aDAyDby GCHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hcwhzmzfL26TAKtQRPD1wNariBwcxaFreylxMdtXb80=; b=eSKh70OvkAsgbwK52veEeez++d4qNAavx1DRtFt7xsGNxBrYiARekB2DbclADbXR7w rfw6yBXZLjS04L4zv7FBOpeCwxhcnETgXah5xNlk1Ey7+5DVNHNeCIDZWKX+lytV83cf RJ5CJ6bQI/H32YRtwHL6B001udHAhykOj7oaegpG4E9MN+6CCN9UM0jIrkB2qzjmOomv Q8Ycd+C2cAjU4SxkGQbk9vqCsG6RFlOLxAWWS+B/yx1tlaup8Kqwlm/cIm0SL6jhu/De tFXzpziLptvKJMK5ZaG7XjczzG1Ye6zeJQ1CUyDQUl6kS/ZMSlGig56nVlgmsyX6kwPV NTwg== X-Gm-Message-State: AOAM530Xk9LUSKxsvCI3v3hyL8Q5hsFcJCUToZuEy/uLe2ca2OJcZbla nwnL/vB0bMn0C+0rjwuU3eezDQ== X-Google-Smtp-Source: ABdhPJz1P9B0z3QsIUrpZk+2ju/oxQxuz+zzvYNFL0xJnzmXCwLmLp18B+zu9L//zCVqfBZ1agRh0g== X-Received: by 2002:a17:907:a425:b0:6ef:8e2f:4215 with SMTP id sg37-20020a170907a42500b006ef8e2f4215mr10377380ejc.283.1650368422694; Tue, 19 Apr 2022 04:40:22 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id b20-20020a1709063f9400b006e12836e07fsm5600637ejj.154.2022.04.19.04.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 04:40:22 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 13:40:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v8 06/13] arm64: dts: freescale: Add i.MX8DXL evk board support Content-Language: en-US To: Abel Vesa , Rob Herring , Ulf Hansson , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jacky Bai References: <20220419113516.1827863-1-abel.vesa@nxp.com> <20220419113516.1827863-7-abel.vesa@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220419113516.1827863-7-abel.vesa@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_044024_379285_3143E28F X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19/04/2022 13:35, Abel Vesa wrote: > From: Jacky Bai > > Add i.MX8DXL EVK board support. > Thank you for your patch. There is something to discuss/improve. (...) > + /* global autoconfigured region for contiguous allocations */ > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + size = <0 0x14000000>; > + alloc-ranges = <0 0x98000000 0 0x14000000>; > + linux,cma-default; > + }; > + }; > + > + reg_usdhc2_vmmc: usdhc2-vmmc { usdhc2-vmmc-regulator or regulator-0 (...) > +&thermal_zones { > + pmic-thermal0 { Are you sure this passes the dtbs_check? > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&tsens IMX_SC_R_PMIC_0>; > + (...) > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + IMX8DXL_EMMC0_CLK_CONN_EMMC0_CLK 0x06000041 > + IMX8DXL_EMMC0_CMD_CONN_EMMC0_CMD 0x00000021 > + IMX8DXL_EMMC0_DATA0_CONN_EMMC0_DATA0 0x00000021 > + IMX8DXL_EMMC0_DATA1_CONN_EMMC0_DATA1 0x00000021 > + IMX8DXL_EMMC0_DATA2_CONN_EMMC0_DATA2 0x00000021 > + IMX8DXL_EMMC0_DATA3_CONN_EMMC0_DATA3 0x00000021 > + IMX8DXL_EMMC0_DATA4_CONN_EMMC0_DATA4 0x00000021 > + IMX8DXL_EMMC0_DATA5_CONN_EMMC0_DATA5 0x00000021 > + IMX8DXL_EMMC0_DATA6_CONN_EMMC0_DATA6 0x00000021 > + IMX8DXL_EMMC0_DATA7_CONN_EMMC0_DATA7 0x00000021 > + IMX8DXL_EMMC0_STROBE_CONN_EMMC0_STROBE 0x00000041 > + >; > + }; > + > + pinctrl_usdhc1_100mhz: usdhc1grp100mhz { and this as well... I don't remember if we have schema for this but even without it, it breaks the convention. See other files. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel