All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: avocado-devel <avocado-devel@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Paul Burton" <pburton@wavecomp.com>,
	"Rob Herring" <robh@kernel.org>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	"Helge Deller" <deller@gmx.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	qemu-arm <qemu-arm@nongnu.org>, "Jan Kiszka" <jan.kiszka@web.de>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	patchew-devel@redhat.com,
	"Radoslaw Biernacki" <radoslaw.biernacki@linaro.org>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
	"Jean-Christophe Dubois" <jcd@tribudubois.net>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Michael Walle" <michael@walle.cc>,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory
Date: Wed, 3 Feb 2021 17:05:59 +0100	[thread overview]
Message-ID: <efbad09a-edd1-1806-1b4a-80bfad23f8d0@redhat.com> (raw)
In-Reply-To: <20191021145729.GC5837@work-vm>

Cc'ing avocado-devel for test idea.

On 10/21/19 4:57 PM, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
>> Cc'ing Paolo/David.
>>
>> On 10/21/19 11:39 AM, Peter Maydell wrote:
>>> On Mon, 21 Oct 2019 at 10:34, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>>>
>>>> On 10/21/19 11:22 AM, Peter Maydell wrote:
>>>>> On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>>>>>
>>>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>>> ---
>>>>>
>>>>>>    hw/arm/virt.c             | 2 +-
>>>>>
>>>>> I think from a quick code scan that this is ok, but did
>>>>> you test that migration compat from old to new still works?
>>>>> I vaguely recall that there are some cases when adding an
>>>>> owner to a memory region changes the name string used for
>>>>> identifying the ramblock in migration.
>>>>
>>>> It seems to still works:
>>>>
>>>> $ make check-qtest-aarch64 V=1
>>>
>>>> This test migrate the virt machine.
>>>>
>>>> Is this enough?
>>>
>>> No, you need to test migration from a QEMU binary without
>>> this patchset to a QEMU binary that has it. Otherwise you're
>>> only checking that the new version can migrate from itself
>>> to itself. I find the easiest way to test this is just to
>>> use the 'savevm' command to save a state snapshot to a
>>> qcow2 disk image while running the old binary, and then run
>>> 'loadvm' with the new binary and check it restored OK.
>>
>> I did not think if this case.
>>
>> I followed your blog post [*] and tested the migration works OK.
>>
>> Paolo, now thinking about regular testing, we should add this testing to
>> patchew too. Something like:
>>
>> - when mainstream/master is updated, patchew build QEMU (it should be
>> already mostly ccached) and generate some vm dumps with 'savevm'.
>>
>> - build/test the series
>>
>> - if series succeeded testing, run 'loadvm' tests
>>
>> [*] https://translatedcode.wordpress.com/2015/07/06/tricks-for-debugging-qemu-savevm-snapshots/
> 
> Avocado certainly already has an option for specifying source and
> destination qemu separately; I've used that for testing
> cross version in the past.
> 
> The challenge is finding a command line/set of devices for each
> architecture that's expected to be stable.
> You want a command line with as big a set of devices as possible (for
> coverage) yet really is tied to machine type.
> 
> Dave
> 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> 



  reply	other threads:[~2021-02-03 16:09 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 22:56 [PATCH 00/21] hw: Let the machine be the owner of the system memory Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 01/21] hw/arm/xilinx_zynq: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2019-10-21 16:49   ` Richard Henderson
2019-10-21 20:47   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 02/21] hw/arm/mps2: " Philippe Mathieu-Daudé
2019-10-21 16:50   ` Richard Henderson
2019-10-21 20:47   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 03/21] hw/arm/collie: Create the RAM in the board Philippe Mathieu-Daudé
2019-10-21 16:55   ` Richard Henderson
2019-10-21 20:49   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 04/21] hw/arm/omap2: " Philippe Mathieu-Daudé
2019-10-21 16:59   ` Richard Henderson
2019-10-21 17:18     ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 05/21] hw/arm/omap1: " Philippe Mathieu-Daudé
2019-10-21 17:03   ` Richard Henderson
2019-10-20 22:56 ` [PATCH 06/21] hw/arm/digic4: Inline digic4_board_setup_ram() function Philippe Mathieu-Daudé
2019-10-21 17:04   ` Richard Henderson
2019-10-21 20:51   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 07/21] hw: Drop QOM ownership on memory_region_allocate_system_memory() calls Philippe Mathieu-Daudé
2019-10-21 23:18   ` Alistair Francis
2019-10-22  9:47     ` Artyom Tarasenko
2019-10-20 22:56 ` [PATCH 08/21] hw/alpha/dp264: Create the RAM in the board Philippe Mathieu-Daudé
2019-10-21  8:53   ` Philippe Mathieu-Daudé
2019-10-21 17:27   ` Richard Henderson
2019-10-21 17:34     ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 09/21] hw: Let memory_region_allocate_system_memory take MachineState argument Philippe Mathieu-Daudé
2019-10-21  7:27   ` Thomas Huth
2019-10-21  8:32     ` Philippe Mathieu-Daudé
2019-10-21 23:19   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 10/21] hw/core: Let the machine be the owner of the system memory Philippe Mathieu-Daudé
2019-10-21 23:20   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 11/21] hw/alpha: " Philippe Mathieu-Daudé
2019-10-21 17:14   ` Richard Henderson
2019-10-21 17:19     ` Richard Henderson
2019-10-21 17:26       ` Philippe Mathieu-Daudé
2019-10-20 22:56 ` [PATCH 12/21] hw/arm: " Philippe Mathieu-Daudé
2019-10-21  9:22   ` Peter Maydell
2019-10-21  9:33     ` Philippe Mathieu-Daudé
2019-10-21  9:39       ` Peter Maydell
2019-10-21 10:24         ` Philippe Mathieu-Daudé
2019-10-21 14:57           ` Dr. David Alan Gilbert
2021-02-03 16:05             ` Philippe Mathieu-Daudé [this message]
2019-10-20 22:56 ` [PATCH 13/21] hw/cris: " Philippe Mathieu-Daudé
2019-10-21 17:28   ` Richard Henderson
2019-10-21 20:56   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 14/21] hw/hppa: " Philippe Mathieu-Daudé
2019-10-21 17:29   ` Richard Henderson
2019-10-21 20:56   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 15/21] hw/i386: " Philippe Mathieu-Daudé
2019-10-21 17:29   ` Richard Henderson
2019-10-21 20:56   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 16/21] hw/lm32: " Philippe Mathieu-Daudé
2019-10-21 17:30   ` Richard Henderson
2019-10-21 20:57   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 17/21] hw/m68k: " Philippe Mathieu-Daudé
2019-10-21  7:28   ` Thomas Huth
2019-10-21 17:31   ` Richard Henderson
2019-10-21 20:57   ` Alistair Francis
2019-10-20 22:56 ` [PATCH 18/21] hw/mips: " Philippe Mathieu-Daudé
2019-10-21  6:25   ` Aleksandar Markovic
2019-10-21  8:34     ` Philippe Mathieu-Daudé
2019-10-21 10:56       ` Aleksandar Markovic
2019-10-21 11:05         ` Philippe Mathieu-Daudé
2019-10-21 11:10           ` Aleksandar Markovic
2019-10-21 11:28             ` Philippe Mathieu-Daudé
2019-10-21 12:10               ` Aleksandar Markovic
2019-10-21 19:24   ` [EXTERNAL][PATCH " Aleksandar Markovic
2019-10-20 22:56 ` [PATCH 19/21] hw/ppc: " Philippe Mathieu-Daudé
2019-10-21  0:44   ` David Gibson
2019-10-21 17:33   ` Richard Henderson
2019-10-20 22:56 ` [PATCH 20/21] hw/sparc: " Philippe Mathieu-Daudé
2019-10-21 17:33   ` Richard Henderson
2019-10-20 22:56 ` [PATCH 21/21] hw/core: Assert memory_region_allocate_system_memory has machine owner Philippe Mathieu-Daudé
2019-10-21 17:41   ` Richard Henderson
2019-10-21 21:00   ` Alistair Francis
2019-10-21  0:03 ` [PATCH 00/21] hw: Let the machine be the owner of the system memory no-reply
2019-10-21  8:52 ` Philippe Mathieu-Daudé
2019-10-21 14:31   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efbad09a-edd1-1806-1b4a-80bfad23f8d0@redhat.com \
    --to=philmd@redhat.com \
    --cc=Andrew.Baumann@microsoft.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=alistair@alistair23.me \
    --cc=amarkovic@wavecomp.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=andrew@aj.id.au \
    --cc=antonynpavlov@gmail.com \
    --cc=armbru@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=avocado-devel@redhat.com \
    --cc=b.galvani@gmail.com \
    --cc=chouteau@adacore.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=deller@gmx.de \
    --cc=dgilbert@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=frederic.konrad@adacore.com \
    --cc=hpoussin@reactos.org \
    --cc=huth@tuxfamily.org \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=jcd@tribudubois.net \
    --cc=joel@jms.id.au \
    --cc=leif.lindholm@linaro.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=michael@walle.cc \
    --cc=mst@redhat.com \
    --cc=patchew-devel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pburton@wavecomp.com \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=radoslaw.biernacki@linaro.org \
    --cc=robh@kernel.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.