From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m6DUc-00025z-HZ for mharc-grub-devel@gnu.org; Wed, 21 Jul 2021 10:46:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DUW-00023c-MX for grub-devel@gnu.org; Wed, 21 Jul 2021 10:46:32 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:3504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6DUU-0001RQ-IC for grub-devel@gnu.org; Wed, 21 Jul 2021 10:46:32 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16LEWxaZ133277; Wed, 21 Jul 2021 10:46:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=2Cnr/c5mAA6Im7YzXG+yYX5kkMvUP66Lo3aLmNVbn8s=; b=IVkGv+e4+aWcp8Pa21t26QS3MaJHH0I76TFbUqmtQdmAHRuKoZQsiuj1XUYBcR+N5uQ1 CxxA7QCx7mfMYVf21kygpnsuhMWUpXYnk8cs04BNa+3cNi9sJlXo2stzrXSSpXRV0wnE n2jN0uETMGZovNybx98AM9QFid65fR57uHxM3Ck2Hn4DDZSBDcLKUgbRBr3pnfUBWOgR RGgZv5BJTp/5nQ9DMQHIozBsWzFuREipq9itqjSuzWPl3ZBiEKuIW6N1QVOfi42StLRs VQOhhps+PJd+GZzHOyZW/eF9Iix8SuEYumkTbdEM5ElqzQQ0CCDxVtJCvBlw4ewWkjxk vA== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 39xmv5hp6b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jul 2021 10:46:25 -0400 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16LEfXen005969; Wed, 21 Jul 2021 14:46:20 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma03wdc.us.ibm.com with ESMTP id 39vqdvey21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jul 2021 14:46:20 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16LEkJDF25952674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jul 2021 14:46:20 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B9CF0112062; Wed, 21 Jul 2021 14:46:19 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B2985112067; Wed, 21 Jul 2021 14:46:19 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 21 Jul 2021 14:46:19 +0000 (GMT) Subject: Re: [PATCH v2 1/4] ieee1275: drop HEAP_MAX_ADDR, HEAP_MIN_SIZE To: Daniel Kiper , Stefan Berger Cc: grub-devel@gnu.org, Daniel Axtens References: <20210720211449.572356-1-stefanb@linux.vnet.ibm.com> <20210720211449.572356-2-stefanb@linux.vnet.ibm.com> <20210721143635.uekavdbrq4xszp3p@tomti.i.net-space.pl> From: Stefan Berger Message-ID: Date: Wed, 21 Jul 2021 10:46:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210721143635.uekavdbrq4xszp3p@tomti.i.net-space.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: zv1lyQ36ITrQ6RBXpxw86mX546G_HD_H X-Proofpoint-GUID: zv1lyQ36ITrQ6RBXpxw86mX546G_HD_H X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-21_09:2021-07-21, 2021-07-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107210084 Received-SPF: pass client-ip=148.163.158.5; envelope-from=stefanb@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.117, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2021 14:46:34 -0000 On 7/21/21 10:36 AM, Daniel Kiper wrote: > On Tue, Jul 20, 2021 at 05:14:46PM -0400, Stefan Berger wrote: >> From: Daniel Axtens >> >> HEAP_MAX_ADDR is confusing. Currently it is set to 32MB, except >> on ieee1275 on x86, where it is 64MB. >> >> There is a comment which purports to explain it: >> >> /* If possible, we will avoid claiming heap above this address, because it >> seems to cause relocation problems with OSes that link at 4 MiB */ >> >> This doesn't make a lot of sense when the constants are well above 4MB >> already. It was not always this way. Prior to >> commit 7b5d0fe4440c ("Increase heap limit") in 2010, HEAP_MAX_SIZE and >> HEAP_MAX_ADDR were indeed 4MB. However, when the constants were increased >> the comment was left unchanged. >> >> It's been over a decade. It doesn't seem like we have problems with >> claims over 4MB on powerpc or x86 ieee1275. (sparc does things completely >> differently and never used the constant.) >> >> Drop the constant and the check. >> >> The only use of HEAP_MIN_SIZE was to potentially override the >> HEAP_MAX_ADDR check. It is now unused. Remove it. >> >> Signed-off-by: Daniel Axtens >> Tested-by: Stefan Berger > Nit, you should add your Signed-off-by after Daniel's one. I can make it > for you if you do not object. I do not object. > Otherwise: Reviewed-by: Daniel Kiper Thanks. > > Daniel