Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag

From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: Rasesh Mody <rmody@marvell.com>,
	Shahed Shaikh <shshaikh@marvell.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@oss.nxp.com>,
	Haiyue Wang <haiyue.wang@intel.com>,
	Gagandeep Singh <g.singh@nxp.com>,
	John Daley <johndale@cisco.com>,
	Hyong Youb Kim <hyonkim@cisco.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Qiming Yang <qiming.yang@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Shijith Thotton <sthotton@marvell.com>,
	Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
	Zyta Szpak <zr@semihalf.com>, Liron Himi <lironh@marvell.com>,
	Harman Kalra <hkalra@marvell.com>,
	Xiao Wang <xiao.w.wang@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag
Date: Thu, 30 Sep 2021 16:45:00 +0300	[thread overview]
Message-ID: <efc6dbd2-51ef-6df3-cb14-da284ab50768@oktetlabs.ru> (raw)
In-Reply-To: <4b39a7ed-2367-b3f2-10d6-6f3d5fc719be@intel.com>

On 9/30/21 4:00 PM, Ferruh Yigit wrote:
> On 9/29/2021 7:38 AM, Andrew Rybchenko wrote:
>> On 9/28/21 8:10 PM, Stephen Hemminger wrote:
>>> On Tue, 28 Sep 2021 19:48:54 +0300
>>> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
>>>
>>>> Some drivers do not provide per-queue statistics. So, there is no point
>>>> to have these misleading zeros in xstats.
>>>>
>>>> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>> Really?
>>> It is useful to have zeros rather than random data there.
>>
>> I guess there is a misunderstanding here. Auto-filling xstats is
>> an addition of per-queue basic statistics to xstats by ethdev
>> layer. It makes sense to do it if and only if there is some
>> sensible data there.
>>
>> There is a related deprecation notice saying that per-queue
>> stats should be removed from basic stats since per-queue
>> stats should be provided by xstats API natively.
>>
>> Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means
>> that corresponding driver is not ready vs the deprecation notice.
>> So, I want to clean it up to see not yet ready drivers only.
>>
> 
> As you said, 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag set by driver means,
> driver is not ready on representing queue stats in xstats and ethdev layer is
> filling it automatically from basic stats.
> 
> First we should wait for drivers to implement it, later clean queue stats from
> basic stats and remove the flag.
> 
> I am not sure if we can remove the deprecation notice in this release, but agree
> to add a deadline for the drivers, which can be 22.11.
> 

I'm going to cleanup deprecation. I don't touch it in the
patch. I just want to cleanup list of drivers which
require attention/changes. Drivers covered here do not
provide per-queue stats in basic stats. So, there is no
point to set the flag to show it in xstats.