All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org,
	Alexey Dobriyan <adobriyan@gmail.com>,
	axboe@fb.com, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] nvme-pci: slimmer CQ head update
Date: Wed, 6 May 2020 18:02:17 +0100	[thread overview]
Message-ID: <efc85e9a-93a6-989b-b8d7-db83b5d74b96@huawei.com> (raw)
In-Reply-To: <3453193c-424b-1e4c-16be-279088612c68@arm.com>

On 06/05/2020 17:52, Robin Murphy wrote:
> On 2020-05-06 5:31 pm, Will Deacon wrote:
>> On Wed, May 06, 2020 at 05:26:35PM +0100, John Garry wrote:
>>> + arm64 guys (Please note WARN below, generated when testing NVMe)
>>>
>>> On 06/05/2020 15:35, Christoph Hellwig wrote:> On Wed, May 06, 2020 at
>>> 02:44:50PM +0100, John Garry wrote:
>>>>> I'd rather hear the maintainer’s opinion before bothering testing 
>>>>> this...
>>>>
>>>> As the other maintainer - please give it a spin.
>>>
>>> ok, so I have tested with the modification from Keith (to avoid the
>>> READ_ONCE()), and it's ok for use_threaded_interrupts=1.
>>>
>>> However, for use_threaded_interrupts=0, I see a new issue:
>>>
>>> [  122.524290] WARNING: CPU: 86 PID: 1157 at
>>> drivers/iommu/io-pgtable-arm.c:304
>>
>> That means you're trying to map something that is already mapped.

Thanks

So I just confirmed iommu.strict=0 has the same issue, as expected.

> 
> ...which is a bit of an achievement with the DMA API, but most likely 
> implies that a prior dma_unmap was called with the wrong size, such that 
> we only unmapped part of the IOVA region that has now been reused.
> 
> John, if you can reproduce this semi-reliably,

Quite reliably.

> try throwing 
> DMA_API_DEBUG at it in the first instance.
> 

ok, let me have a look at that. BTW, could I request changing that WARN 
to the ratelimited variant :)

Cheers,
John

_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2020-05-06 17:03 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-28 18:45 [PATCH] nvme-pci: slimmer CQ head update Alexey Dobriyan
2020-02-29  5:53 ` Keith Busch
2020-05-06 11:03   ` John Garry
2020-05-06 12:47     ` Keith Busch
2020-05-06 13:24       ` Alexey Dobriyan
2020-05-06 13:44         ` John Garry
2020-05-06 14:01           ` Alexey Dobriyan
2020-05-06 14:35           ` Christoph Hellwig
2020-05-06 16:26             ` John Garry
2020-05-06 16:31               ` Will Deacon
2020-05-06 16:52                 ` Robin Murphy
2020-05-06 17:02                   ` John Garry [this message]
2020-05-07  8:18                     ` John Garry
2020-05-07 11:04                       ` Robin Murphy
2020-05-07 13:55                         ` John Garry
2020-05-07 14:23                           ` Keith Busch
2020-05-07 15:11                             ` John Garry
2020-05-07 15:35                               ` Keith Busch
2020-05-07 15:41                                 ` John Garry
2020-05-08 16:16                                   ` Keith Busch
2020-05-08 17:04                                     ` John Garry
2020-05-07 16:26                                 ` Robin Murphy
2020-05-07 17:35                                   ` Keith Busch
2020-05-07 17:44                                     ` Will Deacon
2020-05-07 18:06                                       ` Keith Busch
2020-05-08 11:40                                         ` Will Deacon
2020-05-08 14:07                                           ` Keith Busch
2020-05-08 15:34                                             ` Keith Busch
2020-05-06 14:44         ` Keith Busch
2020-05-07 15:58           ` Keith Busch
2020-05-07 20:07             ` [PATCH] nvme-pci: fix "slimmer CQ head update" Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=efc85e9a-93a6-989b-b8d7-db83b5d74b96@huawei.com \
    --to=john.garry@huawei.com \
    --cc=adobriyan@gmail.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=sagi@grimberg.me \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.