* [PATCH] clocksource/arm_arch_timer: remove unused return type
@ 2019-06-17 9:36 ` Andrew Murray
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Murray @ 2019-06-17 9:36 UTC (permalink / raw)
To: Mark Rutland, Marc Zyngier, Catalin Marinas, Will Deacon, Daniel Lezcano
Cc: linux-kernel, linux-arm-kernel, Stephen Rothwell,
Linux Next Mailing List, kbuild test robot
The function 'arch_timer_set_evtstrm_feature' has no return statement
despite its prototype - let's change the function prototype to return
void. This matches the equivalent arm64 implementation.
fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
arch/arm/include/asm/arch_timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
index ae533caec1e9..99175812d903 100644
--- a/arch/arm/include/asm/arch_timer.h
+++ b/arch/arm/include/asm/arch_timer.h
@@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
isb();
}
-static inline bool arch_timer_set_evtstrm_feature(void)
+static inline void arch_timer_set_evtstrm_feature(void)
{
elf_hwcap |= HWCAP_EVTSTRM;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] clocksource/arm_arch_timer: remove unused return type
@ 2019-06-17 9:36 ` Andrew Murray
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Murray @ 2019-06-17 9:36 UTC (permalink / raw)
To: Mark Rutland, Marc Zyngier, Catalin Marinas, Will Deacon, Daniel Lezcano
Cc: Stephen Rothwell, Linux Next Mailing List, linux-kernel,
linux-arm-kernel, kbuild test robot
The function 'arch_timer_set_evtstrm_feature' has no return statement
despite its prototype - let's change the function prototype to return
void. This matches the equivalent arm64 implementation.
fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
arch/arm/include/asm/arch_timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
index ae533caec1e9..99175812d903 100644
--- a/arch/arm/include/asm/arch_timer.h
+++ b/arch/arm/include/asm/arch_timer.h
@@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
isb();
}
-static inline bool arch_timer_set_evtstrm_feature(void)
+static inline void arch_timer_set_evtstrm_feature(void)
{
elf_hwcap |= HWCAP_EVTSTRM;
}
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource/arm_arch_timer: remove unused return type
2019-06-17 9:36 ` Andrew Murray
@ 2019-06-17 9:45 ` Marc Zyngier
-1 siblings, 0 replies; 8+ messages in thread
From: Marc Zyngier @ 2019-06-17 9:45 UTC (permalink / raw)
To: Andrew Murray, Mark Rutland, Catalin Marinas, Will Deacon,
Daniel Lezcano
Cc: linux-kernel, linux-arm-kernel, Stephen Rothwell,
Linux Next Mailing List, kbuild test robot
On 17/06/2019 10:36, Andrew Murray wrote:
> The function 'arch_timer_set_evtstrm_feature' has no return statement
> despite its prototype - let's change the function prototype to return
> void. This matches the equivalent arm64 implementation.
>
> fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
nit: tags start with a capital letter.
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
> arch/arm/include/asm/arch_timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> index ae533caec1e9..99175812d903 100644
> --- a/arch/arm/include/asm/arch_timer.h
> +++ b/arch/arm/include/asm/arch_timer.h
> @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
> isb();
> }
>
> -static inline bool arch_timer_set_evtstrm_feature(void)
> +static inline void arch_timer_set_evtstrm_feature(void)
> {
> elf_hwcap |= HWCAP_EVTSTRM;
> }
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource/arm_arch_timer: remove unused return type
@ 2019-06-17 9:45 ` Marc Zyngier
0 siblings, 0 replies; 8+ messages in thread
From: Marc Zyngier @ 2019-06-17 9:45 UTC (permalink / raw)
To: Andrew Murray, Mark Rutland, Catalin Marinas, Will Deacon,
Daniel Lezcano
Cc: Stephen Rothwell, Linux Next Mailing List, linux-kernel,
linux-arm-kernel, kbuild test robot
On 17/06/2019 10:36, Andrew Murray wrote:
> The function 'arch_timer_set_evtstrm_feature' has no return statement
> despite its prototype - let's change the function prototype to return
> void. This matches the equivalent arm64 implementation.
>
> fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
nit: tags start with a capital letter.
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
> arch/arm/include/asm/arch_timer.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> index ae533caec1e9..99175812d903 100644
> --- a/arch/arm/include/asm/arch_timer.h
> +++ b/arch/arm/include/asm/arch_timer.h
> @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
> isb();
> }
>
> -static inline bool arch_timer_set_evtstrm_feature(void)
> +static inline void arch_timer_set_evtstrm_feature(void)
> {
> elf_hwcap |= HWCAP_EVTSTRM;
> }
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource/arm_arch_timer: remove unused return type
2019-06-17 9:45 ` Marc Zyngier
@ 2019-06-17 11:47 ` Andrew Murray
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Murray @ 2019-06-17 11:47 UTC (permalink / raw)
To: Marc Zyngier
Cc: Mark Rutland, Catalin Marinas, Will Deacon, Daniel Lezcano,
linux-kernel, linux-arm-kernel, Stephen Rothwell,
Linux Next Mailing List, kbuild test robot
On Mon, Jun 17, 2019 at 10:45:24AM +0100, Marc Zyngier wrote:
> On 17/06/2019 10:36, Andrew Murray wrote:
> > The function 'arch_timer_set_evtstrm_feature' has no return statement
> > despite its prototype - let's change the function prototype to return
> > void. This matches the equivalent arm64 implementation.
> >
> > fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
>
> nit: tags start with a capital letter.
Thanks - I'll remember next time.
Andrew Murray
>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> > arch/arm/include/asm/arch_timer.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> > index ae533caec1e9..99175812d903 100644
> > --- a/arch/arm/include/asm/arch_timer.h
> > +++ b/arch/arm/include/asm/arch_timer.h
> > @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
> > isb();
> > }
> >
> > -static inline bool arch_timer_set_evtstrm_feature(void)
> > +static inline void arch_timer_set_evtstrm_feature(void)
> > {
> > elf_hwcap |= HWCAP_EVTSTRM;
> > }
> >
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
> M.
> --
> Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource/arm_arch_timer: remove unused return type
@ 2019-06-17 11:47 ` Andrew Murray
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Murray @ 2019-06-17 11:47 UTC (permalink / raw)
To: Marc Zyngier
Cc: Mark Rutland, Stephen Rothwell, kbuild test robot,
Catalin Marinas, Daniel Lezcano, Will Deacon, linux-kernel,
Linux Next Mailing List, linux-arm-kernel
On Mon, Jun 17, 2019 at 10:45:24AM +0100, Marc Zyngier wrote:
> On 17/06/2019 10:36, Andrew Murray wrote:
> > The function 'arch_timer_set_evtstrm_feature' has no return statement
> > despite its prototype - let's change the function prototype to return
> > void. This matches the equivalent arm64 implementation.
> >
> > fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
>
> nit: tags start with a capital letter.
Thanks - I'll remember next time.
Andrew Murray
>
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> > arch/arm/include/asm/arch_timer.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> > index ae533caec1e9..99175812d903 100644
> > --- a/arch/arm/include/asm/arch_timer.h
> > +++ b/arch/arm/include/asm/arch_timer.h
> > @@ -125,7 +125,7 @@ static inline void arch_timer_set_cntkctl(u32 cntkctl)
> > isb();
> > }
> >
> > -static inline bool arch_timer_set_evtstrm_feature(void)
> > +static inline void arch_timer_set_evtstrm_feature(void)
> > {
> > elf_hwcap |= HWCAP_EVTSTRM;
> > }
> >
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
> M.
> --
> Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource/arm_arch_timer: remove unused return type
2019-06-17 9:36 ` Andrew Murray
@ 2019-06-17 11:51 ` Daniel Lezcano
-1 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2019-06-17 11:51 UTC (permalink / raw)
To: Andrew Murray, Mark Rutland, Marc Zyngier, Catalin Marinas, Will Deacon
Cc: linux-kernel, linux-arm-kernel, Stephen Rothwell,
Linux Next Mailing List, kbuild test robot
On 17/06/2019 11:36, Andrew Murray wrote:
> The function 'arch_timer_set_evtstrm_feature' has no return statement
> despite its prototype - let's change the function prototype to return
> void. This matches the equivalent arm64 implementation.
>
> fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
I can rebase my branch. I'll fold this patch with 11e34eca5d0a
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource/arm_arch_timer: remove unused return type
@ 2019-06-17 11:51 ` Daniel Lezcano
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Lezcano @ 2019-06-17 11:51 UTC (permalink / raw)
To: Andrew Murray, Mark Rutland, Marc Zyngier, Catalin Marinas, Will Deacon
Cc: Stephen Rothwell, Linux Next Mailing List, linux-kernel,
linux-arm-kernel, kbuild test robot
On 17/06/2019 11:36, Andrew Murray wrote:
> The function 'arch_timer_set_evtstrm_feature' has no return statement
> despite its prototype - let's change the function prototype to return
> void. This matches the equivalent arm64 implementation.
>
> fixes: 11e34eca5d0a ("clocksource/arm_arch_timer: Extract elf_hwcap use to arch-helper")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
I can rebase my branch. I'll fold this patch with 11e34eca5d0a
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-17 11:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 9:36 [PATCH] clocksource/arm_arch_timer: remove unused return type Andrew Murray
2019-06-17 9:36 ` Andrew Murray
2019-06-17 9:45 ` Marc Zyngier
2019-06-17 9:45 ` Marc Zyngier
2019-06-17 11:47 ` Andrew Murray
2019-06-17 11:47 ` Andrew Murray
2019-06-17 11:51 ` Daniel Lezcano
2019-06-17 11:51 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.