* [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
@ 2021-08-17 12:53 Andrew Jones
2021-08-17 13:18 ` wangyanan (Y)
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Andrew Jones @ 2021-08-17 12:53 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P . Berrange, Eduardo Habkost, Cornelia Huck, Yanan Wang,
Paolo Bonzini
Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
introduced documentation stating that a zero input value for an SMP
parameter indicates that its value should be automatically configured.
This is indeed how things work today, but we'd like to change that.
Avoid documenting behaviors we want to leave undefined for the time
being, giving us freedom to change it later.
Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
qapi/machine.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/machine.json b/qapi/machine.json
index c3210ee1fb24..157712f00614 100644
--- a/qapi/machine.json
+++ b/qapi/machine.json
@@ -1288,7 +1288,7 @@
##
# @SMPConfiguration:
#
-# Schema for CPU topology configuration. "0" or a missing value lets
+# Schema for CPU topology configuration. A missing value lets
# QEMU figure out a suitable value based on the ones that are provided.
#
# @cpus: number of virtual CPUs in the virtual machine
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
2021-08-17 12:53 [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation Andrew Jones
@ 2021-08-17 13:18 ` wangyanan (Y)
2021-08-17 13:21 ` Paolo Bonzini
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: wangyanan (Y) @ 2021-08-17 13:18 UTC (permalink / raw)
To: Andrew Jones, qemu-devel
Cc: Paolo Bonzini, Cornelia Huck, Daniel P . Berrange, Eduardo Habkost
On 2021/8/17 20:53, Andrew Jones wrote:
> Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> introduced documentation stating that a zero input value for an SMP
> parameter indicates that its value should be automatically configured.
> This is indeed how things work today, but we'd like to change that.
> Avoid documenting behaviors we want to leave undefined for the time
> being, giving us freedom to change it later.
>
> Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index c3210ee1fb24..157712f00614 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1288,7 +1288,7 @@
> ##
> # @SMPConfiguration:
> #
> -# Schema for CPU topology configuration. "0" or a missing value lets
> +# Schema for CPU topology configuration. A missing value lets
> # QEMU figure out a suitable value based on the ones that are provided.
> #
> # @cpus: number of virtual CPUs in the virtual machine
Reviewed-by: Yanan Wang <wangyanan55@huawei.com>
.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
2021-08-17 12:53 [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation Andrew Jones
2021-08-17 13:18 ` wangyanan (Y)
@ 2021-08-17 13:21 ` Paolo Bonzini
2021-08-17 13:27 ` Cornelia Huck
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2021-08-17 13:21 UTC (permalink / raw)
To: Andrew Jones, qemu-devel
Cc: Yanan Wang, Cornelia Huck, Daniel P . Berrange, Eduardo Habkost
On 17/08/21 14:53, Andrew Jones wrote:
> Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> introduced documentation stating that a zero input value for an SMP
> parameter indicates that its value should be automatically configured.
> This is indeed how things work today, but we'd like to change that.
> Avoid documenting behaviors we want to leave undefined for the time
> being, giving us freedom to change it later.
>
> Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index c3210ee1fb24..157712f00614 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1288,7 +1288,7 @@
> ##
> # @SMPConfiguration:
> #
> -# Schema for CPU topology configuration. "0" or a missing value lets
> +# Schema for CPU topology configuration. A missing value lets
> # QEMU figure out a suitable value based on the ones that are provided.
> #
> # @cpus: number of virtual CPUs in the virtual machine
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
2021-08-17 12:53 [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation Andrew Jones
2021-08-17 13:18 ` wangyanan (Y)
2021-08-17 13:21 ` Paolo Bonzini
@ 2021-08-17 13:27 ` Cornelia Huck
2021-08-17 13:50 ` Philippe Mathieu-Daudé
2021-08-17 15:48 ` Peter Maydell
4 siblings, 0 replies; 6+ messages in thread
From: Cornelia Huck @ 2021-08-17 13:27 UTC (permalink / raw)
To: Andrew Jones, qemu-devel
Cc: Yanan Wang, Paolo Bonzini, Daniel P . Berrange, Eduardo Habkost
On Tue, Aug 17 2021, Andrew Jones <drjones@redhat.com> wrote:
> Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> introduced documentation stating that a zero input value for an SMP
> parameter indicates that its value should be automatically configured.
> This is indeed how things work today, but we'd like to change that.
> Avoid documenting behaviors we want to leave undefined for the time
> being, giving us freedom to change it later.
>
> Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
2021-08-17 12:53 [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation Andrew Jones
` (2 preceding siblings ...)
2021-08-17 13:27 ` Cornelia Huck
@ 2021-08-17 13:50 ` Philippe Mathieu-Daudé
2021-08-17 15:48 ` Peter Maydell
4 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-08-17 13:50 UTC (permalink / raw)
To: Andrew Jones, qemu-devel
Cc: Yanan Wang, Paolo Bonzini, Cornelia Huck, Daniel P . Berrange,
Eduardo Habkost
On 8/17/21 2:53 PM, Andrew Jones wrote:
> Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> introduced documentation stating that a zero input value for an SMP
> parameter indicates that its value should be automatically configured.
> This is indeed how things work today, but we'd like to change that.
> Avoid documenting behaviors we want to leave undefined for the time
> being, giving us freedom to change it later.
>
> Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/machine.json b/qapi/machine.json
> index c3210ee1fb24..157712f00614 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -1288,7 +1288,7 @@
> ##
> # @SMPConfiguration:
> #
> -# Schema for CPU topology configuration. "0" or a missing value lets
> +# Schema for CPU topology configuration. A missing value lets
> # QEMU figure out a suitable value based on the ones that are provided.
> #
> # @cpus: number of virtual CPUs in the virtual machine
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation
2021-08-17 12:53 [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation Andrew Jones
` (3 preceding siblings ...)
2021-08-17 13:50 ` Philippe Mathieu-Daudé
@ 2021-08-17 15:48 ` Peter Maydell
4 siblings, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2021-08-17 15:48 UTC (permalink / raw)
To: Andrew Jones
Cc: Daniel P . Berrange, Eduardo Habkost, Cornelia Huck, qemu-devel,
Yanan Wang, Paolo Bonzini
On Tue, 17 Aug 2021 at 13:56, Andrew Jones <drjones@redhat.com> wrote:
>
> Commit 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> introduced documentation stating that a zero input value for an SMP
> parameter indicates that its value should be automatically configured.
> This is indeed how things work today, but we'd like to change that.
> Avoid documenting behaviors we want to leave undefined for the time
> being, giving us freedom to change it later.
>
> Fixes: 1e63fe685804 ("machine: pass QAPI struct to mc->smp_parse")
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> qapi/machine.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-17 15:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 12:53 [PATCH] qapi/machine.json: Remove zero value reference from SMPConfiguration documentation Andrew Jones
2021-08-17 13:18 ` wangyanan (Y)
2021-08-17 13:21 ` Paolo Bonzini
2021-08-17 13:27 ` Cornelia Huck
2021-08-17 13:50 ` Philippe Mathieu-Daudé
2021-08-17 15:48 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.