From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0764C6FD20 for ; Fri, 24 Mar 2023 03:34:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfY2E-0004TK-KD; Thu, 23 Mar 2023 23:24:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfY2A-0004Qu-Iq for qemu-devel@nongnu.org; Thu, 23 Mar 2023 23:24:07 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfY1s-0006Q0-Tf for qemu-devel@nongnu.org; Thu, 23 Mar 2023 23:24:02 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32O0jTx9025277; Fri, 24 Mar 2023 03:23:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=kXzHsvmIOTvYralLgd8/givRcZMliGvVa0QIw6429sM=; b=hFB0O/fvsB8CelUjBBICzHo8+3kFhBOKcnLwDWk4wa2fmBT80KZm/a1A1yFQh/kytxvP HdvlfCU1VkNmYlBeIfuEBdN9KSnGbHWzTPB/9jYPSV+S1NqpxC+Kp4Tzuf5+KAdenyul sW0oNdlf8/RRWVxD+CeHOsIUvCDss7WbyykLvqI0gSXnQSRePc3UNsX9fvF9gcfr6M84 ouFjnRN+x3JZtgelYExzq8BLmIZssM6nzzUiGIuPyAN65ZqUHXyvTn6mH4ov7/hOUsUT 3ond7GmGLE3X+1VhdFq1D5f+5ncvBOT2hR/JvXsVa6eOrm1iSvJEifves5Ef162d+9ko UQ== Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pgxs1x7wf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Mar 2023 03:23:06 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32O17T6i025485; Fri, 24 Mar 2023 03:23:05 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([9.208.130.97]) by ppma02dal.us.ibm.com (PPS) with ESMTPS id 3pgybnhh07-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Mar 2023 03:23:05 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32O3N4xo33554814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Mar 2023 03:23:04 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2468958079; Fri, 24 Mar 2023 03:23:04 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B19055807D; Fri, 24 Mar 2023 03:23:03 +0000 (GMT) Received: from [9.163.88.196] (unknown [9.163.88.196]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 24 Mar 2023 03:23:03 +0000 (GMT) Message-ID: Date: Thu, 23 Mar 2023 22:23:03 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 1/3] docs: Add support for TPM devices over I2C bus Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Ninad Palsule , qemu-devel@nongnu.org Cc: joel@jms.id.au, andrew@aj.id.au, stefanb@linux.ibm.com References: <20230323030119.2113570-1-ninad@linux.ibm.com> <20230323030119.2113570-2-ninad@linux.ibm.com> From: Ninad Palsule In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: fV91NQ0AfHoMcts3uOC_m620Tu52OkL8 X-Proofpoint-GUID: fV91NQ0AfHoMcts3uOC_m620Tu52OkL8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-23_15,2023-03-23_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 priorityscore=1501 impostorscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2303240025 Received-SPF: none client-ip=148.163.156.1; envelope-from=ninad@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hello Cedric, I tried to use ast2600-evb machine but it is not getting any message on I2C bus. Any suggestions? # Start the software TPM emulator.     $ swtpm socket --tpmstate dir=/tmp/mytpm1   --ctrl type=unixio,path=/tmp/mytpm1/swtpm-sock   --tpm2   --log level=100 # Start a qemu and point at swtpm. I am using i2c bus 12 and address 0x2e     $ ~/qemu/build/qemu-system-arm -M ast2600-evb -nographic -kernel $IMAGEDIR/zImage -dtb $IMAGEDIR/aspeed-ast2600-evb.dtb -initrd $IMAGEDIR/rootfs.cpio -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock -tpmdev emulator,id=tpm0,chardev=chrtpm -device tpm-tis-i2c,tpmdev=tpm0,bus=aspeed.i2c.bus.12,address=0x2e # Inside the ast2600-evb machine. Insantiated the device     # echo 12 0x2e > /sys/bus/i2c/devices/i2c-12/new_device     [  158.265321] i2c i2c-12: new_device: Instantiated device 12 at 0x2e # Tried to instantiate TPM device but nothing happening on I2C bus.     # echo 12-002e > /sys/bus/i2c/drivers/tpm_tis_i2c/bind     sh: write error: No such device Thanks & Regards, Ninad Palsule On 3/23/23 2:49 AM, Cédric Le Goater wrote: > On 3/23/23 04:01, Ninad Palsule wrote: >> This is a documentation change for I2C TPM device support. >> >> Qemu already supports devices attached to ISA and sysbus. >> This drop adds support for the I2C bus attached TPM devices. >> >> Signed-off-by: Ninad Palsule >> >> --- >> V2: >> >> Incorporated Stephen's review comments >> - Added example in the document. >> --- >>   docs/specs/tpm.rst | 20 +++++++++++++++++++- >>   1 file changed, 19 insertions(+), 1 deletion(-) >> >> diff --git a/docs/specs/tpm.rst b/docs/specs/tpm.rst >> index 535912a92b..bf7249b09c 100644 >> --- a/docs/specs/tpm.rst >> +++ b/docs/specs/tpm.rst >> @@ -21,11 +21,15 @@ QEMU files related to TPM TIS interface: >>    - ``hw/tpm/tpm_tis_common.c`` >>    - ``hw/tpm/tpm_tis_isa.c`` >>    - ``hw/tpm/tpm_tis_sysbus.c`` >> + - ``hw/tpm/tpm_tis_i2c.c`` >>    - ``hw/tpm/tpm_tis.h`` >>     Both an ISA device and a sysbus device are available. The former is >>   used with pc/q35 machine while the latter can be instantiated in the >> -Arm virt machine. >> +Arm virt machine. An I2C device support is also added which can be >> +instantiated in the arm based emulation machine. An I2C device is also >> +supported for the Arm virt machine. This device only supports the >> +TPM 2 protocol. >>     CRB interface >>   ------------- >> @@ -348,6 +352,20 @@ In case an Arm virt machine is emulated, use the >> following command line: >>       -drive if=pflash,format=raw,file=flash0.img,readonly=on \ >>       -drive if=pflash,format=raw,file=flash1.img >>   +In case a Rainier bmc machine is emulated, use the following >> command line: >> + >> +.. code-block:: console >> + >> +  qemu-system-arm -M rainier-bmc -nographic \ >> +    -kernel ${IMAGEPATH}/fitImage-linux.bin \ >> +    -dtb ${IMAGEPATH}/aspeed-bmc-ibm-rainier.dtb \ >> +    -initrd ${IMAGEPATH}/obmc-phosphor-initramfs.rootfs.cpio.xz \ >> +    -drive >> file=${IMAGEPATH}/obmc-phosphor-image.rootfs.wic.qcow2,if=sd,index=2\ >> +    -net nic -net >> user,hostfwd=:127.0.0.1:2222-:22,hostfwd=:127.0.0.1:2443-:443\ >> +    -chardev socket,id=chrtpm,path=/tmp/mytpm1/swtpm-sock \ >> +    -tpmdev emulator,id=tpm0,chardev=chrtpm \ >> +    -device tpm-tis-i2c,tpmdev=tpm0,bus=aspeed.i2c.bus.12,address=0x2e > > > The rainier images are not the easiest to find. Could we use an > AST2600 EVB > machine instead and instantiate the device from user space ? see commit > 3302184f7f or 7a7308eae0. > > Thanks, > > C. > >>   In case SeaBIOS is used as firmware, it should show the TPM menu item >>   after entering the menu with 'ESC'. >