From: Max Reitz <mreitz@redhat.com>
To: Lin Ma <lma@suse.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2 V4] hmp: show all of snapshot info on every block dev in output of 'info snapshots'
Date: Tue, 5 Jul 2016 19:26:05 +0200 [thread overview]
Message-ID: <efe38b7c-3b94-fdb0-abf2-a094f22d3e4a@redhat.com> (raw)
In-Reply-To: <1467624719-6645-3-git-send-email-lma@suse.com>
[-- Attachment #1: Type: text/plain, Size: 2822 bytes --]
On 04.07.2016 11:31, Lin Ma wrote:
> Currently, the output of 'info snapshots' shows fully available snapshots.
> It's opaque, hides some snapshot information to users. It's not convenient
> if users want to know more about all of snapshot information on every block
> device via monitor.
>
> Follow Kevin's and Max's proposals, The patch makes the output more detailed:
> (qemu) info snapshots
> List of snapshots present on all disks:
> ID TAG VM SIZE DATE VM CLOCK
> -- checkpoint-1 165M 2016-05-22 16:58:07 00:02:06.813
>
> List of partial (non-loadable) snapshots on 'drive_image1':
> ID TAG VM SIZE DATE VM CLOCK
> 1 snap1 0 2016-05-22 16:57:31 00:01:30.567
>
> Signed-off-by: Lin Ma <lma@suse.com>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
I said it looked good apart from what I said, but I didn't give an R-b,
so this shouldn't be here.
> ---
> migration/savevm.c | 97 ++++++++++++++++++++++++++++++++++++++++++++++++++----
> 1 file changed, 90 insertions(+), 7 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index a8f22da..95e9efa 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
[...]
> @@ -2249,11 +2308,35 @@ void hmp_info_snapshots(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "\n");
> }
> } else {
> - monitor_printf(mon, "There is no suitable snapshot available\n");
> + monitor_printf(mon, "None\n");
> }
>
> + QTAILQ_FOREACH(image_entry, &image_list, next) {
> + if (QTAILQ_EMPTY(&image_entry->snapshots)) {
> + continue;
> + }
> + monitor_printf(mon,
> + "\nList of partial (non-loadable) snapshots on '%s':\n",
> + image_entry->imagename);
> + bdrv_snapshot_dump((fprintf_function)monitor_printf, mon, NULL);
> + monitor_printf(mon, "\n");
> + QTAILQ_FOREACH(snapshot_entry, &image_entry->snapshots, next) {
> + bdrv_snapshot_dump((fprintf_function)monitor_printf, mon,
> + &snapshot_entry->sn);
> + monitor_printf(mon, "\n");
> + }
> + }
> +
> + QTAILQ_FOREACH(image_entry, &image_list, next) {
This needs to be a QTAILQ_FOREACH_SAFE(), too.
Max
> + SnapshotEntry *next_sn;
> + QTAILQ_FOREACH_SAFE(snapshot_entry, &image_entry->snapshots, next,
> + next_sn) {
> + g_free(snapshot_entry);
> + }
> + g_free(image_entry);
> + }
> g_free(sn_tab);
> - g_free(available_snapshots);
> + g_free(global_snapshots);
>
> }
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
next prev parent reply other threads:[~2016-07-05 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 9:31 [Qemu-devel] [PATCH 0/2 V4] Show all of snapshot info on every block dev Lin Ma
2016-07-04 9:31 ` [Qemu-devel] [PATCH 1/2 V4] hmp: use snapshot name to determine whether a snapshot is 'fully available' Lin Ma
2016-07-04 9:31 ` [Qemu-devel] [PATCH 2/2 V4] hmp: show all of snapshot info on every block dev in output of 'info snapshots' Lin Ma
2016-07-05 17:26 ` Max Reitz [this message]
2016-07-06 5:42 ` [Qemu-devel] 答复: " Lin Ma
2016-07-06 12:40 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efe38b7c-3b94-fdb0-abf2-a094f22d3e4a@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lma@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.