From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bkYxH-0004jH-JY for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:52:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bkYxC-0006py-Hr for qemu-devel@nongnu.org; Thu, 15 Sep 2016 11:52:02 -0400 References: <1471625435-6190-1-git-send-email-kwolf@redhat.com> <1471625435-6190-5-git-send-email-kwolf@redhat.com> <20160915083514.GA4726@noname.redhat.com> From: Eric Blake Message-ID: Date: Thu, 15 Sep 2016 10:51:46 -0500 MIME-Version: 1.0 In-Reply-To: <20160915083514.GA4726@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PoIRB4oIf0MWkLSw7GdJ3aeL9RXta1WH0" Subject: Re: [Qemu-devel] [PATCH 04/10] block: Accept device model name for blockdev-open/close-tray List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PoIRB4oIf0MWkLSw7GdJ3aeL9RXta1WH0 From: Eric Blake To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, qemu-devel@nongnu.org, =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= Message-ID: Subject: Re: [PATCH 04/10] block: Accept device model name for blockdev-open/close-tray References: <1471625435-6190-1-git-send-email-kwolf@redhat.com> <1471625435-6190-5-git-send-email-kwolf@redhat.com> <20160915083514.GA4726@noname.redhat.com> In-Reply-To: <20160915083514.GA4726@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/15/2016 03:35 AM, Kevin Wolf wrote: >>> =20 >>> -- "device": block device name (json-string) >>> +- "device": block device name (deprecated, use @id instead) >>> + (json-string, optional) >>> +- "id": the name or QOM path of the guest device (json-string, optio= nal) >>> - "force": if false (the default), an eject request will be sent to = the guest if >>> it has locked the tray (and the tray will not be opened i= mmediately); >>> if true, the tray will be opened regardless of whether it= is locked >> >> Are there any example code snippets that should be updated alongside >> this? If not, should we be thinking of adding an example? >=20 > We could probably update the examples to avoid deprecated fields in > them. Though the old examples still work, so is it worth changing all > examples if we're goig to remove qmp-commands.hx anyway? Or will the > examples be moved to somewhere else? Marc-Andre is moving the examples into qapi-schema.json (and friends), over the course of multiple commits. It's going to be a lot of churn and potential merge conflicts, based on what changes go into qmp-commands.hx after his work starts, but hopefully we can avoid things slipping through the cracks, without too much rebase pain on either Marc-Andre or other developers. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PoIRB4oIf0MWkLSw7GdJ3aeL9RXta1WH0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX2sOSAAoJEKeha0olJ0NqgjIH/jyBIcozjo6r1vswrn5z5w3P ZLwTH0KVWGDuEqyNgOz322B7YbMxid8bnDsUJambAnTGhip5sqgY22idEO9HJtfW Do2vXR0tB1iVHzBlZU2dhF6+bNBksuQyZzYHg4NccOGWcFJ1i/elGB/shw7/oh/a cY0CjXpUzB5hZxldBei6UNd1x5cYDyXLOks5zr5DpmxeTXBX90Zo6BeiM56USLbK amAGufDbvCAW3dBq0FFUq8TT8QaHFiuNukLjlnNqUl6a955pUrDCHqc6Ozx4IWFr qzOnluiZsyh8zTjOLtbPX0vK++ZKlJFSqAIS6KnV2ESsc9A75gdX24kJH5KifkI= =i1cq -----END PGP SIGNATURE----- --PoIRB4oIf0MWkLSw7GdJ3aeL9RXta1WH0--