From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A104BC433EF for ; Thu, 28 Apr 2022 06:33:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244067AbiD1GgY (ORCPT ); Thu, 28 Apr 2022 02:36:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243955AbiD1GgX (ORCPT ); Thu, 28 Apr 2022 02:36:23 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F8306973A for ; Wed, 27 Apr 2022 23:33:09 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id p4so4400653edx.0 for ; Wed, 27 Apr 2022 23:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=uxezT5LnyHKSBkq6AQW89pc3qDtfxZHYMAix0t8fNa7iN8SiPU1Ilsl1nM1G37M5R+ +iu92f1x/5vR1NTnqi8ROX0/LwJwdGKQmoBkn8pixlB6fKZyo7GpO6a7YYkK1pW1jNQT wNHmkFGVSfRqXb8sEShA2W6HoHm5NLbFl5Spems7FPFI6zXPRgGCACekKLjBWUJQMl4E 73ek80xKQJ1KRfH67Egat8mV375c+FUSf/cJw5OVhhrlizX0esnpjiAi8Erb1aORY0vE o3rPGR9G86LWNf4VY5otQY/Gm6CzHNWFv8J3C1ofMgFmk3ptIhJGQ5VBAyLp82amwWr1 6tbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=MpusQUdGJGUg2G1I0mau2zSFgMXoQ7hArddhunNuM7ls8CXSvQxyj7x/ju1h3nyYbi UcST89yVwPcXMgDfJdFktl+VaP3b5/vRz5a/nXnuOMVJW1dqVq/ZB3CZrI+FNgRme/58 eq9YVu6HiV9T7vCyNG1efbWJ0z9zYFdr+o7IHcO20HoFLQRY+WJ8yrO6EWBoD59vLpjl QOJTZUNJrS5qAFIFkrvBNDtnGrj1qGmmBTmxrDycT1ZGH+GhAQZU3D2HbOXPc/sQH0kn PBj4gihmTB3niS8O1dcXcXoxfLmTopjufL0MpD1u743U/95CbUoH6W4mxL/EXE1YA+WW GZwg== X-Gm-Message-State: AOAM533q4ifwJ2SsVGHss3JWgIV3an+axkdRfBMjR3CGZZd0uCc/WNFX nzVj+zFLD7Cf51W780FKzRGOaA== X-Google-Smtp-Source: ABdhPJw0+ayf81Ms9n+w6fNeDibHnLry7oeKKqMj4gZt2cgaTDG/qOgtHFpuAxQnWZ5n0HmQ9WFJHA== X-Received: by 2002:a05:6402:43cc:b0:425:fda3:ac3a with SMTP id p12-20020a05640243cc00b00425fda3ac3amr12162862edc.70.1651127587742; Wed, 27 Apr 2022 23:33:07 -0700 (PDT) Received: from [192.168.0.159] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i23-20020a0564020f1700b0042617ba6382sm943988eda.12.2022.04.27.23.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:33:06 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 08:33:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC/RFT v2 01/11] dt-bindings: phy: rockchip: add PCIe v3 phy Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20220426132139.26761-1-linux@fw-web.de> <20220426132139.26761-2-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220426132139.26761-2-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/04/2022 15:21, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > new file mode 100644 > index 000000000000..3592888b5ee2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip PCIe v3 phy > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3568-pcie3-phy > + - rockchip,rk3588-pcie3-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + items: > + - const: "refclk_m" > + - const: "refclk_n" > + - const: "pclk" Drop quotes. > + > + minItems: 1 I think we agreed to skip rk3588 or make the number of clocks strict? > + > + "#phy-cells": > + const: 0 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: phy > + > + rockchip,phy-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the phy "general register files" > + > + rockchip,pipe-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the pipe "general register files" > + > + rockchip,pcie30-phymode: > + $ref: '/schemas/types.yaml#/definitions/uint32' No need for quotes. You don't use it in other places. > + description: | > + set the phy-mode for enabling bifurcation > + bit0: bifurcation for port 0 > + bit1: bifurcation for port 1 > + bit2: aggregation > + constants are defined in the dt-bindings/phy/phy-rockchip-pcie3.h Full path. It should also follow vendor,device naming convention. > + minimum: 0x0 > + maximum: 0x4 > + default: 0x4 > + > +required: > + - compatible > + - reg > + - rockchip,phy-grf > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + pcie30phy: phy@fe8c0000 { > + compatible = "rockchip,rk3568-pcie3-phy"; > + reg = <0x0 0xfe8c0000 0x0 0x20000>; > + #phy-cells = <0>; > + clocks = <&pmucru CLK_PCIE30PHY_REF_M>, > + <&pmucru CLK_PCIE30PHY_REF_N>, > + <&cru PCLK_PCIE30PHY>; > + clock-names = "refclk_m", "refclk_n", "pclk"; > + resets = <&cru SRST_PCIE30PHY>; > + reset-names = "phy"; > + rockchip,phy-grf = <&pcie30_phy_grf>; > + }; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95923C433F5 for ; Thu, 28 Apr 2022 06:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W0hczb8EHcOFATN57LJFEwMZ90c9zbDv7RUBeWiDr8A=; b=2ZM2EK1UmKqBlo AeIqAgDeJABG/0AR3t2JT35SQ4qjCwE5jAia1v0qRIsT0/IlgkkKLjVc2/N5afiAHGgE3/QG+S1dF Xv4lEraa2t/6nRf2iH8CRbwwFUY59BD2/CrCHe0SOO/g9rQSMBWN3Re4rDZnlS/wLwCNsCUPd01V+ uKA/JBVvOR32WdEhvvhPKkxVqlhpIVLLc7lfbhBF+sA/M3kpHxdOIdQilB8fqMjj6UAqNX2VRUqbd Gg4f6SfEW0WTqKZOyaT3hT9/Tx0SOQ5nAW819+VOyFxKe9fPXqPervvkSNCnxENq0DaBZZV6Zq56v dxYj0xJxpFoB2RsjQe/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njxiC-004us9-Ob; Thu, 28 Apr 2022 06:33:12 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njxi9-004urO-5u for linux-rockchip@lists.infradead.org; Thu, 28 Apr 2022 06:33:10 +0000 Received: by mail-ed1-x529.google.com with SMTP id d6so4342164ede.8 for ; Wed, 27 Apr 2022 23:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=uxezT5LnyHKSBkq6AQW89pc3qDtfxZHYMAix0t8fNa7iN8SiPU1Ilsl1nM1G37M5R+ +iu92f1x/5vR1NTnqi8ROX0/LwJwdGKQmoBkn8pixlB6fKZyo7GpO6a7YYkK1pW1jNQT wNHmkFGVSfRqXb8sEShA2W6HoHm5NLbFl5Spems7FPFI6zXPRgGCACekKLjBWUJQMl4E 73ek80xKQJ1KRfH67Egat8mV375c+FUSf/cJw5OVhhrlizX0esnpjiAi8Erb1aORY0vE o3rPGR9G86LWNf4VY5otQY/Gm6CzHNWFv8J3C1ofMgFmk3ptIhJGQ5VBAyLp82amwWr1 6tbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=SO00f1L8TllyJkuXiiRlUTMUKZW9fv8FR461APptW31H69IITiklzutjbs8tgDi5af Mzho3mVAzcangFdZ6htUxijhgShzynoFwpS+Tp0NG/NUeO1+SUBgXpu/GSibWajDF5tV yFhivUNFFY8bnNkqUpH8vx9r4ncxw4GI16qZppCwd+Ndl5bhBydC0qOaTyxdHIvbP2gq NK6UJv6f0Bb5PMh5LczMdMscuTiTZ6y0m+ZLcsYzvdS6dpADkYlwMUniuxcy2IV3YMM5 geTrJd4//m9IJnGQecq1qGKuMK7aTEJnn1hpbezdfzkmLlHV+vWrB0BnLezQLIXsLWjM a0BA== X-Gm-Message-State: AOAM530Bs+A9UGk/gusHrt/r1IY7rsmUguhwo7lQVjdYMZXbFUGH85HK OrNTBXkh00XN1e7i9ejD9I/EBw== X-Google-Smtp-Source: ABdhPJw0+ayf81Ms9n+w6fNeDibHnLry7oeKKqMj4gZt2cgaTDG/qOgtHFpuAxQnWZ5n0HmQ9WFJHA== X-Received: by 2002:a05:6402:43cc:b0:425:fda3:ac3a with SMTP id p12-20020a05640243cc00b00425fda3ac3amr12162862edc.70.1651127587742; Wed, 27 Apr 2022 23:33:07 -0700 (PDT) Received: from [192.168.0.159] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i23-20020a0564020f1700b0042617ba6382sm943988eda.12.2022.04.27.23.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:33:06 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 08:33:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC/RFT v2 01/11] dt-bindings: phy: rockchip: add PCIe v3 phy Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20220426132139.26761-1-linux@fw-web.de> <20220426132139.26761-2-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220426132139.26761-2-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_233309_273918_C9F021A2 X-CRM114-Status: GOOD ( 20.78 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 26/04/2022 15:21, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > new file mode 100644 > index 000000000000..3592888b5ee2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip PCIe v3 phy > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3568-pcie3-phy > + - rockchip,rk3588-pcie3-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + items: > + - const: "refclk_m" > + - const: "refclk_n" > + - const: "pclk" Drop quotes. > + > + minItems: 1 I think we agreed to skip rk3588 or make the number of clocks strict? > + > + "#phy-cells": > + const: 0 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: phy > + > + rockchip,phy-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the phy "general register files" > + > + rockchip,pipe-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the pipe "general register files" > + > + rockchip,pcie30-phymode: > + $ref: '/schemas/types.yaml#/definitions/uint32' No need for quotes. You don't use it in other places. > + description: | > + set the phy-mode for enabling bifurcation > + bit0: bifurcation for port 0 > + bit1: bifurcation for port 1 > + bit2: aggregation > + constants are defined in the dt-bindings/phy/phy-rockchip-pcie3.h Full path. It should also follow vendor,device naming convention. > + minimum: 0x0 > + maximum: 0x4 > + default: 0x4 > + > +required: > + - compatible > + - reg > + - rockchip,phy-grf > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + pcie30phy: phy@fe8c0000 { > + compatible = "rockchip,rk3568-pcie3-phy"; > + reg = <0x0 0xfe8c0000 0x0 0x20000>; > + #phy-cells = <0>; > + clocks = <&pmucru CLK_PCIE30PHY_REF_M>, > + <&pmucru CLK_PCIE30PHY_REF_N>, > + <&cru PCLK_PCIE30PHY>; > + clock-names = "refclk_m", "refclk_n", "pclk"; > + resets = <&cru SRST_PCIE30PHY>; > + reset-names = "phy"; > + rockchip,phy-grf = <&pcie30_phy_grf>; > + }; Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F078FC433EF for ; Thu, 28 Apr 2022 06:33:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x82oR7ddVM5U5q9UDwLAEb3LuCuURNqqw28MIPXu78I=; b=hRA/5xWPjA6aXC bHV2v58xCH3QnAHZFgh/sY3F7XYi/quR2R5ys79rkJyWTHLTrBXpYcWhfzucdDmGCbP/yuJ+2Af4t mYNRqKZO+7wjqaKBxggyfho0T8PI0OdCVIko6tac90zapFrCS6WfHLIRt2Cz+FiicoCivlEV2gb2m YAMmjySBbjFfq6IW7RV/TyZezNFw+ZxQFDsr2zvwSL8Mz2qT2u847b9i7tyhXjDW9rXoUNEqhP+Xm 4448caqgwWxD0HKYH84cBMZX1c7Misa7mc3AxKsCD35d9LCk74ZFeMXFEQchZt7ap/SDCdy6mydVv TLK2ylXgpf4BIVFEM8Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njxiJ-004uuq-Be; Thu, 28 Apr 2022 06:33:19 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njxiG-004urN-Gv for linux-phy@lists.infradead.org; Thu, 28 Apr 2022 06:33:18 +0000 Received: by mail-ed1-x52e.google.com with SMTP id g20so4344494edw.6 for ; Wed, 27 Apr 2022 23:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=uxezT5LnyHKSBkq6AQW89pc3qDtfxZHYMAix0t8fNa7iN8SiPU1Ilsl1nM1G37M5R+ +iu92f1x/5vR1NTnqi8ROX0/LwJwdGKQmoBkn8pixlB6fKZyo7GpO6a7YYkK1pW1jNQT wNHmkFGVSfRqXb8sEShA2W6HoHm5NLbFl5Spems7FPFI6zXPRgGCACekKLjBWUJQMl4E 73ek80xKQJ1KRfH67Egat8mV375c+FUSf/cJw5OVhhrlizX0esnpjiAi8Erb1aORY0vE o3rPGR9G86LWNf4VY5otQY/Gm6CzHNWFv8J3C1ofMgFmk3ptIhJGQ5VBAyLp82amwWr1 6tbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=QpI/NVzS02ifgCLr5C0LEF3RlXVwTCXSn7lXlK0Pf2Yqu93OG6vbBG6Cm5CMAq6gfN gKVy9R75vyd6rClGMAt0PQZ6tgx8f87vUwDYNaXd0Ew7QZyv7Tq9vLOLVYT83Eh/4vtC ATwcWSKnnEu7mSYqlYakPHuJwI33PPlz52GbMIcw/JnxzP08z9ZgqFspUcWr32ktfXA5 8vXvVNO9Tvb1WNuDecjA7pw/2rtiJRye/BsNMXDtuMMNgHKsmyWb9rGhW2FIYQ8e3Tja 7PU1NkatOVZDfShfsVndFCv795wDAVjbnlTRsIdO1NbxBWryPSxLasQvR7MsW47YYssp sAzQ== X-Gm-Message-State: AOAM533T6EoDxO6AMJwibm46WJWFaxxbj/jngACRARiRiIx81QJGnoQ6 Kml8lEFaollHHPcDEoDmqrvRkw== X-Google-Smtp-Source: ABdhPJw0+ayf81Ms9n+w6fNeDibHnLry7oeKKqMj4gZt2cgaTDG/qOgtHFpuAxQnWZ5n0HmQ9WFJHA== X-Received: by 2002:a05:6402:43cc:b0:425:fda3:ac3a with SMTP id p12-20020a05640243cc00b00425fda3ac3amr12162862edc.70.1651127587742; Wed, 27 Apr 2022 23:33:07 -0700 (PDT) Received: from [192.168.0.159] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i23-20020a0564020f1700b0042617ba6382sm943988eda.12.2022.04.27.23.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:33:06 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 08:33:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC/RFT v2 01/11] dt-bindings: phy: rockchip: add PCIe v3 phy Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20220426132139.26761-1-linux@fw-web.de> <20220426132139.26761-2-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220426132139.26761-2-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_233316_629576_110669A2 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 26/04/2022 15:21, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > new file mode 100644 > index 000000000000..3592888b5ee2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip PCIe v3 phy > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3568-pcie3-phy > + - rockchip,rk3588-pcie3-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + items: > + - const: "refclk_m" > + - const: "refclk_n" > + - const: "pclk" Drop quotes. > + > + minItems: 1 I think we agreed to skip rk3588 or make the number of clocks strict? > + > + "#phy-cells": > + const: 0 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: phy > + > + rockchip,phy-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the phy "general register files" > + > + rockchip,pipe-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the pipe "general register files" > + > + rockchip,pcie30-phymode: > + $ref: '/schemas/types.yaml#/definitions/uint32' No need for quotes. You don't use it in other places. > + description: | > + set the phy-mode for enabling bifurcation > + bit0: bifurcation for port 0 > + bit1: bifurcation for port 1 > + bit2: aggregation > + constants are defined in the dt-bindings/phy/phy-rockchip-pcie3.h Full path. It should also follow vendor,device naming convention. > + minimum: 0x0 > + maximum: 0x4 > + default: 0x4 > + > +required: > + - compatible > + - reg > + - rockchip,phy-grf > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + pcie30phy: phy@fe8c0000 { > + compatible = "rockchip,rk3568-pcie3-phy"; > + reg = <0x0 0xfe8c0000 0x0 0x20000>; > + #phy-cells = <0>; > + clocks = <&pmucru CLK_PCIE30PHY_REF_M>, > + <&pmucru CLK_PCIE30PHY_REF_N>, > + <&cru PCLK_PCIE30PHY>; > + clock-names = "refclk_m", "refclk_n", "pclk"; > + resets = <&cru SRST_PCIE30PHY>; > + reset-names = "phy"; > + rockchip,phy-grf = <&pcie30_phy_grf>; > + }; Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D602C433EF for ; Thu, 28 Apr 2022 06:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4g9bTzqHf7jZREgK4gEdsG2FP673QGkSGo3CuW0sdpY=; b=Zo/HN/5SV34m+R QoB4FvyUeD7H6d0/LoWnJZpP0Zj3iWNYTKKL/KXhGppF7Bf5FQMRSrRWkBD1ZFzT1ASzjY1CtMVir uY8vY93MV085LMhCLuDCOCoZC736K3TBAaAMvaZdLKC6qYZ7VBEweDfMxolC9pdb1ACrO6FI5OiVm Qjfuv6RNIfbdM9RDr9g4Ap/h8pPx8IlFOMA0fW1OrlU5GXMSFBKc//X4p9w8p7IZ3vkVE64xVlk+6 MNP+wOk8Nv7+gBKzbcHMi+p9IPWHj49Qrdl68EKLUVGjcCexO9TZpLzfsmh3Ssyli724wEsiNeR6n WoaxFC+S850zRuQNN1Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njxiM-004uvi-9u; Thu, 28 Apr 2022 06:33:22 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njxiH-004urP-Ri for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 06:33:19 +0000 Received: by mail-ed1-x52f.google.com with SMTP id a21so4366274edb.1 for ; Wed, 27 Apr 2022 23:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=uxezT5LnyHKSBkq6AQW89pc3qDtfxZHYMAix0t8fNa7iN8SiPU1Ilsl1nM1G37M5R+ +iu92f1x/5vR1NTnqi8ROX0/LwJwdGKQmoBkn8pixlB6fKZyo7GpO6a7YYkK1pW1jNQT wNHmkFGVSfRqXb8sEShA2W6HoHm5NLbFl5Spems7FPFI6zXPRgGCACekKLjBWUJQMl4E 73ek80xKQJ1KRfH67Egat8mV375c+FUSf/cJw5OVhhrlizX0esnpjiAi8Erb1aORY0vE o3rPGR9G86LWNf4VY5otQY/Gm6CzHNWFv8J3C1ofMgFmk3ptIhJGQ5VBAyLp82amwWr1 6tbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZGNUaKvmhdWADegA9+35rNWReEdvm/VLEsDmu8SXlcI=; b=8CMdHDAh94jt978zi3tE0K31O60+u/wxOHaRfDQQHWUAAka/f/15U746bDYn2LrOLt 9A6H7zKfT45oXhRYja83QCHQWsBSQeOleISVqVukosyehGhs1S9nKb/OjjgzDOAS04FS CVFB8woSSJWM5jCVc0GR3jx7R08no1iEzzjE3n1WGgU1ZZegeIOSfVI7NYR4Q0u+0q9i eODNHnRB2Ldxu4hG5pH48m9pH22QSe41WjPX+zV69bn3deTnNhBGDBz44CbbmOX6QwdB SuUh1k2vr2nHF1V+XXwSNFLDne29tLP1vuP5t4/sYqJ+ODCDX4lNQNf+XeWrim6W30gV Qb6w== X-Gm-Message-State: AOAM531FtyCYk5HcdQ3h9UVnvVKejwyInwdVBJ3vXuE0DCMngwAG9z6W TG+HoyuYMdswE4Zcmea5ysMWqg== X-Google-Smtp-Source: ABdhPJw0+ayf81Ms9n+w6fNeDibHnLry7oeKKqMj4gZt2cgaTDG/qOgtHFpuAxQnWZ5n0HmQ9WFJHA== X-Received: by 2002:a05:6402:43cc:b0:425:fda3:ac3a with SMTP id p12-20020a05640243cc00b00425fda3ac3amr12162862edc.70.1651127587742; Wed, 27 Apr 2022 23:33:07 -0700 (PDT) Received: from [192.168.0.159] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id i23-20020a0564020f1700b0042617ba6382sm943988eda.12.2022.04.27.23.33.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 23:33:06 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 08:33:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC/RFT v2 01/11] dt-bindings: phy: rockchip: add PCIe v3 phy Content-Language: en-US To: Frank Wunderlich , linux-rockchip@lists.infradead.org Cc: Frank Wunderlich , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Kishon Vijay Abraham I , Vinod Koul , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Philipp Zabel , Johan Jonker , Peter Geis , Michael Riesch , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org References: <20220426132139.26761-1-linux@fw-web.de> <20220426132139.26761-2-linux@fw-web.de> From: Krzysztof Kozlowski In-Reply-To: <20220426132139.26761-2-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220427_233317_923228_CBA056EB X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/04/2022 15:21, Frank Wunderlich wrote: > From: Frank Wunderlich > > Add a new binding file for Rockchip PCIe v3 phy driver. > > Signed-off-by: Frank Wunderlich > > --- > v2: > dt-bindings: rename yaml for PCIe v3 > rockchip-pcie3-phy.yaml => rockchip,pcie3-phy.yaml > > changes in pcie3 phy yaml > - change clock names to ordered const list > - extend pcie30-phymode description > - add phy-cells to required properties > - drop unevaluatedProperties > - example with 1 clock each line > - use default property instead of text describing it > - update license > --- > .../bindings/phy/rockchip,pcie3-phy.yaml | 84 +++++++++++++++++++ > 1 file changed, 84 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > new file mode 100644 > index 000000000000..3592888b5ee2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/rockchip,pcie3-phy.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip PCIe v3 phy > + > +maintainers: > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3568-pcie3-phy > + - rockchip,rk3588-pcie3-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 1 > + maxItems: 3 > + > + clock-names: > + items: > + - const: "refclk_m" > + - const: "refclk_n" > + - const: "pclk" Drop quotes. > + > + minItems: 1 I think we agreed to skip rk3588 or make the number of clocks strict? > + > + "#phy-cells": > + const: 0 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: phy > + > + rockchip,phy-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the phy "general register files" > + > + rockchip,pipe-grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the syscon managing the pipe "general register files" > + > + rockchip,pcie30-phymode: > + $ref: '/schemas/types.yaml#/definitions/uint32' No need for quotes. You don't use it in other places. > + description: | > + set the phy-mode for enabling bifurcation > + bit0: bifurcation for port 0 > + bit1: bifurcation for port 1 > + bit2: aggregation > + constants are defined in the dt-bindings/phy/phy-rockchip-pcie3.h Full path. It should also follow vendor,device naming convention. > + minimum: 0x0 > + maximum: 0x4 > + default: 0x4 > + > +required: > + - compatible > + - reg > + - rockchip,phy-grf > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + pcie30phy: phy@fe8c0000 { > + compatible = "rockchip,rk3568-pcie3-phy"; > + reg = <0x0 0xfe8c0000 0x0 0x20000>; > + #phy-cells = <0>; > + clocks = <&pmucru CLK_PCIE30PHY_REF_M>, > + <&pmucru CLK_PCIE30PHY_REF_N>, > + <&cru PCLK_PCIE30PHY>; > + clock-names = "refclk_m", "refclk_n", "pclk"; > + resets = <&cru SRST_PCIE30PHY>; > + reset-names = "phy"; > + rockchip,phy-grf = <&pcie30_phy_grf>; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel