From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DAFC4361B for ; Tue, 15 Dec 2020 14:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEC3D224D2 for ; Tue, 15 Dec 2020 14:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbgLOOGc (ORCPT ); Tue, 15 Dec 2020 09:06:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726475AbgLOOGS (ORCPT ); Tue, 15 Dec 2020 09:06:18 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C0FC0617A6 for ; Tue, 15 Dec 2020 06:05:38 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id s75so23420922oih.1 for ; Tue, 15 Dec 2020 06:05:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VSRvCLif/VkHTYroZqEOAGuvTQPetTsTqUTNTy/jVkM=; b=jrjvLjX2n581qSAqun5wgJAuTyM2sX/yweYKkNiZNP4ZXeXZ5ZxJ0WEdfTrKCYNlTl MACsREBonOcktvmQhuOIIvIA4bg7IdbmIqwGqX0Iz41NIkhWgvJphs9G5dfsc2H0WWMS ZLiJqGSA695Q/P0mLYohhsiPNUfjdyTg7bXwBkI++0qyPNM7SiXtOuDPq6pfvDTptmD5 vqotmogVwyH1mVqe149MBv6EAzxysWPg5AjbwMxZ2QDHDNZUonEbnHtCUI/+KZiSD+mm +bEKUzflQlrT/83+LtzMqdD1Xfa+QXBIrBh9QGw40kDaaOYb8yFYgmgqyxhy60Fq7U2Z DsQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VSRvCLif/VkHTYroZqEOAGuvTQPetTsTqUTNTy/jVkM=; b=Qec3kD+4ceyPQoInjnyy7T8n2YEMQAnXFbutXKBug0TNbIQrhGcmZuEQoDIKW6MA0o Z6oy4eKNRld6BnImT4xQniAQoqMBI8wIx7/JHoXyoBvJfD8oqMEQqn7MdoIq5GNZkOn2 bn6tKL4gSpr1FR3CtN1m83zMq9fLlUAvXmc3sdEbeHeahfyYytBdSauw9WQfzHzxC+1e GKgBicUblIowJaqUqQtppr5X+dy4vvSTPl3+tD3bDJV7FgZJ1vBbou0LeYYODAkM+C3h tknaEiHcWC8ipIUj4kaHufbZlseEWAFJ6PJ0AozSuj/fUsAxcDGRxiLSjI72kJwsQsMO tqLQ== X-Gm-Message-State: AOAM533clskUVKPGWXqoKzVD7SWpLmVW5gzagP4wpCAHXnejxPvPxFft kRfG+XxirLycQnPPUFiqhnAkjQ== X-Google-Smtp-Source: ABdhPJxarFw7t8qWVR5d6DyLSUnCvKtPx9VtvA9+047G+Poi4o/XHjpYAX40w4SXIuYyrMQvWd87nw== X-Received: by 2002:aca:61c5:: with SMTP id v188mr21574182oib.66.1608041138156; Tue, 15 Dec 2020 06:05:38 -0800 (PST) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id 8sm438153otq.18.2020.12.15.06.05.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 06:05:37 -0800 (PST) Subject: Re: [PATCH v2 03/16] target/mips: Add !CONFIG_USER_ONLY comment after #endif To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Aleksandar Rikalo , kvm@vger.kernel.org, Huacai Chen , Laurent Vivier , Jiaxun Yang , Paolo Bonzini , Aurelien Jarno References: <20201214183739.500368-1-f4bug@amsat.org> <20201214183739.500368-4-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Tue, 15 Dec 2020 08:05:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201214183739.500368-4-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 12/14/20 12:37 PM, Philippe Mathieu-Daudé wrote: > To help understand ifdef'ry, add comment after #endif. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/helper.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~