From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Fri, 8 May 2020 20:33:55 +0200
Subject: [PATCH v3 7/7] configs: evb-rk3399: update support usb3.0 host
In-Reply-To: <CAMty3ZCX8mTDKEQ+7HMr3w92pGyMZUUU-viSGtWbSjj4nC3hsQ@mail.gmail.com>
References: <20200507081213.16107-1-frank.wang@rock-chips.com>
 <20200507081333.16269-1-frank.wang@rock-chips.com>
 <CAMty3ZATGWU49-8Y+a+=4SUE1jib_LxOhdEOmD9Woh0Oo4EtOg@mail.gmail.com>
 <dc7c4c61-ba3f-7c74-0739-6472b9bd5a7d@denx.de>
 <CAMty3ZCX8mTDKEQ+7HMr3w92pGyMZUUU-viSGtWbSjj4nC3hsQ@mail.gmail.com>
Message-ID: <f005c4fc-b128-fa37-2233-0f8ec6d6a9a0@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 5/8/20 7:46 PM, Jagan Teki wrote:
> On Fri, May 8, 2020 at 11:13 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 5/8/20 7:24 PM, Jagan Teki wrote:
>>> On Thu, May 7, 2020 at 1:43 PM Frank Wang <frank.wang@rock-chips.com> wrote:
>>>>
>>>> Update evb-rk3399 default config to support USB3.0 Host.
>>>>
>>>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
>>>> ---
>>>> Changes for v3:
>>>> - select more config to support USB3.0 host.
>>>>
>>>>  configs/evb-rk3399_defconfig | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
>>>> index 7f14e18b1b..6cfb4e5dac 100644
>>>> --- a/configs/evb-rk3399_defconfig
>>>> +++ b/configs/evb-rk3399_defconfig
>>>> @@ -28,6 +28,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>>>  CONFIG_NET_RANDOM_ETHADDR=y
>>>>  CONFIG_ROCKCHIP_GPIO=y
>>>>  CONFIG_SYS_I2C_ROCKCHIP=y
>>>> +CONFIG_MISC=y
>>>>  CONFIG_MMC_DW=y
>>>>  CONFIG_MMC_SDHCI=y
>>>>  CONFIG_MMC_SDHCI_ROCKCHIP=y
>>>> @@ -35,10 +36,13 @@ CONFIG_SF_DEFAULT_SPEED=20000000
>>>>  CONFIG_DM_ETH=y
>>>>  CONFIG_ETH_DESIGNWARE=y
>>>>  CONFIG_GMAC_ROCKCHIP=y
>>>> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
>>>> +CONFIG_PHY_ROCKCHIP_TYPEC=y
>>>>  CONFIG_PMIC_RK8XX=y
>>>>  CONFIG_REGULATOR_PWM=y
>>>>  CONFIG_REGULATOR_RK8XX=y
>>>>  CONFIG_PWM_ROCKCHIP=y
>>>> +CONFIG_DM_RESET=y
>>>>  CONFIG_DM_RNG=y
>>>>  CONFIG_RNG_ROCKCHIP=y
>>>>  CONFIG_BAUDRATE=1500000
>>>> @@ -49,6 +53,8 @@ CONFIG_USB_XHCI_HCD=y
>>>>  CONFIG_USB_XHCI_DWC3=y
>>>>  CONFIG_USB_EHCI_HCD=y
>>>>  CONFIG_USB_EHCI_GENERIC=y
>>>> +CONFIG_USB_DWC3=y
>>>> +CONFIG_USB_DWC3_GENERIC=y
>>>
>>> We need to enable OF_LIVE otherwise phy_type would be 0 but the actual
>>> one is 0x2 (utmi_wide).  For phy_type 0 device cannot respond to the
>>> set address.
>>>
>>> scanning bus dwc3 for devices... Device not responding to set address.
>>>       USB device not accepting new address (error=80000000)
>>> 1 USB Device(s) found
>>>        scanning usb for storage devices... 0 Storage Device(s) found
>>
>> How is OF_LIVE related to setting the phy width ?
> 
> One of Frank patch [1] get the phy_type with OF_LIVE build depending.
> 
> [1] https://patchwork.ozlabs.org/project/uboot/patch/20200507081213.16107-4-frank.wang at rock-chips.com/

Maybe that needs to be fixed, to work even without OF_LIVE ?