From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH 1/4] mptcp: disable mptcp when md5sig is set on socket
Date: Mon, 11 Nov 2019 18:06:08 +0100 [thread overview]
Message-ID: <f00e2244dce7dd17b11fb204340537b172814065.camel@redhat.com> (raw)
In-Reply-To: cover.1573488686.git.pabeni@redhat.com
[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]
On Mon, 2019-11-11 at 17:53 +0100, Paolo Abeni wrote:
> As per last public mtg discussion, md5sig will cause TCP option space
> exaustion. Without md5sig we can't exhaust the TCP option space.
>
> This series explcitly disable MPTCP when md5sig is set, and cleanup
> later option len checks with the assumption that TCP option space exhaustion
> is not expected - add a single WARN_ON() for that.
>
> Paolo Abeni (1):
> mptcp: move mp_capable initialization at subflow_init_req() start
> mptcp: disable on req sk if MD5SIG is enabled
> mptcp: warn once if exceeding tcp opt space for dss/mp_capable
> mptcp: remove unneeded check in mptcp_established_options_mp()
>
> net/mptcp/subflow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Addenda:
- I dumbly edited this series manually and ended-up with the wrong
prefix on this cover letter [PATCH 1/4] instead of [PATCH 0/4], I'm
sorry.
- the selftests run successful on a build from the patched git
tree@"mptcp: add basic kselftest for mptcp".
- I'm wondering about adding an explicit self-test vs md5sig - easier
way would be checking the MIB counters after the transfer completes
successfully.
/P
next reply other threads:[~2019-11-11 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 17:06 Paolo Abeni [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-11 17:09 [MPTCP] Re: [PATCH 1/4] mptcp: disable mptcp when md5sig is set on socket Paolo Abeni
2019-11-11 16:58 Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f00e2244dce7dd17b11fb204340537b172814065.camel@redhat.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.