From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14F14C433F5 for ; Thu, 17 Mar 2022 19:03:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A810241837; Thu, 17 Mar 2022 19:03:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sNDERbk9ZL7u; Thu, 17 Mar 2022 19:03:00 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 9C9894013A; Thu, 17 Mar 2022 19:02:59 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id ADC271BF349 for ; Thu, 17 Mar 2022 19:02:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 99880841F8 for ; Thu, 17 Mar 2022 19:02:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0CdqJcPMT2WH for ; Thu, 17 Mar 2022 19:02:57 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.grinn-global.com (mail.grinn-global.com [77.55.128.204]) by smtp1.osuosl.org (Postfix) with ESMTPS id 531D5841B5 for ; Thu, 17 Mar 2022 19:02:57 +0000 (UTC) X-Virus-Scanned: by amavisd-new using ClamAV (28) Received: from [192.168.10.50] (dynamic-78-10-107-45.ssp.dialog.net.pl [78.10.107.45]) by server220076.nazwa.pl (Postfix) with ESMTP id 956B01BD099; Thu, 17 Mar 2022 20:02:54 +0100 (CET) Message-ID: Date: Thu, 17 Mar 2022 20:02:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: "Sassen, Rutger" References: From: Bartosz Bilas In-Reply-To: Subject: Re: [Buildroot] [PATCH v3 1/1] package/rpi-firmware: fix missing files in overlays X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Seiderer , "buildroot@buildroot.org" , Martin Bark , Mahyar Koshkouei Content-Type: multipart/mixed; boundary="===============6433884518933589291==" Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" This is a multi-part message in MIME format. --===============6433884518933589291== Content-Type: multipart/alternative; boundary="------------aTeM9SLAo9a0nnfXA5eX08pW" Content-Language: en-US This is a multi-part message in MIME format. --------------aTeM9SLAo9a0nnfXA5eX08pW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello, On 17.03.2022 12:06, Sassen, Rutger wrote: > When supporting multiple hardware targets, overlay_map.dtb might > be needed to map overlay names to one of several implementations. > > Signed-off-by: Rutger Sassen > --- > Changes v2 -> v3: > - in Config.in use if statement instead of depends (suggested by Peter > Seiderer) > - mention the filename overlay_map.dtb in the help text (suggested by > Peter Seiderer) > > Changes v1 -> v2: > - instead of always copying overlay_map.dtb, make it configurable > (suggested by Peter Seiderer) > - do not copy README since it a special case, only needed when > installing overlays to a non-standard location (suggested by Peter > Seiderer) > > When supporting multiple hardware targets, overlay_map.dtb might > be needed to map overlay names to one of several implementations. > > Signed-off-by: Rutger Sassen > --- > package/rpi-firmware/Config.in | 12 ++++++++++++ > package/rpi-firmware/rpi-firmware.mk | 7 +++++++ > 2 files changed, 19 insertions(+) > > diff --git a/package/rpi-firmware/Config.in > b/package/rpi-firmware/Config.in > index 8070dc3019..36054353f8 100644 > --- a/package/rpi-firmware/Config.in > +++ b/package/rpi-firmware/Config.in > @@ -93,6 +93,18 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS > overlays, to support HATs (Hardware Attached on Top, add-on > modules). > > +if BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS > + > +config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP > + bool "Install DTB overlay map" > + default n bool symbols implicitly default to n. Best Bartek > + help > + Say 'y' here if you need to support multiple hardware targets > + and you need overlay_map.dtb for target dependent mapping of > + overlay names to one of several overlay implementations. > + > +endif # BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS > + > config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG > bool "vcdbg" > depends on BR2_arm # prebuilt arm binary, rpi-userland > diff --git a/package/rpi-firmware/rpi-firmware.mk > b/package/rpi-firmware/rpi-firmware.mk > index b46a7f5270..800b560070 100644 > --- a/package/rpi-firmware/rpi-firmware.mk > +++ b/package/rpi-firmware/rpi-firmware.mk > @@ -57,6 +57,12 @@ define RPI_FIRMWARE_INSTALL_DTB_OVERLAYS > endef > endif > > +ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP),y) > +define RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP > + $(INSTALL) -D -m 0644 $(@D)/boot/overlays/overlay_map.dtb > $(BINARIES_DIR)/rpi-firmware/overlays/ > +endef > +endif > + > # Install prebuilt libraries if RPI_USERLAND not enabled > ifneq ($(BR2_PACKAGE_RPI_USERLAND),y) > define RPI_FIRMWARE_INSTALL_TARGET_LIB > @@ -83,6 +89,7 @@ define RPI_FIRMWARE_INSTALL_IMAGES_CMDS > $(RPI_FIRMWARE_INSTALL_CONFIG) > $(RPI_FIRMWARE_INSTALL_DTB) > $(RPI_FIRMWARE_INSTALL_DTB_OVERLAYS) > + $(RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP) > endef > > $(eval $(generic-package)) > -- > 2.20.1 > > > *Disclaimer* > > This email communication is CONFIDENTIAL. If you are not the intended > recipient, you may not use, copy or disclose to anyone the message or > any information contained in the message and I ask that you please > notify me by return email and delete this communication immediately. > Thank you. > > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot --------------aTeM9SLAo9a0nnfXA5eX08pW Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hello,

On 17.03.2022 12:06, Sassen, Rutger wrote:
When supporting multiple hardware targets, overlay_map.dtb might
be needed to map overlay names to one of several implementations.

Signed-off-by: Rutger Sassen <rsassen@comecer.com>
---
Changes v2 -> v3:
- in Config.in use if statement instead of depends (suggested by Peter
Seiderer)
- mention the filename overlay_map.dtb in the help text (suggested by
Peter Seiderer)

Changes v1 -> v2:
- instead of always copying overlay_map.dtb, make it configurable
(suggested by Peter Seiderer)
- do not copy README since it a special case, only needed when
installing overlays to a non-standard location (suggested by Peter
Seiderer)

When supporting multiple hardware targets, overlay_map.dtb might
be needed to map overlay names to one of several implementations.

Signed-off-by: Rutger Sassen <rsassen@comecer.com>
---
package/rpi-firmware/Config.in | 12 ++++++++++++
package/rpi-firmware/rpi-firmware.mk | 7 +++++++
2 files changed, 19 insertions(+)

diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
index 8070dc3019..36054353f8 100644
--- a/package/rpi-firmware/Config.in
+++ b/package/rpi-firmware/Config.in
@@ -93,6 +93,18 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
overlays, to support HATs (Hardware Attached on Top, add-on
modules).

+if BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
+
+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP
+ bool "Install DTB overlay map"
+ default n

bool symbols implicitly default to n.

Best
Bartek
+ help
+ Say 'y' here if you need to support multiple hardware targets
+ and you need overlay_map.dtb for target dependent mapping of
+ overlay names to one of several overlay implementations.
+
+endif # BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
+
config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_VCDBG
bool "vcdbg"
depends on BR2_arm # prebuilt arm binary, rpi-userland
diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
index b46a7f5270..800b560070 100644
--- a/package/rpi-firmware/rpi-firmware.mk
+++ b/package/rpi-firmware/rpi-firmware.mk
@@ -57,6 +57,12 @@ define RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
endef
endif

+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP),y)
+define RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP
+ $(INSTALL) -D -m 0644 $(@D)/boot/overlays/overlay_map.dtb $(BINARIES_DIR)/rpi-firmware/overlays/
+endef
+endif
+
# Install prebuilt libraries if RPI_USERLAND not enabled
ifneq ($(BR2_PACKAGE_RPI_USERLAND),y)
define RPI_FIRMWARE_INSTALL_TARGET_LIB
@@ -83,6 +89,7 @@ define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
$(RPI_FIRMWARE_INSTALL_CONFIG)
$(RPI_FIRMWARE_INSTALL_DTB)
$(RPI_FIRMWARE_INSTALL_DTB_OVERLAYS)
+ $(RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP)
endef

$(eval $(generic-package))
--
2.20.1


Disclaimer

This email communication is CONFIDENTIAL. If you are not the intended recipient, you may not use, copy or disclose to anyone the message or any information contained in the message and I ask that you please notify me by return email and delete this communication immediately. Thank you.


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
--------------aTeM9SLAo9a0nnfXA5eX08pW-- --===============6433884518933589291== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot --===============6433884518933589291==--