Re: [dm-devel] [PATCH 4/9] multipath-tools: add NetApp E-Series NVMe to hardware table

From: Martin Wilck <mwilck@suse.com>
To: Xose Vazquez Perez <xose.vazquez@gmail.com>,
	"Schremmer, Steven" <Steve.Schremmer@netapp.com>
Cc: "George, Martin" <Martin.George@netapp.com>,
	Hannes Reinecke <hare@suse.com>,
	ng-eseries-upstream-maintainers
	<ng-eseries-upstream-maintainers@netapp.com>,
	DM-DEVEL ML <dm-devel@redhat.com>,
	Christophe Varoqui <christophe.varoqui@opensvc.com>
Subject: Re: [dm-devel] [PATCH 4/9] multipath-tools: add NetApp E-Series NVMe to hardware table
Date: Thu, 09 Jun 2022 19:00:48 +0200	[thread overview]
Message-ID: <f0179be809d54aeaaa13eb2edb320542d07d0513.camel@suse.com> (raw)
In-Reply-To: <7510d16e-b821-3030-16cf-ef39854109f5@gmail.com>

On Thu, 2022-06-09 at 18:56 +0200, Xose Vazquez Perez wrote:
> On 6/9/22 18:49, Martin Wilck wrote:
> 
> > IIUC NetApp's concern is not the generic entry, but the entries
> > mentioning E-Series or it's OEM products in NVMe configuration
> > explicitly. I also have some trouble understanding the concern, but
> > NetApp is in charge of these entries, so I believe we should
> > respect
> > what they're saying.
> > 
> > With the late patches I submitted, the generic NVMe defaults would
> > work
> > for the NetApp devices without those being explicitly mentioned. I
> > hope
> > this is ok for everyone. Only the no_path_retry setting would get
> > lost,
> > which is acceptable IMO because this is rather an admin setting
> > than
> > product-specific.
> 
> And now (IMO) it is worse, because NetApp NVMe arrays are under a
> generic config.
> 
> What do they hate?  just ".product = "NetApp E-Series"" ???

I can't speak for Steve, but yes, this is what I understood. The
concern is that someone would read the entry and conclude that this
configuration is officially endorsed and supported by NetApp.
This is why I added the disclaimer in the man page.

Regards,
Martin

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel