From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net] net: ipmr: fix unresolved entry dumps Date: Wed, 17 Oct 2018 22:35:32 +0300 Message-ID: References: <7e1a20a0-9ab2-5680-bde9-185c72242680@cumulusnetworks.com> <20181017193434.11383-1-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, Colin Ian King To: netdev@vger.kernel.org Return-path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:40566 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728122AbeJRDcq (ORCPT ); Wed, 17 Oct 2018 23:32:46 -0400 Received: by mail-wm1-f65.google.com with SMTP id z204-v6so3397831wmc.5 for ; Wed, 17 Oct 2018 12:35:34 -0700 (PDT) In-Reply-To: <20181017193434.11383-1-nikolay@cumulusnetworks.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 17/10/2018 22:34, Nikolay Aleksandrov wrote: > If the skb space ends in an unresolved entry while dumping we'll miss > some unresolved entries. The reason is due to zeroing the entry counter > between dumping resolved and unresolved mfc entries. We should just > keep counting until the whole table is dumped and zero when we move to > the next as we have a separate table counter. > > Reported-by: Colin Ian King > Fixes: 8fb472c09b9d ("ipmr: improve hash scalability") > Signed-off-by: Nikolay Aleksandrov > --- > Dropped Yuval's mail because it bounces. > > net/ipv4/ipmr_base.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/net/ipv4/ipmr_base.c b/net/ipv4/ipmr_base.c > index 1ad9aa62a97b..eab8cd5ec2f5 100644 > --- a/net/ipv4/ipmr_base.c > +++ b/net/ipv4/ipmr_base.c > @@ -296,8 +296,6 @@ int mr_rtm_dumproute(struct sk_buff *skb, struct netlink_callback *cb, > next_entry: > e++; > } > - e = 0; > - s_e = 0; > > spin_lock_bh(lock); > list_for_each_entry(mfc, &mrt->mfc_unres_queue, list) { > +CC Colin Sorry about that, my script somehow missed the reported-by email.