From: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
To: Randy Dunlap <rdunlap@infradead.org>,
David Howells <dhowells@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Masahiro Yamada <masahiroy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nathan Chancellor <nathan@kernel.org>,
Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Valentin Schneider <valentin.schneider@arm.com>,
Nick Terrell <terrelln@fb.com>, KP Singh <kpsingh@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
keyrings@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Jia Zhang <zhang.jia@linux.alibaba.com>
Subject: Re: [PATCH] init/Kconfig: Support sign module with SM3 hash algorithm
Date: Wed, 24 Mar 2021 17:27:06 +0800 [thread overview]
Message-ID: <f01f2b36-4978-1c8d-7b7b-f1f8fd49c6d1@linux.alibaba.com> (raw)
In-Reply-To: <28d3a339-6210-ffd2-950f-ea5340ac23b7@infradead.org>
Hi,
On 3/24/21 12:43 AM, Randy Dunlap wrote:
> On 3/23/21 1:35 AM, Tianjia Zhang wrote:
>> The kernel module signature supports the option to use the SM3
>> secure hash (OSCCA GM/T 0004-2012 SM3).
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>> ---
>> Documentation/admin-guide/module-signing.rst | 5 +++--
>> crypto/asymmetric_keys/pkcs7_parser.c | 7 +++++++
>> init/Kconfig | 5 +++++
>> 3 files changed, 15 insertions(+), 2 deletions(-)
>>
>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 5f5c776ef192..fed9236078e4 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -2202,6 +2202,10 @@ config MODULE_SIG_SHA512
>> bool "Sign modules with SHA-512"
>> select CRYPTO_SHA512
>>
>> +config MODULE_SIG_SM3
>> + bool "Sign modules with SM3"
>> + select CRYPTO_SM3
>> +
>> endchoice
>>
>> config MODULE_SIG_HASH
>> @@ -2212,6 +2216,7 @@ config MODULE_SIG_HASH
>> default "sha256" if MODULE_SIG_SHA256
>> default "sha384" if MODULE_SIG_SHA384
>> default "sha512" if MODULE_SIG_SHA512
>> + default "sm3" if MODULE_SIG_SM3
>>
>> config MODULE_COMPRESS
>> bool "Compress modules on installation"
>>
>
> checkpatch tells me:
>
> WARNING: please write a paragraph that describes the config symbol fully
> #74: FILE: init/Kconfig:2205:
> +config MODULE_SIG_SM3
>
>
> so yes, it should have some help text there.
>
> thanks.
>
I noticed, but this is just a list of algorithms, this warning can be
ignored.
Best regards,
Tianjia
next prev parent reply other threads:[~2021-03-24 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 8:35 [PATCH] init/Kconfig: Support sign module with SM3 hash algorithm Tianjia Zhang
2021-03-23 16:43 ` Randy Dunlap
2021-03-24 9:27 ` Tianjia Zhang [this message]
2021-03-23 22:14 ` Ard Biesheuvel
2021-03-24 9:31 ` Tianjia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01f2b36-4978-1c8d-7b7b-f1f8fd49c6d1@linux.alibaba.com \
--to=tianjia.zhang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=kpsingh@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=rdunlap@infradead.org \
--cc=terrelln@fb.com \
--cc=valentin.schneider@arm.com \
--cc=vbabka@suse.cz \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.