From: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, satya priya <skakit@codeaurora.org>,
David Collins <quic_collinsd@quicinc.com>
Subject: Re: [PATCH] spmi: pmic-arb: Add sid and address to error messages
Date: Mon, 20 Sep 2021 18:45:18 -0700 [thread overview]
Message-ID: <f03e37bd-0639-9548-fced-a4cb1c1a202f@codeaurora.org> (raw)
In-Reply-To: <20210920234849.3614036-1-swboyd@chromium.org>
On 9/20/21 4:48 PM, Stephen Boyd wrote:
> It's useful to know what particular device/component is having trouble
> accessing the bus. Add the sid and address to error messages here so
> that debugging is a little simpler.
>
> Cc: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> Cc: satya priya <skakit@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> ---
> drivers/spmi/spmi-pmic-arb.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
> index bbbd311eda03..e397c2532c8d 100644
> --- a/drivers/spmi/spmi-pmic-arb.c
> +++ b/drivers/spmi/spmi-pmic-arb.c
> @@ -261,20 +261,21 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
>
> if (status & PMIC_ARB_STATUS_DONE) {
> if (status & PMIC_ARB_STATUS_DENIED) {
> - dev_err(&ctrl->dev, "%s: transaction denied (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction denied (%#x)\n",
> + __func__, sid, addr, status);
> return -EPERM;
> }
>
> if (status & PMIC_ARB_STATUS_FAILURE) {
> - dev_err(&ctrl->dev, "%s: transaction failed (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction failed (%#x)\n",
> + __func__, sid, addr, status);
> + WARN_ON(1);
> return -EIO;
> }
>
> if (status & PMIC_ARB_STATUS_DROPPED) {
> - dev_err(&ctrl->dev, "%s: transaction dropped (0x%x)\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: transaction dropped (%#x)\n",
> + __func__, sid, addr, status);
> return -EIO;
> }
>
> @@ -283,8 +284,8 @@ static int pmic_arb_wait_for_done(struct spmi_controller *ctrl,
> udelay(1);
> }
>
> - dev_err(&ctrl->dev, "%s: timeout, status 0x%x\n",
> - __func__, status);
> + dev_err(&ctrl->dev, "%s: %#x %#x: timeout, status %#x\n",
> + __func__, sid, addr, status);
> return -ETIMEDOUT;
> }
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-09-21 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 23:48 [PATCH] spmi: pmic-arb: Add sid and address to error messages Stephen Boyd
2021-09-21 1:45 ` Subbaraman Narayanamurthy [this message]
2021-09-21 8:53 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f03e37bd-0639-9548-fced-a4cb1c1a202f@codeaurora.org \
--to=subbaram@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_collinsd@quicinc.com \
--cc=sboyd@kernel.org \
--cc=skakit@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.