From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1564AC3F68F for ; Fri, 27 Dec 2019 05:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC037208C4 for ; Fri, 27 Dec 2019 05:09:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726169AbfL0FJR (ORCPT ); Fri, 27 Dec 2019 00:09:17 -0500 Received: from mga12.intel.com ([192.55.52.136]:37820 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfL0FJQ (ORCPT ); Fri, 27 Dec 2019 00:09:16 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2019 21:09:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,361,1571727600"; d="scan'208";a="220420469" Received: from psklarow-mobl.ger.corp.intel.com ([10.252.31.109]) by orsmga003.jf.intel.com with ESMTP; 26 Dec 2019 21:09:12 -0800 Message-ID: Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init From: Jarkko Sakkinen To: Jerry Snitselaar , Dan Williams Cc: Linux Kernel Mailing List , Christian Bundy , Peter Huewe , Jason Gunthorpe , Stefan Berger , stable , linux-integrity@vger.kernel.org Date: Fri, 27 Dec 2019 07:09:06 +0200 In-Reply-To: <20191219100747.fhbqmzk7xby3tt3l@cantor> References: <20191211231758.22263-1-jsnitsel@redhat.com> <20191211235455.24424-1-jsnitsel@redhat.com> <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> <20191217020022.knh7uxt4pn77wk5m@cantor> <5d0763334def7d7ae1e7cf931ef9b14184dce238.camel@linux.intel.com> <20191217171844.huqlj5csr262zkkk@cantor> <37f4ed0d6145dbe1e8724a5d05d0da82b593bf9c.camel@linux.intel.com> <20191219100747.fhbqmzk7xby3tt3l@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-12-19 at 03:07 -0700, Jerry Snitselaar wrote: > > These patches take a usable system and make it unusable: > > > > 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts > > 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's > > > > ...they need to be reverted, or the regression needs to be fixed, but > > asserting that you fixed something else unrelated does not help. > > > > Reverting 1ea32c83c699 ("tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before > probing for interrupts") would at least allow people impacted by this > to boot their systems without disabling the tpm, or blacklisting the > module while we figure this out. From what I can tell the tpm_tis code > was operating in that state since 570a36097f30 ("tpm: drop 'irq' from > struct tpm_vendor_specific") until Stefan's patch. I'll formalize a fix based on the reverts. Sorry for the holiday latency. /Jarkko