Re: [PATCH] ASoC: Intel: Boards: Add CNL RT274 I2S machine driver

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 11/28/2017 10:24 AM, Vinod Koul wrote:
> On Mon, Nov 27, 2017 at 08:45:16AM -0600, Pierre-Louis Bossart wrote:
>> On 11/27/17 6:44 AM, Guneshwor Singh wrote:
>>> Add CNL I2S machine driver using Realtek RT274 codec in I2S mode
>>> configured to ssp0.
>>>
>>> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
>>> ---
>>>   sound/soc/intel/boards/Kconfig     |  13 ++
>>>   sound/soc/intel/boards/Makefile    |   2 +
>>>   sound/soc/intel/boards/cnl_rt274.c | 250 +++++++++++++++++++++++++++++++++++++
>>>   3 files changed, 265 insertions(+)
>>>   create mode 100644 sound/soc/intel/boards/cnl_rt274.c
>>>
>>> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
>>> index 6f754708a48c..29066f0b744f 100644
>>> --- a/sound/soc/intel/boards/Kconfig
>>> +++ b/sound/soc/intel/boards/Kconfig
>>> @@ -262,4 +262,17 @@ config SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH
>>>             Say Y if you have such a device.
>>>             If unsure select "N".
>>> +config SND_SOC_INTEL_CNL_RT274_MACH
>>> +	tristate "ASoC Audio driver for Cannonlake with RT274 I2S mode"
>>> +	depends on X86 && ACPI && I2C
>>> +	select SND_SOC_INTEL_SST
>>> +	depends on SND_SOC_INTEL_SKYLAKE
>> this is going to conflict with the fixes I am working on.
>> Vinod, can this wait a bit?
> Hey Pierre,
>
> Since you are still working on the fixes, I guess this can sneak in before.
> The machine drivers are typically low hanging in terms on complexity so we
> can merge this first followed by the rework you are doing. I think that part
> will still take a bit to stabilize and cleanup.
the update goes out this afternoon, working on it, does this patch 
really need to 'sneak in'?

>