From: Changqing Li <changqing.li@windriver.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] cogl: fix compile error with -Werror=maybe-uninitialized
Date: Mon, 8 Apr 2019 10:12:03 +0800 [thread overview]
Message-ID: <f044d899-2ad8-459c-cecc-1324a4cbc9d8@windriver.com> (raw)
In-Reply-To: <20190404081128.GB13624@localhost>
On 4/4/19 4:11 PM, Adrian Bunk wrote:
> On Thu, Apr 04, 2019 at 10:06:44AM +0800, Changqing Li wrote:
>> ...
>> And also upstream have use same way to fix under
>> cogl/driver/gl/gl/cogl-driver-gl.c
>>
>> https://gitlab.gnome.org/GNOME/cogl/commit/ca5226513eb64bceb38ca01994799c4e7cd9f5fa
> Have they?
>
> This looks like a 4 year old commit that was never merged.
Seems it merged to 1.22 branch, I can see it switch to tag 1.22.2, but
indeed, it not merge to master.
and this change also include in
http://ftp.gnome.org/pub/GNOME/sources/cogl/1.22/cogl-1.22.2.tar.xz.
>
>> so I think we can fix same way under this
>> cogl/driver/gl/gles/cogl-driver-gles.c
> cu
> Adrian
>
--
BRs
Sandy(Li Changqing)
next prev parent reply other threads:[~2019-04-08 2:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 9:08 [PATCH] cogl: fix compile error with -Werror=maybe-uninitialized changqing.li
2019-04-02 11:31 ` Adrian Bunk
2019-04-03 2:29 ` Changqing Li
2019-04-03 9:58 ` Adrian Bunk
2019-04-04 2:06 ` Changqing Li
2019-04-04 8:11 ` Adrian Bunk
2019-04-08 2:12 ` Changqing Li [this message]
2019-04-04 13:42 ` Burton, Ross
2019-04-08 2:14 ` Changqing Li
2019-04-08 6:01 ` [PATCH V2] " changqing.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f044d899-2ad8-459c-cecc-1324a4cbc9d8@windriver.com \
--to=changqing.li@windriver.com \
--cc=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.