All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <festevam@denx.de>, Stefano Babic <sbabic@denx.de>,
	U-Boot-Denx <u-boot@lists.denx.de>,
	Schrempf Frieder <frieder.schrempf@kontron.de>,
	Tim Harvey <tharvey@gateworks.com>,
	dl-uboot-imx <uboot-imx@nxp.com>
Subject: Re: [PATCH 1/8] imx8mm: Fix USB reg addresses for i.MX8MM
Date: Sun, 4 Jul 2021 03:04:45 +0200	[thread overview]
Message-ID: <f04b60f6-7ffc-6ce2-f00d-2fe8e73e7f91@denx.de> (raw)
In-Reply-To: <CAOMZO5DFxVmGU+-xguWqcyJAhGC_TG3oFWbTkqYJ1ep1SrmqXA@mail.gmail.com>

On 7/3/21 11:38 PM, Fabio Estevam wrote:

[...]

>>> +#ifdef CONFIG_IMX8MM
>>> +#define USB1_BASE_ADDR               0x32E40000
>>> +#define USB2_BASE_ADDR               0x32E50000
>>> +#else
>>> +#define USB1_BASE_ADDR               0x38100000
>>> +#define USB2_BASE_ADDR               0x38200000
>>> +#endif
>>> +#define USB_BASE_ADDR                USB1_BASE_ADDR
>>> +#define USB1_PHY_BASE_ADDR   0x381F0000
>>> +#define USB2_PHY_BASE_ADDR   0x382F0000
>>
>> All of this should come from DT, no ?
> 
> Retrieving the USB base addresses from DT would be preferred, yes, but
> the current code does not do that.

I implemented exactly that in mx6_parse_dt_addrs() , see:
4dcfa3bcbcb ("usb: ehci-mx6: Parse USB PHY and MISC offsets from DT")

> Without providing these defines:
> 
> drivers/usb/host/ehci-mx6.c:254:62: error: ‘USB_BASE_ADDR’ undeclared
> (first use in this function); did you mean ‘SRC_BASE_ADDR’?
>    254 |  struct usbnc_regs *usbnc = (struct usbnc_regs
> *)(uintptr_t)(USB_BASE_ADDR +

I suspect you need CONFIG_PHY for mx8m .

  reply	other threads:[~2021-07-04  1:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-03 19:58 [PATCH 0/8] imx8mm: Add serial download support Fabio Estevam
2021-07-03 19:58 ` [PATCH 1/8] imx8mm: Fix USB reg addresses for i.MX8MM Fabio Estevam
2021-07-03 20:55   ` Marek Vasut
2021-07-03 21:38     ` Fabio Estevam
2021-07-04  1:04       ` Marek Vasut [this message]
2021-07-04 15:35         ` Fabio Estevam
2021-07-04 19:25           ` Marek Vasut
2021-07-06 16:11             ` Tim Harvey
2021-07-06 21:17               ` Marek Vasut
2021-07-07 17:37                 ` Simon Glass
2021-07-03 19:58 ` [PATCH 2/8] clock_imx8mm: Add enable_usboh3_clk() for i.MX8M Fabio Estevam
2021-08-06 12:12   ` Stefano Babic
2021-07-03 19:58 ` [PATCH 3/8] usb: ehci-mx6: move mode set/detect to probe Fabio Estevam
2021-07-03 19:58 ` [PATCH 4/8] usb: ehci-mx6: add IMX8MM and IMX8MN OTG support Fabio Estevam
2021-07-03 19:58 ` [PATCH 5/8] usb: ehci-mx6: Allow building SDP for imx8mm Fabio Estevam
2021-07-03 20:57   ` Marek Vasut
2021-07-03 21:39     ` Fabio Estevam
2022-03-27 21:02   ` Jaap Crezee
2022-03-27 21:43     ` Fabio Estevam
2022-03-28  7:17       ` Jaap Crezee
2022-03-28 10:26     ` Tommaso Merciai
2022-03-28 10:41       ` Jaap Crezee
2021-07-03 19:58 ` [PATCH 6/8] imx8mm_evk: Add an entry for USB boot Fabio Estevam
2021-07-03 19:58 ` [PATCH 7/8] imx8mm_evk: Add Serial Download Protocol support Fabio Estevam
2021-07-03 19:58 ` [PATCH 8/8] doc: imx8mm_evk: Add instructions for eMMC boot Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f04b60f6-7ffc-6ce2-f00d-2fe8e73e7f91@denx.de \
    --to=marex@denx.de \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=sbabic@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.