From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76DBEC433EF for ; Fri, 24 Sep 2021 14:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 508F260F4C for ; Fri, 24 Sep 2021 14:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346863AbhIXOx5 (ORCPT ); Fri, 24 Sep 2021 10:53:57 -0400 Received: from smtp.radex.nl ([178.250.146.7]:34377 "EHLO radex-web.radex.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346845AbhIXOx5 (ORCPT ); Fri, 24 Sep 2021 10:53:57 -0400 Received: from [192.168.1.35] (cust-178-250-146-69.breedbanddelft.nl [178.250.146.69]) by radex-web.radex.nl (Postfix) with ESMTPS id C8F902406A; Fri, 24 Sep 2021 16:52:21 +0200 (CEST) Subject: Re: [PATCH v2 2/7] PCI: ACPI: PM: Do not use pci_platform_pm_ops for ACPI To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Linux PCI , Linux ACPI , LKML , Bjorn Helgaas , Andy Shevchenko , Mika Westerberg References: <1800633.tdWV9SEqCh@kreacher> <8879480.rMLUfLXkoz@kreacher> <069444f7-d623-fae2-5cd0-83cbbc919aff@gmail.com> From: Ferry Toth Message-ID: Date: Fri, 24 Sep 2021 16:52:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, Op 24-09-2021 om 14:02 schreef Rafael J. Wysocki: > On Thu, Sep 23, 2021 at 10:32 PM Ferry Toth wrote: >> Hi >> >> Op 23-09-2021 om 15:51 schreef Ferry Toth: >>> Repost (with formatting removed, sorry for the noise) >>> Op 23-09-2021 om 13:30 schreef Rafael J. Wysocki: >>>> On Wed, Sep 22, 2021 at 11:31 PM Ferry Toth wrote: >>>>> Hi, >>>>> Op 20-09-2021 om 21:17 schreef Rafael J. Wysocki: >>>>>> From: Rafael J. Wysocki >>>>>> >>>>>> Using struct pci_platform_pm_ops for ACPI adds unnecessary >>>>>> indirection to the interactions between the PCI core and ACPI PM, >>>>>> which is also subject to retpolines. >>>>>> >>>>>> Moreover, it is not particularly clear from the current code that, >>>>>> as far as PCI PM is concerned, "platform" really means just ACPI >>>>>> except for the special casess when Intel MID PCI PM is used or when >>>>>> ACPI support is disabled (through the kernel config or command line, >>>>>> or because there are no usable ACPI tables on the system). >>>>>> >>>>>> To address the above, rework the PCI PM code to invoke ACPI PM >>>>>> functions directly as needed and drop the acpi_pci_platform_pm >>>>>> object that is not necessary any more. >>>>>> >>>>>> Accordingly, update some of the ACPI PM functions in question to do >>>>>> extra checks in case the ACPI support is disabled (which previously >>>>>> was taken care of by avoiding to set the pci_platform_ops pointer >>>>>> in those cases). >>>>>> >>>>>> Signed-off-by: Rafael J. Wysocki >>>>>> --- >>>>>> >>>>>> v1 -> v2: >>>>>> * Rebase on top of the new [1/7] and move dropping struct >>>>>> pci_platform_pm_ops to a separate patch. >>>>> I wanted to test this series on 5.15-rc2 but this patch 2/7 doesn't >>>>> apply (after 1/7 applied). Should I apply this on another tree? >>>> This is on top of >>>> https://patchwork.kernel.org/project/linux-acpi/patch/2793105.e9J7NaK4W3@kreacher/ >>>> >>>> which is not yet in any tree. >>>> >>>> Sorry for the confusion. >>> No problem at all. If I can I will try to report back tonight. Else, >>> will be delayed 2 due to a short break. >> With those 3 extra patches followed by 7 from this series it builds. But >> on boot I get: >> dwc3 dwc3.0.auto: this is not a DesignWare USB3 DRD Core >> Then after this it reboots. Nothing in the logs. Nothing else on >> console, I guess something goes wrong early. > It appears so. > > Can you please try just the 3 extra patches this series is on top of? > The problem is more likely to be located in one of them. Yes, I hope to be able to that this evening.