All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Bertrand Marquis <Bertrand.Marquis@arm.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	"Julien Grall" <jgrall@amazon.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Jan Beulich" <jbeulich@suse.com>, "Wei Liu" <wl@xen.org>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and...
Date: Fri, 29 Jul 2022 22:54:20 +0100	[thread overview]
Message-ID: <f070e2e8-2821-4ee9-211e-22542df036a6@xen.org> (raw)
In-Reply-To: <36782478-2EF8-45C6-A1CC-1E299704F33B@arm.com>

On 21/07/2022 09:40, Bertrand Marquis wrote:
> Hi Julien,

Hi Bertrand,

>> On 20 Jul 2022, at 19:44, Julien Grall <julien@xen.org> wrote:
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> move it to Kconfig.
>>
>> The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide
>> helpers to map/unmap a domain page. Rename it to the define to
> 
> Maybe “the define to” can be removed in this sentence or it needs some rephrasing.

I have removed "the define to".

> 
>> CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove
>> support for domain page (this is not a concept that Xen can't get
>> away with).
>>
>> Take the opportunity to move CONFIG_MAP_DOMAIN_PAGE to Kconfig as this
>> will soon be necessary to use it in the Makefile.
>>
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
> 
> With this fixed:
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> #arm part

Thanks!

Cheers,

-- 
Julien Grall


  reply	other threads:[~2022-07-29 21:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 18:44 [PATCH v2 0/5] xen/arm: mm: Bunch of clean-ups Julien Grall
2022-07-20 18:44 ` [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines Julien Grall
2022-07-21  8:09   ` Bertrand Marquis
2022-07-21  8:35   ` Luca Fancellu
2022-07-20 18:44 ` [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization Julien Grall
2022-07-21  8:36   ` Bertrand Marquis
2022-07-21  9:42   ` Luca Fancellu
2022-07-20 18:44 ` [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and Julien Grall
2022-07-21  8:40   ` Bertrand Marquis
2022-07-29 21:54     ` Julien Grall [this message]
2022-07-25 15:51   ` Jan Beulich
2022-07-29 21:53     ` Julien Grall
2022-07-20 18:44 ` [PATCH v2 4/5] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file Julien Grall
2022-07-21 10:07   ` Jan Beulich
2022-07-21 10:09     ` Julien Grall
2022-07-21 10:41   ` Bertrand Marquis
2022-07-20 18:44 ` [PATCH v2 5/5] xen/arm: mm: Reduce the area that xen_second covers Julien Grall
2022-07-21 10:47   ` Bertrand Marquis
2022-07-21  8:59 ` [PATCH v2 0/5] xen/arm: mm: Bunch of clean-ups Bertrand Marquis
2022-07-29 22:04 ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f070e2e8-2821-4ee9-211e-22542df036a6@xen.org \
    --to=julien@xen.org \
    --cc=Bertrand.Marquis@arm.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jgrall@amazon.com \
    --cc=roger.pau@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.